xoops forums

sabahan

Quite a regular
Posted on: 2013/1/26 5:49
sabahan
sabahan (Show more)
Quite a regular
Posts: 317
Since: 2006/3/4 5
#11

Re: XOOPS 2.5.6 Beta 1 Released for Testing

xoopscomments table is missing from package and also in svn

Mamba

Moderator
Posted on: 2013/1/26 17:11
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#12

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Both issues have been now fixed in SVN.

Can you check if it works now?

Thank you all for testing and for reporting!
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Mamba

Moderator
Posted on: 2013/1/26 17:15
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#13

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Quote:
im trying extcal 2.37 rc4 in 2.5.6 i have this error when trying to create category

I'll look into it. I have to find the time to finalize extCal. There are still few issues open, but I've been too busy.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

geekwright

Quite a regular
Posted on: 2013/1/26 22:50
geekwright
geekwright (Show more)
Quite a regular
Posts: 276
Since: 2010/10/15
#14

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Quote:

Mamba wrote:
Both issues have been now fixed in SVN.

Can you check if it works now?


I pulled 2.5.6 from SVN and things are working quite well. Fresh installs in both PHP 5.3.10 and 5.4.6 went smooth. Comments are back and functional. After running both installs through a variety of activities, the logs are clean of messages coming from XOOPS itself. (Wish I could say the same for all of my code ;)

The only curious thing under 5.4 was that logger shows this message on the admin preferences general settings:
Notice: Array to string conversion in file /class/xoopsform/formhidden.php line 78

It is just on general settings, but it is consistent. It doesn't seem to cause any obvious problem.

Overall, two thumbs up from here!

sabahan

Quite a regular
Posted on: 2013/1/27 0:58
sabahan
sabahan (Show more)
Quite a regular
Posts: 317
Since: 2006/3/4 5
#15

Re: XOOPS 2.5.6 Beta 1 Released for Testing

XOOPScomments .....svn OK..

XOOPS 2.5.6 package in news release is still not updated..no xoopscomments table

sabahan

Quite a regular
Posted on: 2013/1/27 1:04
sabahan
sabahan (Show more)
Quite a regular
Posts: 317
Since: 2006/3/4 5
#16

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Quote:

Mamba wrote:
Quote:
im trying extcal 2.37 rc4 in 2.5.6 i have this error when trying to create category

I'll look into it. I have to find the time to finalize extCal. There are still few issues open, but I've been too busy.


i have this problem with extcal only when using 2.5.6

in 2.5.5 it is working ok

same environment

PHP Version 5.3.1
mySQL Version 5.1.41

Mamba

Moderator
Posted on: 2013/1/27 3:33
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#17

Re: XOOPS 2.5.6 Beta 1 Released for Testing

@ Sabahan:
Quote:
XOOPS 2.5.6 package in news release is still not updated..no xoopscomments table

Uploading, as we speak....

@geekwright:
Quote:
The only curious thing under 5.4 was that logger shows this message on the admin preferences general settings:
Notice: Array to string conversion in file /class/xoopsform/formhidden.php line 78

I think, I fixed, but before I submit it to SVN, I sent to the Core Team to see if they know a better way.

Basically, what it is, in formhidden.php we assign an array value to a string:

function setValue($value)
    {
            
$this->_value $value;
    }


It works fine, but when we read it back with "getValue" in:

function render()
    {
        return 
'<input type="hidden" name="' $this->getName() . '" id="' $this->getName() . '" value="' $this->getValue() . '" />';
}


PHP complains.

So I've changed the saving routine to check first if this is an array:

function setValue($value)
    {
        if (
is_array($value)) {
            
$this->_value $value[0];
        } else {
            
$this->_value $value;
        }
    }


and it's working fine, but I want to make sure that this change won't impart something else in the Core.

Once the Core Team is OK with it, I'll commit it to SVN.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

irmtfan

Module Developer
Posted on: 2013/1/28 4:33
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#18

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Very needed release.
I specially gald to see fast comment hack in this release. IMO it is very good and final for registered users. But about anon users maybe we need more features to limit choosing any user/email/url

@ core developers:
do you want to close open 2.5.5 bugs in 2.5.6?
some of them doing a major role in production websites specially ML and multibytes sites.

1- xoops_getConfigOption('language') is wrongly return (priority: very high)
http://sourceforge.net/p/xoops/bugs/1220/

2- xoopsUserTheme is not regenerate in remember me
http://sourceforge.net/p/xoops/bugs/1225/

also some of them are just minor issues:

3- alter table 'user' user_sig and bio fields to 'text'
http://sourceforge.net/p/xoops/bugs/1213/

4- template set is not updated based on template file
http://sourceforge.net/p/xoops/bugs/1221/

Mamba

Moderator
Posted on: 2013/1/28 6:45
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#19

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Quote:
do you want to close open 2.5.5 bugs in 2.5.6?
some of them doing a major role in production websites specially ML and multibytes sites.

This release is mainly to make XOOPS 2.5.x working under PHP 5.4 and to incorporate the security patch, so there will be no major changes, except the Fast Comment.

Unless there is a ready bug fix that has been tested, and has no negative impact on migration to XOOPS 2.6.0.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Mamba

Moderator
Posted on: 2013/1/28 10:28
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#20

Re: XOOPS 2.5.6 Beta 1 Released for Testing

Quote:
im trying extcal 2.37 rc4 in 2.5.6 i have this error when trying to create category

I couldn't replicate it. I've tried on both PHP 5.4.8 and PHP 5.3.18
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs