xoops forums

Shine

Just can't stay away
Posted on: 2012/7/1 20:48
Shine
Shine (Show more)
Just can't stay away
Posts: 822
Since: 2002/7/22
#11

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

BUG:
linkloadinfo.php
Last line. PHP closing tag is missing
?>

Mamba

Moderator
Posted on: 2012/7/1 21:08
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#12

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

Quote:
Last line. PHP closing tag is missing

We are successively removing them.

See here

See also the Zend Framework guidelines:
Quote:
For files that contain only PHP code, the closing tag ("?>") is never permitted. It is not required by PHP, and omitting it´ prevents the accidental injection of trailing white space into the response
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Anonymous

Posted on: 2012/7/1 21:36
Anonymous
Anonymous (Show more)
Posts: 0
Since:
#13

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

Quote:
Shine: To see if that is the problem, try to reinstall the version before the array fix release. Then see what happens. If problem then isn't there, we know the fix occurs this new/ýour' problem.


I tried the same latest version on nlxoops.nl (2.5.4) and demo.nlxoops.nl (2.5.5). nlxoops refuses to show the links but on demo.nlxoops there is no problem. Will try a fresh upload tomorrow... [dutchmode]Schiet mij maar lek! [/dutchmode]

Mamba

Moderator
Posted on: 2012/7/1 23:30
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#14

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

Quote:
I tried the same latest version on nlxoops.nl (2.5.4) and demo.nlxoops.nl (2.5.5). nlxoops refuses to show the links but on demo.nlxoops there is no problem.

We encourage everybody to update to XOOPS 2.5.5. It is our most stable version. We are running it here on XOOPS Website, and have no problems...

To be honest, since XOOPS 2.5.5 is much better and more stable, I don't test anything on XOOPS 2.5.4 anymore.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Shine

Just can't stay away
Posted on: 2012/7/2 7:59
Shine
Shine (Show more)
Just can't stay away
Posts: 822
Since: 2002/7/22
#15

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5


BUG:

Short overview other submittions by user. Link to entry doesn't work. That is because de name of the module isn't picked up.
<{$link.module_dir}>/
should be: <{$wfllink.module_dir}>/


FIX:
File: templates->wflinks_singlelink.html
Line prox: 116
old code
<{if $wfllink.otherlinx 0}>
<
br /><{$other_links}>
<{foreach 
item=link_user from=$link_uid}>
   <
div style="margin-left: 10px;"> <a href="<{$xoops_url}>/modules/<{$link.module_dir}>/singlelink.php?cid=<{$link_user.cid}>&amp;lid=<{$link_user.lid}>"><{$link_user.title}></a> (<{$link_user.published}>) </div>
<{/foreach}>
<{/if}>

Replace with:
<{if $wfllink.otherlinx 0}>
<
br /><{$other_links}>
<{foreach 
item=link_user from=$link_uid}>
   <
div style="margin-left: 10px;"> <a href="<{$xoops_url}>/modules/<{$wfllink.module_dir}>/singlelink.php?cid=<{$link_user.cid}>&amp;lid=<{$link_user.lid}>"><{$link_user.title}></a> (<{$link_user.published}>) </div>
<{/foreach}>
<{/if}>

Mamba

Moderator
Posted on: 2012/7/2 8:22
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#16

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

Thanks! Fixed in SVN
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

phira

Just popping in
Posted on: 2012/7/2 8:27
phira
phira (Show more)
Just popping in
Posts: 14
Since: 2009/3/28
#17

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

did anyone tried the specific internal permissions of the module? It seems not working on my website ( yes, with xoops 2.55, mamba )
don't be too serious, just do things seriously

Shine

Just can't stay away
Posted on: 2012/7/2 10:29
Shine
Shine (Show more)
Just can't stay away
Posts: 822
Since: 2002/7/22
#18

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

They stick/work with me!

Anonymous

Posted on: 2012/7/2 16:37
Anonymous
Anonymous (Show more)
Posts: 0
Since:
#19

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

Quote:
We encourage everybody to update to XOOPS 2.5.5. It is our most stable version. We are running it here on XOOPS Website, and have no problems...


I know Mamba, but it was a hell of a job to get all date issues fixed and the news module ready to work with current setup. I'm a bit worried what happens when upgrading... I'll give it a try on a rainy day (not the next days please!)

I tried the latest svn version with 2.5.4 but still the same issue. Not a big problem as the links module is still waiting to get filled and go live. I'll try again after updating the core

Mamba

Moderator
Posted on: 2012/7/2 17:18
Mamba
Mamba (Show more)
Moderator
Posts: 10799
Since: 2004/4/23
#20

Re: WF-Links 1.09 RC ready for testing on XOOPS 2.5.5

Quote:
I tried the latest svn version with 2.5.4 but still the same issue. Not a big problem as the links module is still waiting to get filled and go live.

XOOPS 2.5.4 had the date issue, but it has been fixed in XOOPS 2.5.5.
Try to test it locally with something like Wampserver to make sure that all your modules are working.

If there are bugs with the module, please let us know, and we'll try to fix them.

We are finally getting closer to release the Basic Module Pack! There are still few modules open, but the majority is done!
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs