XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. Xoops Development / 
  3. Xoops Development 
  4.  / New wysiwyg Editor for xoops needs testers
Register
1
samuels
New wysiwyg Editor for xoops needs testers

  • 2004/6/23 7:49

  • samuels

  • Quite a regular

  • Posts: 249

  • Since: 2003/10/30


I'm making a wysiwyg editor for xoops. It runs under internet explorer and gecko browsers.

You can download the last release here
http://dev.xoops.org/modules/xfmod/project/showfiles.php?group_id=1038

(wysiwyg_sections.zip)

I have cloned a module for testing the editor. Just download it, install like a normal module and you'll be able to test it.

It's in alpha stage, but you can help me reporting bugs and suggestions.

A screenshot:

Resized Image
2
Mithrandir
Re: New wysiwyg Editor for xoops needs testers

Will test it extensively in Mozilla 1.6.

Good work.
3
Mithrandir
Re: New wysiwyg Editor for xoops needs testers

Seems to work, but looking at the code, I'm a little concerned with whether it will work with multiple wysiwygareas on one page.

Your phpDoc comments talk about a 7th parameter, $js, which is not in the function (but I guess you do it with the $koivi_editor_instances?)


In this function:
function checkBrowser()
  {
    global $HTTP_SERVER_VARS;
    
    $browser = $HTTP_SERVER_VARS['HTTP_USER_AGENT'];
    // check if msie
    if (eregi("MSIE[^;]*",$browser,$msie))
    {
      // get version 
      if (eregi("[0-9]+.[0-9]+",$msie[0],$version))
      {
        // check version
        if ((float)$version[0]>=5.5)
        {
          // finally check if it's not opera impersonating ie
          if (!eregi("opera",$browser))
          {
            return true;
          }
        }
      }
    }
    return false;
  }

You use $msie and $version - where are they defined?
4
Anonymous
Re: New wysiwyg Editor for xoops needs testers

  • 2004/6/23 10:24

  • Anonymous

  • Posts: 0

  • Since:


Good work samuels!

I already adapted other modules to work with your editor.

A few things:

- the dropdown windows for colors and table are too small for firefox 09 win
- width of editor should be 100% instead of fixed pixel value
- implementation of XOOPS imagemanager would be nice (drag and drop works for me, so np)
- font-tags should be avoided
- is it correct, that colspan +/- is not possible?

Keep up the good work!!!
5
Mithrandir
Re: New wysiwyg Editor for xoops needs testers

Disregard my previous comments about undefined variables - just not familiar with the ereg/eregi function.

I would say that implementing XOOPS image manager into the editor is a MUST.
6
samuels
Re: New wysiwyg Editor for xoops needs testers

  • 2004/6/23 11:17

  • samuels

  • Quite a regular

  • Posts: 249

  • Since: 2003/10/30


Mith, My own documentation is obsolete the last parameter is not required in new version.

About imagemanager integration, it's easy to do, but I need to change the imagemanager template.
We can't change the templates for each editor(spaw,htmlarea,koivi,fckeditor...)
There are two possibilities:
-Make a generic javascript insert function (I'm trying without success).
-To have a distinct imagemanager template for each editor (I don't know how to do it).

Mmm, colspan +/- must work, try putting the cursor in the left cell. For example if you want to merge two cells

| cell1 | cell2 |

Cursor must be inside "cell1".

-Some styles are messy under gecko browsers. (Added to the bug list)
7
Mithrandir
Re: New wysiwyg Editor for xoops needs testers

What's the problem with it? How should the image be inserted?

If you outline what you need in order for it to work I'll see what I can do about it (I'm guessing that what you need is a special format of the image link returned from the ImageManager JavaScript?)
8
samuels
Re: New wysiwyg Editor for xoops needs testers

  • 2004/6/23 11:27

  • samuels

  • Quite a regular

  • Posts: 249

  • Since: 2003/10/30


I must add something similar to this in imagemanager template:

onclick="window.opener.Xoops_Koivi_InsertImage(<{$target}>,<{$images[i].src}>,"");">


The problem is that each editor uses it's own insert image function. If I make one that runs on all editors we can put the necessary js code inside xoops.js
9
Mithrandir
Re: New wysiwyg Editor for xoops needs testers

How about setting a standard for wysiwyg-editors, which will need to have a JS function called something like "Xoops_Wysiwyg_InsertImage(target, source, whatsthis)" and then it is the responsibility of each wysiwyg editor to implement/override this function in their rendered javascript code?

If you can give me that as well as the code needed to get it to work with the XoopsFormDhtmlArea, I'll see to it that it will be implemented in the XOOPS core.
10
Jace303
Re: New wysiwyg Editor for xoops needs testers

  • 2004/6/23 15:22

  • Jace303

  • Just popping in

  • Posts: 38

  • Since: 2003/11/5


Has anyone tested the editor with Opera 7.5x?
(1) 2 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

405 user(s) are online (318 user(s) are browsing Support Forums)

Members: 0

Guests: 405

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits