82
Just wanted to mention here... since I been criticising the downloads module a bit
![](https://xoops.org/uploads/smil42e7a3d4c7b9f.gif)
The actual classes for download and upload are not that bad Its the modules that makes it a bit "jiffy".
I think it also should tie in more to the automatic mime handling in php, but thats my view
![](https://xoops.org/uploads/smil3dbd4d6422f04.gif)
Just though that I should mention that after looking through the code as I have done now.
And BTW...
The upload.php isnt bugged, it is supposed to > 0
The tests says, if there is anything in the mime-array and the mime-type doesnt exists, then it is false, otherwise its true.
The problem with that statement only comes when there isnt anything in the array, or rather, if its an empty array.
since it defaults to something, the module can leave it as it is or has to overide it and if they override it with a zero length array then I would consider it a bug in the module, not the class.