Hi devs,
i'm tryin'g to port the "tplleaguestats" script into xoops.
I think that it wouldn't be difficult for an experienced coder but i'm a beginner
I faced two big problems:

1)Thew whole scipt(expecially the admin section) uses php sessions for admin authentication and this doesn't agree with XOOPS modules management.

Do i have to bypass or delete the sessions at all?
And if so,how can i do this?


2)The script retreives the MySQL connection data from a file on the server(user.php):
-----------------------
$host = 'localhost';
$user = 'root';
$password = '';
$txt_db_name = 'databasename';
----------------------

How can i change this and force the script to
retrieve the data from XOOPS database?

I know that these are annoing questions but very important for my work to go on.
Thanks in advance.

On all pages include mainfile.php in the top and footer.php in the bottom and use the $xoopsUser functionality to determine whether a user is logged in or not.

Change all database queries to go through $xoopsDB->query instead of through the original method.

See how the existing modules are structured and go from there.

GL

Thank you mith,
i've understood what you said and i'll follow your suggestions.
I have another practical thing to ask you:
Please take a look at this piece of code and give me
a short explain and (possibly) tell me how can i move on...

__________________________________
//this piece stands in almost all the pages,
//and loads the db connection data.Can i delete it?
//

session_start();

include('admin/user.php');
$connection = mysql_connect("$host","$user","$password")
or die(mysql_error());
mysql_select_db("$txt_db_name",$connection)
or die(mysql_error());

//
//Includes preferences
//
$pref = mysql_query("SELECT * FROM tplls_preferences WHERE ID = '1'",$connection)
or die(mysql_error());
$pdata = mysql_fetch_array($pref);
mysql_free_result($pref);

$team_name = $pdata['teamname'];
$d_seasonid = $pdata['defaultseasonid'];
$show_all_or_one = $pdata['defaultshow'];
$show_table = $pdata['defaulttable'];
$language = $pdata['defaultlanguage'];
$for_win = $pdata['forwin'];
$for_draw = $pdata['fordraw'];
$for_lose = $pdata['forloss'];
$print_date = $pdata['printdate'];
$top_bg = $pdata['topoftable'];
$bg1 = $pdata['bg1'];
$bg2 = $pdata['bg2'];
$inside_c = $pdata['inside'];
$border_c = $pdata['bordercolour'];
$tb_width = $pdata['tablewidth'];
$accept_ml = $pdata['acceptmultilanguage'];

//
//Query to get last updated date and time
//
//Use site http://www.mysql.com/doc/en/Date_and_time_functions.html (DATE_FORMAT)
//to return date format that fits to your site
//
$updated_query = mysql_query("
SELECT DATE_FORMAT(last_updated, '%d.%m.%Y at %H:%i') AS last_updated FROM tplls_preferences WHERE ID = '1'", $connection)
or die(mysql_error());
$ludata = mysql_fetch_array($updated_query);
$last_update = $ludata['last_updated'];
mysql_free_result($updated_query);

//
//If session variables are registered
//What are these session variables?Are they necessary?

if(!session_is_registered('defaultlanguage') || !session_is_registered('defaultseasonid') || !session_is_registered('defaultshow') || !session_is_registered('defaulttable'))
{
$_SESSION['defaultlanguage'] = $language;
$_SESSION['defaultseasonid'] = $d_seasonid;
$_SESSION['defaultshow'] = $show_all_or_one;
$_SESSION['defaulttable'] = $show_table;
$defaultlanguage = $_SESSION['defaultlanguage'];
$defaultseasonid = $_SESSION['defaultseasonid'];
$defaultshow = $_SESSION['defaultshow'];
$defaulttable = $_SESSION['defaulttable'];
}
else
{
$defaultlanguage = $_SESSION['defaultlanguage'];
$defaultseasonid = $_SESSION['defaultseasonid'];
$defaultshow = $_SESSION['defaultshow'];
$defaulttable = $_SESSION['defaulttable'];
}

//
//Gets seasons and match types for dropdowns
//How can i replace this query with the XOOPS one?

$get_seasons = mysql_query("SELECT * FROM tplls_seasonnames WHERE SeasonPublish = '1' ORDER BY SeasonName",$connection)
or die(mysql_error());

//
//Sort by points, sort variable is not set
//
$sort = $_REQUEST['sort'];
if(!isset($sort))
{
$sort = 'pts';
}


?>

//
//INCLUDES HEADER.PHP
//
include('header.php');

//
//Includes languages
//
include('language.inc');

?>



___________________________________

I hope i won't bore you...
thanks again.

OK, let's take a look
Quote:

I'll reply in a minute with the module structure

Thank you,in the meantime i'm going to apply the code you edited...

Hi mith,i've edited the file.
Now i have:
__________________

//session_start();

//include('admin/user.php');
//$connection = mysql_connect("$host","$user","$password")
//or die(mysql_error());
//mysql_select_db("$txt_db_name",$connection)
//or die(mysql_error());

include ('../../mainfile.php');

//
//Includes preferences
//
$pref = mysql_query("SELECT * FROM xoops_myleague_preferences WHERE ID = '1'")
or die(mysql_error());
$pdata = mysql_fetch_array($pref);
mysql_free_result($pref);

$team_name = $pdata['teamname'];
$d_seasonid = $pdata['defaultseasonid'];
$show_all_or_one = $pdata['defaultshow'];
$show_table = $pdata['defaulttable'];
$language = $pdata['defaultlanguage'];
$for_win = $pdata['forwin'];
$for_draw = $pdata['fordraw'];
$for_lose = $pdata['forloss'];
$print_date = $pdata['printdate'];
$top_bg = $pdata['topoftable'];
$bg1 = $pdata['bg1'];
$bg2 = $pdata['bg2'];
$inside_c = $pdata['inside'];
$border_c = $pdata['bordercolour'];
$tb_width = $pdata['tablewidth'];
$accept_ml = $pdata['acceptmultilanguage'];

//
//Query to get last updated date and time
//
//Use site http://www.mysql.com/doc/en/Date_and_time_functions.html (DATE_FORMAT)
//to return date format that fits to your site
//

$updated_query = $xoopsDB->query("
SELECT DATE_FORMAT(last_updated, '%d.%m.%Y at %H:%i') AS last_updated FROM xoops_myleague_preferences WHERE ID = '1'");
$ludata = $xoops->fetchArray($updated_query);
$last_update = $ludata['last_updated'];
mysql_free_result($updated_query);

//
//If session variables are registered
//
if(!session_is_registered('defaultlanguage') || !session_is_registered('defaultseasonid') || !session_is_registered('defaultshow') || !session_is_registered('defaulttable'))
{
$_SESSION['defaultlanguage'] = $language;
$_SESSION['defaultseasonid'] = $d_seasonid;
$_SESSION['defaultshow'] = $show_all_or_one;
$_SESSION['defaulttable'] = $show_table;
$defaultlanguage = $_SESSION['defaultlanguage'];
$defaultseasonid = $_SESSION['defaultseasonid'];
$defaultshow = $_SESSION['defaultshow'];
$defaulttable = $_SESSION['defaulttable'];
}
else
{
$defaultlanguage = $_SESSION['defaultlanguage'];
$defaultseasonid = $_SESSION['defaultseasonid'];
$defaultshow = $_SESSION['defaultshow'];
$defaulttable = $_SESSION['defaulttable'];
}

//
//Gets seasons and match types for dropdowns
//

$get_seasons = $xoopsDB->query("SELECT * FROM xoops_myleague_seasonnames WHERE SeasonPublish = '1' ORDER BY SeasonName");

//
//Sort by points, sort variable is not set
//
$sort = $_REQUEST['sort'];
if(!isset($sort))
{
$sort = 'pts';
}


?>

//
//INCLUDES HEADER.PHP
//
include(XOOPS_ROOT_PATH.'/header.php');

//
//Includes languages
//
//include('language.inc');

?>


______________________________________

Notice that i've added

"include ('../../footer.php');"

just before the end of file,was i right?



Btw i turned xoops's php debug on and it gives:
______________________
"Fatal error: Call to a member function on a non-object in c:\programmi\easyphp\www\xoops\modules\simpnews\index.php on line 75"
________________

Line 75 is:
_____________________
$ludata = $xoops->fetchArray($updated_query);
_______________________

Now remain the "includes preferences" and "session variables" matter;
what about this?

I stay tuned...

$xoopsDB->fetchArray - not $xoops->fetchArray

It'll have to wait until tomorrow or Tuesday (very busy day tomorrow) before I can get back to you on the preferences thing, but look at an existing module's xoops_version.php - I recommend the news module, because it has a lot of comments explaining how the lines work.

It'll also require some re-thinking since your script seems to be able to remember the user's own preferences, but let's take that when we get to it.

What you should do, however, is to first get the xoops_version.php to work properly, so you can install the module through the administration menu.

For that to work, you mainly need to get the tables listed in a xoops_version.php file in your module's folder.

After that, you should weed out any mysql_xxxx function calls and change them to use the $xoopsDB->query and $xoopsDB->fetchArray functions instead.

So let's take it from there.

thank you precious helper...
i'll follow your recommendations
and report any results to you tomorrow evening or tuesday at later.
good night.

I'll have to wait until tomorrow before looking at this, sorry. (23 PM here and I need to go to bed rather early today - got way too little sleep last night)

Quote:

Ok,goodnight.
I'll be waiting 'til tomorrow too.