xoops forums

Mamba

Moderator
Posted on: 1/30 23:39
Mamba
Mamba (Show more)
Moderator
Posts: 10676
Since: 2004/4/23
#11

Re: PHP 7.2 RELEASED

Thanks!
I'll look into it and will let you know...
Support XOOPS => DONATE
Use 2.5.9 | Docs | Modules | Bugs

aquaportail

Just popping in
Posted on: 1/31 9:45
aquaportail
aquaportail (Show more)
Just popping in
Posts: 20
Since: 2007/7/18
#12

Re: PHP 7.2 RELEASED

It could be a good thing to uniformize file XoopsFormRendererLegacy.php (class) with simple quote and double quote for return...

Sometimes, it's (for example):
return "<input type='color'...

and some others are:
return '<input type="hidden"...


The best way is probably:
return '<input type="hidden"...

as HTML principaly uses double quote.

Mamba

Moderator
Posted on: 2/1 18:55
Mamba
Mamba (Show more)
Moderator
Posts: 10676
Since: 2004/4/23
#13

Re: PHP 7.2 RELEASED

I agree.
Do you think, you could help us with that?
Just fork it on GitHub, make changes, and submit it back as a Pull Request.
Support XOOPS => DONATE
Use 2.5.9 | Docs | Modules | Bugs