XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. General XOOPS.org forums / 
  3. Technology, Tools, Best Practices 
  4.  / PHP 7.2 RELEASED
Register
11
Mamba
Re: PHP 7.2 RELEASED

  • 2019/1/30 23:39

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Thanks!
I'll look into it and will let you know...
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs
12
aquaportail
Re: PHP 7.2 RELEASED

It could be a good thing to uniformize file XoopsFormRendererLegacy.php (class) with simple quote and double quote for return...

Sometimes, it's (for example):
return "<input type='color'...

and some others are:
return '<input type="hidden"...


The best way is probably:
return '<input type="hidden"...

as HTML principaly uses double quote.
13
Mamba
Re: PHP 7.2 RELEASED

  • 2019/2/1 18:55

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


I agree.
Do you think, you could help us with that?
Just fork it on GitHub, make changes, and submit it back as a Pull Request.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs
« 1 (2)

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

147 user(s) are online (100 user(s) are browsing Support Forums)

Members: 0

Guests: 147

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits