11
xoobaru
Re: Theme select block displays a comressed select box
  • 2013/1/19 20:24

  • xoobaru

  • Just can't stay away

  • Posts: 494

  • Since: 2010/12/2


Yeahh, that worked, I think we got closure on this. One side note, the original class in this template needed to be replaced rather than added (appended) to, as the script would always call the original class unless it was deleted even after updating the system module.

I can now adjust the width at will, and while I have not tried, I suppose it is also possible to use the width: 100%; or width: auto; as well.

I still get the

(3
Themes)

effect on the text, but I can live with it or follow up later.

Thanks irmtfan, flipse, and Mamba. It definitely looks professional now rather than like a hastily construed hack.

Whoever oversees what gets carried forward into future releases (Cesag? Mamba?) might want to schedule this into the next one so it gets propagated. I realize that the larger side of the issue rests in the theme side of things rather than XOOPS itself.

12
irmtfan
Re: Theme select block displays a comressed select box
  • 2013/1/20 4:18

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


yes, width: 100%; width: 90% will be the best solution.

the main issue here is that old hardcode issue in xoops codes.
here we have a very long html code in php file as a smarty definition.
in (xoops255_or_260)/modules/system/blocks/system_blocks.php around line 561:
if ($options[0] == 1) {
        
$block['theme_select'] = "2" id="xoops_theme_img" src="".XOOPS_THEME_URL."/".$xoopsConfig['theme_set']."/shot.gif" alt="screenshot" width="".intval($options[1])."" />xoops_theme_select" name="xoops_theme_select" onchange="showImgSelected('xoops_theme_img''xoops_theme_select''themes''/shot.gif''".XOOPS_URL."');">".$theme_options."submit" value=""._GO."" />";
    } else {
        
$block['theme_select'] = ''.$theme_options.'';
    }

    
$block['theme_select'] .= '('.sprintf(_MB_SYSTEM_NUMTHEME''.count($xoopsConfig['theme_set_allowed']).''
).')';


as you can see it should be in template not in php file. then you can customize it easily.

Login

Who's Online

192 user(s) are online (129 user(s) are browsing Support Forums)


Members: 0


Guests: 192


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits