71
Cesagonchu
Re: News 1.67 RC 3

Thank you Mamba

Quote:
=> Images of articles do not download

I am not sure I understand it

The upload doesn't work



Quote:
=> The module does not validate the change of editor (eg TinyMCE)

How and why should it do it? You change the Editor in preferences, and that's it. Do I miss something here?

Yes, when I change the Editor, nothing change.



72
Cesagonchu
Re: News 1.67 RC 3

I tested the new version of svn. The change of editor works.

Sending pictures when I click on "Select a picture to attach to the news," does not work with the editor "DHTML Form with xCode."

There is also a problem when updating the module. We must remove the file "news" that is in the folder "uploads", in the root of the site, if you do not want to display many errors.

The subtitles are still not displayed.

73
Mazarin
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 8:10

  • Mazarin

  • Just can't stay away

  • Posts: 533

  • Since: 2008/12/10


Why would the editor have any effect on the upload of a picture in a completely separate field?

I would also like to suggest to make the attached picture for the news aligned according to the radio buttons for the topic image (which it replaces) rather than being fixed to left in the template. It's a simple fix and I've done it already if you think it's worth including.

Since the attached picture is replacing the topic image it seems to me it would be more natural to have that field right after the topic image options. I'm working to fix that as well, so I could submit that here too if you're interested.

I'm not able to check it now, but I would assume the reason for subtitles not showing is that it's not in the template?


74
Mamba
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 14:13

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


@ Mazarin:
Quote:
I would also like to suggest to make the attached picture for the news aligned according to the radio buttons for the topic image (which it replaces) rather than being fixed to left in the template. It's a simple fix and I've done it already if you think it's worth including.

Sure, if it's tested and it's working, please add it to SVN

Quote:
Since the attached picture is replacing the topic image it seems to me it would be more natural to have that field right after the topic image options. I'm working to fix that as well, so I could submit that here too if you're interested.

Please do.

Quote:
I'm not able to check it now, but I would assume the reason for subtitles not showing is that it's not in the template?

That's my guess too. I'll try to look into it today or tomorrow, unless somebody is faster
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

75
Mazarin
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 14:49

  • Mazarin

  • Just can't stay away

  • Posts: 533

  • Since: 2008/12/10


A quick search revealed that the subtitle is only there for input and in the makepdf file, so the "bug" is that the subtitle is not displayed anywhere, ie. there's no presentation code for it at all.

Someone (who has an idea on how they want to use it) will have to figure out where it would make sense to display the subtitle and simply assign the variable in the php code and add the variable in the template.

76
Mamba
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 15:34

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Quote:
Someone (who has an idea on how they want to use it) will have to figure out where it would make sense to display the subtitle and simply assign the variable in the php code and add the variable in the template.

I've uploaded it to SVN, but some designers might take a look at that, if it's good enough, or if we need to add a special styling to the CSS file for the subtitle.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

77
Mazarin
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 18:27

  • Mazarin

  • Just can't stay away

  • Posts: 533

  • Since: 2008/12/10


Found a new minor bug. The delete icon and label for articles who are submitted but not yet published doesn't show. Here's the fix:

Line 128 reads:
</td><td align='center'><a href='" . XOOPS_URL . "/userinfo.php?uid=" . $autostory->uid() . "'>" . $autostory->uname() . "</a></td><td align='center' class='nw'>" . formatTimestamp($autostory->published(),$dateformat) . "</td><td align='center'>" . $expire . "</td><td align='center'><a href='".XOOPS_URL."/modules/news/submit.php?returnside=1&amp;op=edit&amp;storyid=" . $autostory->storyid() . "'><img src='" . $pathIcon16."/edit.png' title="._AM_EDIT."> </a> <a href='".XOOPS_URL."/modules/news/admin/index.php?op=delete&amp;storyid=" . $autostory->storyid() . "'><img src='" . $pathIcon16."/delete.png. ' '.  title='._AM_DELETE.'></a>";


It should be like this:
</td><td align='center'><a href='" . XOOPS_URL . "/userinfo.php?uid=" . $autostory->uid() . "'>" . $autostory->uname() . "</a></td><td align='center' class='nw'>" . formatTimestamp($autostory->published(),$dateformat) . "</td><td align='center'>" . $expire . "</td><td align='center'><a href='".XOOPS_URL."/modules/news/submit.php?returnside=1&amp;op=edit&amp;storyid=" . $autostory->storyid() . "'><img src='" . $pathIcon16."/edit.png' title="._AM_EDIT."> </a> <a href='".XOOPS_URL."/modules/news/admin/index.php?op=delete&amp;storyid=" . $autostory->storyid() . "'><img src='" . $pathIcon16."/delete.png' title='"._AM_DELETE."'></a>";



78
Mamba
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 19:37

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Quote:
Found a new minor bug.

Thanks! Fixed in SVN
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

79
Cesagonchu
Re: News 1.67 RC 1 ready for testing

Quote:
Why would the editor have any effect on the upload of a picture in a completely separate field?


I don't know. Did you try to upload a picture with the editor "DHTML Form with xCode", to see if you have the same bug?

80
Mazarin
Re: News 1.67 RC 1 ready for testing
  • 2012/6/18 21:28

  • Mazarin

  • Just can't stay away

  • Posts: 533

  • Since: 2008/12/10


Attaching pictures works just fine for me, regardless of editor.

Login

Who's Online

85 user(s) are online (48 user(s) are browsing Support Forums)


Members: 0


Guests: 85


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: May 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits