1
playsome
article and tags modules, thankyou trabis
  • 2010/8/10 0:44

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


Hello, everyone if you read the last couple of posts from this topic you will see that trabis has kindly offered to work on fixing the article 2.00rc (phppp) and tags module(alos phppp i think).

I know alot of people think article is a great module sadly development stopped and it had a lot of bugs and it most likely does not work well with latest xoops versions, hopefully trabis will fix this though. I will post a feature request, or actually some features which should be removed, if anyone would like to add what they would like fixed with the article module or tag module please do so. If anyone would like to help as well at different stages that would be great(templates, documentation, etc)

for reference here is the original article 2.00rc thread HERE

the following is what i think should be removed or kept.

Article module

1. remove the pingback/trackback feature, this makes it behave like a blog, xoops already has blog modules.
2. keep the diffrent display options blog, news, list always good to have diffrent display options.
3. 2.00rc had a file tab(perhpas for attached files) however it is "coming soon" perhaps this could be removed or a file attachment feature added to the add post page.
4. there was a bug which stopped you from deleting categories.
5. In xoops 2.4.4 only block templates seem to render page templates do not which renders the module completely useless, I will test this more and get more info on this error.
6. remove option to auto post to newbb

Thats all I can think of the moment, the actual user side I think is very good especially the likes of the articel image displaying next to the article title and intro text on the index, looks very proffesional.

If i could actualy get the module to work on my test install I could look at cleaning up templates but for some reason templates wont generate at all. Articles uses the Frameworks which is now in xoops core (it did not used to be so maybe there is some error with that framework being updated but the module has not been.)

Tag module

I cant see much technically wrong with the tag module so fixing any bugs that exist and taking it out of RC is good, perhaps some documentation so devs can incorporate tags into there modules.

The only thing I can see wrong with it is when you type a phrase as a tag(one with spaces) i.e New york City the module makes the three words seperate tags because space is a valid delimiter, maybe only make it so the commas are a valid delimitar.

Currently to add a tag with spaces you have to do it like New-york-City which does not look natural on the page.

Apart from that I dont know of any other issues, maybe just some redisign of templates or something.

Thankyou again trabis for taking up this challenge.

2
playsome
Re: article and tags modules, thankyou trabis
  • 2010/8/10 1:05

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


OK, a quick update on the templates not generating issue.

this sitested on local install xoops 2.4.4 using WAMP php 5.2.8 mysql 5.1.30

Here is whats happening:

the module installs fine, however page templates do not seem to generate (block templates do).

on attempting to generate the files form within templates admin i get the error - Selected file does not exist

When attempting to upload the files manually i get - Template file article_archive.html does not need to be installed (PHP files using this template file does not exist) this happens with all page template files.

I can confirm that the html templates do exist within modules/article/templates.

debug error on the article index.php side shows - Warning: Smarty error: unable to read resource: "db:article_index.html" in file /class/smarty/Smarty.class.php line 1093 li9ne 1093 just initiates the smarty error function so not much help there.

In artlcle/xoops_version.php template files are not listed in the normal way i have seen in other modules (block ones are though) the code is:

/** * Templates */ if ($isModuleAction) {     include_once dirname(__FILE__) . "/include/functions.render.php";     $modversion["templates"] = art_getTplPageList(""true); }


I have checked and the file functions.render.php does exist within the include directory.

Thats pretty much all i have.

3
Mamba
Re: article and tags modules, thankyou trabis
  • 2010/8/10 5:51

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
this sitested on local install xoops 2.4.4

Thanks for the testing! This is the kind of help that is very much appreciated!

If possible, please test on 2.4.5 as it is the current version.

Thanks again!
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs

4
playsome
Re: article and tags modules, thankyou trabis
  • 2010/8/10 17:06

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


OK, i have tested it on 2.4.5 production server and it is still the same result, page templates wont generate/render only block templates do.

I have looked through the some php files but saydly my php skills are limited to echoing hello world on to a page so i cant really tell what the code is doing.

on the code snippet i posted above it includes include/functions.render.php in functions.render php it includes inlcude/vars.php...in vars.php it includes Frameworks/art/functions.ini.php.

I am probably miles off but the only thing I can think of is some change to Frameworks files between xoops version 2.3.3 ( the last version i had this module fully working, bar the bugs) and 2.4.5.

As I dont understand most of the php code and I am not getting any other error messages I am afraid thats a ll I can do at this time.

Hopefully trabis will step in and sort this out.

5
playsome
Re: article and tags modules, thankyou trabis
  • 2010/8/10 18:25

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


Just an update, I have just tested article module on a local install of xoops 2.3.3 and all the template files generate/render as they should. So it would appear that it is some change between 2.3.3 and 2.4.4 that is cuasing the templates not to generate.

Outcome:article works on 2.3.3 and does not work on 2.4.4/5Resized Image

article templates on xoops 2.3.3 install

Resized Image

article templates on xoops 2.4.4 install

6
trabis
Re: article and tags modules, thankyou trabis
  • 2010/8/10 20:42

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


I cannot reproduce the templates bug. Check if your templates folder has read permissions. Please test it with default GUI.

7
playsome
Re: article and tags modules, thankyou trabis
  • 2010/8/10 21:15

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


Hi trabis, i have tested on my local install, templates direcotry was read only (doh im stupid) but the entire article directory was apparently read only aswell. i did also uninstall redmexico gui and rmcommon utitlities and the teplates now generate, however i do not know if it was the read only or the gui causing the issue.

I am uploading the article mod to my production site now which also has redmexico and rmcommon installed, i will check the permissions of the templates dir and if that is OK then it could be a safe bet its the gui or rmcommon utitlities. Ill let you know.

8
Mamba
Re: article and tags modules, thankyou trabis
  • 2010/8/10 21:19

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
I am uploading the article mod to my production site now which also has redmexico and rmcommon installed

Why would you install "Alpha" code on a production site?
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs

9
playsome
Re: article and tags modules, thankyou trabis
  • 2010/8/10 21:25

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


Hi trabis, i have tested on my production site, templates directory was at 755 i changed it to 777 and still the page templates would not generate only the block templates generate.

At this stage i would guess it could be the redmexico GUI or rmcommon casuing the issue? hopefully this is something that can be easily fixed. Do you think it could be fixed by removing that code snippet i posted above form xoops_version.php and listing the templates in the standard way? I can try that if you like to see if that would work.

Thanks

10
playsome
Re: article and tags modules, thankyou trabis
  • 2010/8/10 21:31

  • playsome

  • Not too shy to talk

  • Posts: 197

  • Since: 2009/4/15


Why would you install "Alpha" code on a production site?


Because the qpages module displayed content exactly the way i wnated without the hassle of modifying templates and code. I thouroughly tested it with various different modules before deciding to use it on the production site and i never encountered any issues until article.

As long as bitc3ro keeps updating it I am hoping there wont be any major issues. I can live without the article module for this particular project but I would still like to see it fixed to benefit the entire xoops community not just me.

Login

Who's Online

188 user(s) are online (134 user(s) are browsing Support Forums)


Members: 0


Guests: 188


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits