Classifieds 2.5 RC2

I just released version 2.5 RC2 of the Classifieds Module.

Changes.

No longer uses lightbox, I am using a jquery.colorbox plugin instead and I also am using bezoom for magnification.
With bezoom you place the mouse over the thumb image in the listing and to the right of it you will see a 300px box with a magnification of your image, which follows your mouse movement.
The magnification comes from the original sized picture that was uploaded. Then with colorbox when you click on the thumb, a larger photo will appear, just like lightbox did. With colorbox I have it set to use 50% of the width of the screen.

Fixed some errors if the admin modified a listing (br
was showing after modification) with default editor.



You can get it HERE.


Report problems HERE.


Thanks,

John

Classifieds 2.5 RC1


FOR XOOPS 2.3.3b and up

YOU MUST USE THE UPDATE SCRIPT- see readme file
YOU MUST CHANGE THE XOOPS FILE class/xoopsform/formselect.php
Xoops version 2.3.3b also MUST replace the file include/cp_header.php

I have supplied the files for your specific Xoops version.

The formselect file needs to be changed because it does not validate the select box in a form properly, the file I provide does, and it is very important that it works for this module.( The only change is in the function renderValidationJS)

The cp_header.php file needs to be changed because it calls mainfile.php different than the newer versions of Xoops. but this module needs it to be like the newer versions. (The only change is the line that calls mainfile.php)


Tested on Xoops Versions 2.3.3b - 2.4.4 - 2.5.0 alpha2
Tested on servers with the following specs:

PHP - 5.2.9
MYSQL - 5.0.89-community
Server API Version - cgi-fcgi


AND

PHP - 5.3.1
MYSQL - 5.1.42
Server API Version - apache2handler - 2.2.14



Everything I tested works fine with this server, I may have missed something.

1. Now works with Xoops version 2.3.3b and up (some files need to be changed).
2. I fixed a lot of errors from classifieds 2.4
3. Added States or Regions in the admin.
4. Added search by state or region, category and price.
5. Admin can now add a listing in the admin section.

6. Now works with Xoops 2.3.3b
7. changed modify.php and it now uses a template
8. Sort Order in Categories Not Working - fixed
9. View Ad May Give Blank Screen - fixed
10. Photo Location for Print View - fixed
11. Add Photos Link in Item View - remove$mydirname from link
12. Admin Edit Drop-Downs/Information Consistency - fixed
13. Add Photos Doesn't Lightbox - didn't think the submitter needed this, but fixed anyway
14. fixed last X items doesn't show at all if use_extra_code turned off
15. Latest Listings with Photos Block Loses Images - fixed


READ THE README FILE

You can get it in the download section of this site.

It is a RC version because there is a lot of code change from the last version.
On my 2 servers everything works real good.

You can get it HERE

Report problems HERE

Thanks to mboyden for his review of Classifieds 2.4

Thanks,

John

Peekay,

How are you.

I have not had the problem for dhtml text area, just the select boxes in my modules.

But if commenting them out works, then that means it is done somewhere else, probably formelement.php. No need to do it twice, is there?

But we do need an official fix, either by removing it from some files or fixing it like I did for formselect.php.

Thanks,

John

If you have a form with a select box and you set it to true for validation it does not work. I found this with all Xoops versions. My modules need it to work right so here is what I found.

It is in the function renderValidationJS

here is the function from version 2.4.4


function renderValidationJS()
{
// render custom validation code if any
if (! empty($this->customValidationCode)) {
return implode("\n", $this->customValidationCode);
// generate validation code if required
} elseif ($this->isRequired()) {
$eltname = $this->getName();
$eltcaption = $this->getCaption();
$eltmsg = empty($eltcaption) ? sprintf(_FORM_ENTER, $eltname) : sprintf(_FORM_ENTER, $eltcaption);
$eltmsg = str_replace('"', '"', stripslashes($eltmsg));
return "\nvar hasSelected = false; var selectBox = myform.{$eltname};" . "for (i = 0; i < selectBox.options.length; i++ ) { if (selectBox.options[i].selected == true) { hasSelected = true; break; } }" . "if (!hasSelected) { window.alert("{$eltmsg}"); selectBox.focus(); return false; }";
}
return '';
}



I changed it to:


function renderValidationJS()
{
// render custom validation code if any
if (! empty($this->customValidationCode)) {
return implode("\n", $this->customValidationCode);
// generate validation code if required
} elseif ($this->isRequired()) {
$eltname = $this->getName();
$eltcaption = $this->getCaption();
$eltmsg = empty($eltcaption) ? sprintf(_FORM_ENTER, $eltname) : sprintf(_FORM_ENTER, $eltcaption);
$eltmsg = str_replace('"', '"', stripslashes($eltmsg));
return "\nvar hasSelected = false; var selectBox = myform.{$eltname};" . "for (i = 0; i < selectBox.options.length; i++ ) { if (selectBox.value != "") { hasSelected = true; break; } }" . "if (!hasSelected) { window.alert("{$eltmsg}"); selectBox.focus(); return false; }";
}
return '';
}


Now it will work correctly.

I have included this file (for each Xoops Version) with the changes, in my Jobs and Classified modules.

Maybe this is not the best way to change this, but it works.

Thanks,

John

mboyden,

First I want to Thank You for taking the time to do this. It is Exactly what I needed, I just wish you did it on a 2.4.4 setup. But I went through it and this is my findings using a 2.4.4 setup.

What are the PHP, MySQL for the server that you used?

If anyone has any of these issues using a 2.4.4 setup please let me know.




1.Search Form Always Shows - I can not reproduce this error. It works fine on my servers.

2. Sort Order in Categories Not Working - Fixed Thanks for pointing that out.

3. View Ad Gives Blank Screen - You wrote:

Why this change works, I don't know because reviewing the code I have and know, I would think it should work as is. Not sure if this is a 2.3.x vs. 2.4.x change or not.

I have found a lot of little things that should work but don't in 2.4.4


4. Photo Location for Print View - I can not reproduce this on my servers

5. WYSIWYG Incompatibility - I think there are many errors in the Xoops editors in 2.4.4
The suggestions you have do not work with the 'dhtmltextarea' editor in 2.4.4
If I do this:

$desctext = $myts->displayTarea($desctext,1,1,1,0,0);

on the viewad.php page everything comes back in one line(this whole post would be on one line)

So I changed it to:

$desctext = $myts->displayTarea($desctext,1,1,1,1,1);

which I thought was basically the same as

$desctext = $myts->displayTarea($desctext,1,1,1);

and it works for dhtmltextarea

It was real tough getting the editor to not show br tags and other things throughout all pages
I should not have had the problems, thats why I say there are some issues with the editors.



6. Add Listing with FCKeditor Causes Validation Error
7. Add Listing with FCKeditor Description Has No Caption

Xoops 2.4.4 does not come with FCKeditor it is called CKeditor and the description caption is there, I also took the FCKeditor from the 2.3.3b release and it showed the caption too. But it looked very bad. but still it worked.


8. Add Photos Link in Item View - I don't consider that hard coded, it does have $mydirname, but that still is not hardcoded.
But I did change it by removing $mydirname.


9. Prototype jQuery Conflict - I will not be using j-script, but I will look at this issue.


10. Admin Edit Drop-Downs/Information Consistency - This is now fixed for the next version


11. Add Photos Doesn't Lightbox - I didn't think the submitter needed this. Other users never see this page.


12. Other Template Issues - You wrote, if the advertisement code is turned off, then the last X items doesn't show at all.
I can not reproduce this either.


13. Links Relative - Will look into this and make changes



14. Latest Listings with Photos Block Loses Images - I can't reproduce this either.


15. Blank Screen in Contact Seller for Anonymous Users - I don't see this, where do you see a link for anonymous users to use the contact form? I did see that an anonymous user could access the form directly and I have changed that for the next release. ANONYMOUS USERS are not allowed to use this form.


16. Reply Page Anonymous Submitter Links - I don't see this one either. Anonymous has no access to this page.


There seem to me more reasons I did make this ONLY for Xoops 2.4.4, not just the Captcha. A lot of stupid little things that used to work no longer did with 2.4.4.
One example, I should not have had to use 'if xoopseditor = dhtmltextarea else'

Thanks again to mboyden for his review, I really appreciate it.

Again, if any users have any of these errors with Xoops version 2.4.4 Please let me know.

Thanks,

John

I will answer these tonight when I have more time.

As far as your registration on my site, Are you using the right user name?
On this site you are bumpeboy, but on my site the name is bumbeboy. Just wondering if you made a typo.

Thanks for the donation.

John

If you go to jobs/admin/index.php around line 387 and find the function:

function IndexResumeView

In that function around line 395 find this:

$result = $xoopsDB->query("select lid, cid, title, status, exp, expire, private, tel, salary, typeprice, date, email, submitter, usid, town, state, valid, premium, resume from ".$xoopsDB->prefix("jobs_resume")." WHERE valid='No' AND lid='$lid'");

Remove the 'premium,'

Also around line 401 find this line:

list($lid, $cid, $title, $status, $exp, $expire, $private, $tel, $salary, $typeprice, $date, $email, $submitter, $usid, $town, $state, $valid, $premium, $resume) = $xoopsDB->fetchRow($result);

also remove '$premium,'

Then around line 415 find this line:

$premium = $myts->htmlSpecialChars($premium);

comment it out like this:

//$premium = $myts->htmlSpecialChars($premium);

or delete it.

That should fix it. I will change the download tonight.


Thanks,

John

Due to a problem with the theme on this site and my computer I will probably not be answering questions on this site. If you need my help you will probably need to come to my site.

I need to approve your registration so it could take a day.

As soon as I can access this site easily I will use this site again.


I did not make a news story about this yet because I will be releasing a new version 2.2 this week, it will allow you to use a banner or adsense code between listings. I will make the news after that.


Thank You,

John

Due to a problem with the theme on this site and my computer I will probably not be answering questions on this site. If you need my help you will probably need to come to my site.

I need to approve your registration so it could take a day.

As soon as I can access this site easily I will use this site again.

Thank You,

John

The problem was almost fixed for me, but now it is back to the way it was, no good.

@ red_Slider
I am using the newest version for my distribution of linux. I tried upgrading to 2.0.3 but had more problems than it was worth, so I went back to 1.1.18

I will check back here every once and a while to see if the theme is fixed.

Thanks,

John