Hi

Oh my god. So much discussion that I forgot my most important question: ;)

If there is a smarty compiler plugin integration, why the hell did the smarty developers not use it??? Is there any reason for not using compilation for a one-line-code? Okay, a complex validator function should not be compiled inline, but compilation for 1:1 php/smarty functions would have made sense.

greetings
birdseed

Hello

First of all, thanks for your long and detailed replies. It must be one the strange rules of online forums that we discuss now about one small "by-the-way" sentence, but I´m familiar with that from my own portal ;)


I know about the difference between echoing html an using templates. I have developed two modules for xoops, one of them quite complex, so I am familiar with the XOOPS concepts and the core.

If you use the xoopsObject as a database abstraction layer, why was it implemented in xoops1, but will not really be used before xoosphere? without all that initvar/getVar/setVar stuff, things could be so easy for me. Even in xoops2, i see:

echo "<TD>" . $myvar . "</TD>"; (...)

On the other hand, I see many abstraction layers. So this doesn´t fit together for me. Why write an database abstraction for the 5% (guessed?) postgre Users (does postgre work with xoops? never tried...) instead of concentrating on mysql.

The XOOPS core is not clean. Everyone knows it. It is easy to find duplicate code. It is easy to find sql statements in the core where there should be criteria objects and criteriaobjects where there should be sql statements. it is easy to find notice errors and warnings.

Please don´t misunderstand me. I like xoops, i like the XOOPS community. But I´m a bit afraid that in the whole "abstraction layer movement", the small and dirty work - preserving a clean and consistent, fast and error free core - which means optimizing at a low level - is pushed aside.

I´m using XOOPS because I have a - compared to big web companies - a small site. The size and user traffic is comparable to www.xoops.org. If my site was bigger, I wouldn´t use xoops, i wouldn´t use php. Instead, I would use a compiled language like java or .NET, i would not be using MySQL but MSSQL Server, Ingres or even oracle. I would be using a cms without any predefined layout. So I wonder if the road(map) that you decided to go is the right one. I´d rather see a xoops2.6 ;)

greetings
birdseedmusic

Hi

Your arguments are good. Nevertheless, i have to realize that performance in XOOPS is a topic which is generally answered with "turn on smarty caching" ;)

As I am requesting to join the core developer team, it might be MY job to optimize that.

greetings
birdseedmusic

Hi

anyone can answer my smarty question?






about the criteriacompo:

The CriteriaCompo is a nice thing in order to reduce complexity of SQL Statements, BUT...

There is always a tradeoff between well-structured code and performance. mainfile.php is included in EVERY XOOPS page, so it SHOULD be optimized for speed. this means: simple sql statements. with the new profile, we have a additional join between two tables. we have a complex CriteriaCompo rendering. We have a smarty plugin system which loads plugin files at runtime instead of compiling them. we have a security abstraction class instanciated which does in 99.9% the same as in xoops1, a non-LDAP login.

newbb...when editing or writing a post, i don´t care about the performance. But when READING a post (90% of all access are read access), i would expect that there is a "precompiled" Version of a post where all the text sanitizers, smilie replacement loops and so on are already edited.

I did a newbb hack for xoops1 where all that is done to display a (precalculated) newbb posting is fetching a MySQL text field and putting it out with echo. with the xoops2 update, i have to do this again because noone cared about such things.

Yes, i am talking about milliseconds. Those milliseconds become hours if multiplied by many request per day.

I am in the unhappy position to have high traffic site running with xoops, so I have to care for myself about optimizing the core.

greetings
birdseedmusic

Hi

Xoops and scalability IS a problem in my opinion. When I have a look at the xoops2 core, i don´t know if i should cry or be happy. The functionality is good, the core is well structured, but I would wish that more developers would take time to use a zend debugger and take the one or two hours which it takes to step through the code.

There are so many features where the OOP Concept was pushed without caring for performance. The XoopsObject, The Criteria/CriteriaCompo.

The smarty core is a hell of function calls simply to load a template, which could be a simple file include plus some checks and assignments.

We have many XOOPS modules. I like xoops, but I´m not happy what some of the developers made of it. :(

greetings
MK

Hi

I remarked that using a smarty plugin generates much overhead - even if compiled!

Take a look at the simple smarty "regex_replace" function (which is nothing more than a simple preg_replace() php function)

smarty_core_load_plugins(array('plugins' => array(array('modifier', 'regex_replace', 'db:system_phpdebug.html', 38, false),)), $this); ?>

This starts a whole bunch of function calls!

Okay, what is the result of all?

function smarty_modifier_regex_replace($string, $search, $replace)
{
return preg_replace($search, $replace, $string);
}



So how can i make this more effective? I want to compile the function inline without the hole plugin-loader thing which seems oversized to me (a bit like the CriteriaCompo and the XoopsObject, but that´s another story ;))

greetings
birdseedmusic

Hi

As I am not happy about having to explain to my 15.000 User the difference between a username an a displayname, I will also have to do some ugly core hacks to deactivate this. So i would be VERY happy if this is made optional. And yes, i am willing to take the risk of a "not higher than before" security. ;)

greetings MK

Hi

Maybe I am too stupid but i wasn´t able to understand the profiles module. Perhaps the reason is that there is not enough content. fvxccc is NOT a sensible name for a profile ;)

The source forhttp://webmusic.homerecording.de module is available. But i want to know to WHOM i give it. Please contact me at michael@homerecording.de for details. I´m not here very often.

The songvoting module athttp://homerecording.de/modules/songvoting is a nice peace of software written for our site, but the source code style is... okay I´m glad we have that module. Better don´t look inside ;)

i´m looking forward to seeing a jukebox demo!

greetings
Michael Kißling
homerecording.de

Hi guys,

I have developed a xoops2 Module at

http://webmusic.homerecording.de/ (only german, sorry...)

It is not an artist presentation site, but rather a collaboration system, allowing users to make music together via Internet. You can found a new project, users can apply to it.
The core of the module is a shared folder with subfolders, accessible via a web filemanager or a Java Tool, allowing upload and synchronisation of whole directories.

(At the moment, it´s working fine, but not successful, because the will for long-term collaboration via Internet is quite weak or people prefer the old e-mail way... :( )

Anyway, I´m very interested in the results, because I would like to use your system to present the (few) projects who get finished at webmusic.

Keep up the work!


greetings
Michael Kißling