XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. 2.5.x Support 
  4.  / Bug in formselectuser.php in 2.5.7.1
Register
1
goffy
Bug in formselectuser.php in 2.5.7.1

  • 2015/7/20 4:39

  • goffy

  • Just can't stay away

  • Posts: 543

  • Since: 2010/12/27


I found a bug in formselectuser.php

line 76:
$value = is_array($value) ? $value : (empty($value) ? array() : array($value));

This creates always an array, also if you give one single specific user id, which should be preselected in a list of all users

the line 77
if (count($value) > 0) {
creates then a dropdown with only the one, which should be preselected

the line 77 must be changed to
if (count($value) > 1) {
2
goffy
Re: Bug in formselectuser.php in 2.5.7.1

  • 2016/1/4 11:34

  • goffy

  • Just can't stay away

  • Posts: 543

  • Since: 2010/12/27


This bug is still existing in xoops 2.5.7.2

Is Xoops 2.5.7 on github? It didn't find it
3
Mamba
Re: Bug in formselectuser.php in 2.5.7.1

  • 2016/1/4 17:28

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


On GitHub, I am working on the "un-official" 2.5.8 beta version, so feel free to fork it, test it, and submit fixes and improvements.

The focus is more on code clean-up and PSR-2 compliance, and not on any new development.

Please note: this might be broken from time to time, so be careful, but if you see anything, please let me know...

FYI - it has the latest security patches, and I am also trying to keep the latest versions of Bootstrap, etc. so we can test it there...
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs
4
geekwright
Re: Bug in formselectuser.php in 2.5.7.1

Sorry, never saw this one.

Actually, the problem seems to be that it should always merge the selected user (or users) with the larger result set produced and cached. Seems to have been introduced with changes related to reducing some system crippling behaviors when the user table is large.

Again, sorry. I'll get an official fix in the works.

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

377 user(s) are online (245 user(s) are browsing Support Forums)

Members: 0

Guests: 377

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits