XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. XOOPS general usage questions 
  4.  / Cannot edit banner client details?
Register
1
Peekay
Cannot edit banner client details?

  • 2005/8/9 11:07

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Xoops 2.0.10. I need to alter the contact details for a banner client and cannot save the changes.

Anyone have a fix for this?
A thread is for life. Not just for Christmas.
2
Peekay
Re: Cannot edit banner client details?

  • 2005/8/11 8:57

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Can one of the core devs take a peek at this for me? Everything else seems to work.
A thread is for life. Not just for Christmas.
3
Mithrandir
Re: Cannot edit banner client details?

PHP debug, MySQL debug? Any errors?
"When you can flatten entire cities at a whim, a tendency towards quiet reflection and seeing-things-from-the-other-fellow's-point-of-view is seldom necessary."

Cusix Software
4
Peekay
Re: Cannot edit banner client details?

  • 2005/8/11 10:52

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Hi Mithrandir.

No error messages without debug. I had to use a screen-cap utility to get the debug errors, they refreshed too quickly. On clicking 'Change Client' button:

PHP Debug

Warning [PHP]: sprintf(): Too few arguments in:
C:\Inetpub\wwwroot\xoops\modules\system\
admin\banners\main.php line 190

MySQL Debug

SELECT * from hss_config WHERE (conf_modid = 0 AND conf_catid = 1) ORDER BY conf_order ASC

SELECT sess_data FROM hss_session WHERE sess_id = 'eb477de********************'

SELECT * FROM hss_users WHERE uid = 1

SELECT * FROM hss_modules WHERE dirname = 'system'

Error number: 1065
Error message: Query was empty
A thread is for life. Not just for Christmas.
5
Peekay
Re: Cannot edit banner client details?

  • 2005/8/16 11:17

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Tiny Bump? Would even be useful if someone can say what the error means and point me towards the files to check.
A thread is for life. Not just for Christmas.
6
Peekay
Re: Cannot edit banner client details?

  • 2005/8/18 19:51

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Bump. I'll try and fix if I can have a clue where to start. I assume this doesn't work in 2.2 either?
A thread is for life. Not just for Christmas.
7
Mithrandir
Re: Cannot edit banner client details?

Amazing.

This bug must have been there for AGES.

modules/system/admin/banners/main.php, line 190:
//Wrong
[d]$sql = sprintf("UPDATE %s SET name = %s, contact = %s, email = %s, login = %s, passwd = %s, extrainfo = %s WHERE cid = %d", $db->prefix("bannerclient"), $db->quoteString($myts->stripSlashesGPC($name)), $db->quoteString($myts->stripSlashesGPC($contact)), $db->quoteString($myts->stripSlashesGPC($email)), $db->quoteString($myts->stripSlashesGPC($login)), $db->quoteString($myts->stripSlashesGPC($passwd)), $db->quoteString($myts->stripSlashesGPC($extrainfo)));[/d]
//Right - add , $cid to the sprintf call
$sql = sprintf("UPDATE %s SET name = %s, contact = %s, email = %s, login = %s, passwd = %s, extrainfo = %s WHERE cid = %d", $db->prefix("bannerclient"), $db->quoteString($myts->stripSlashesGPC($name)), $db->quoteString($myts->stripSlashesGPC($contact)), $db->quoteString($myts->stripSlashesGPC($email)), $db->quoteString($myts->stripSlashesGPC($login)), $db->quoteString($myts->stripSlashesGPC($passwd)), $db->quoteString($myts->stripSlashesGPC($extrainfo)), $cid);
"When you can flatten entire cities at a whim, a tendency towards quiet reflection and seeing-things-from-the-other-fellow's-point-of-view is seldom necessary."

Cusix Software
8
Peekay
Re: Cannot edit banner client details?

  • 2005/8/18 22:24

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Who says you can't teach an old bug new tricks! Many thx Mithrandir.
A thread is for life. Not just for Christmas.

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

331 user(s) are online (262 user(s) are browsing Support Forums)

Members: 0

Guests: 331

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits