| Re: Cannot enter in PUBLISHER module administration ... but "sometimes" ... |
| by Lupin on 2020/1/30 19:41:39 Of course , no more service interruptions ! TY Pino |
| Re: Cannot enter in PUBLISHER module administration ... but "sometimes" ... |
| by Lupin on 2020/1/24 19:44:56 TYVM Mamba , I will report. Pino |
| Re: Cannot enter in PUBLISHER module administration ... but "sometimes" ... |
| by Mamba on 2020/1/23 23:25:56 Just comment out lines 92-95 in /admin/index.php: le="color: #000000"><?php //$newRelease = $utility::checkVerModule($helper); //if (!empty($newRelease)) { //$adminObject->addItemButton($newRelease[0], $newRelease[1], 'download', 'style="color : Red"'); //}
|
| Re: Cannot enter in PUBLISHER module administration ... but "sometimes" ... |
| by Lupin on 2020/1/23 16:50:26 Is anyone working on this problem? Since yesterday none of the administrators has managed to enter the administration panel of the module !!! Since we would soon need to go into production, is it possible to have a version without this "automatic data collector"? Thanks Pino |
| Re: Cannot enter in PUBLISHER module administration ... but "sometimes" ... |
| by geekwright on 2020/1/17 21:49:57 I had not realized the new module code was doing this. Cool feature. I've got a few thoughts. Looks like we should be checking the CURLINFO_RESPONSE_CODE with curl_getinfo() to make sure the return is a 200. A lot of other codes can be returned with a valid json body that are totally different than the releases body. An example is the 403 response code for a rate limit exceded error - https://developer.github.com/v3/#rate-limiting We might also consider a more precise end point, like this: https://api.github.com/repos/XoopsModules25x/publisher/releases/latest To be good github citizens, we should cache the results for some period of time so we don't generate hundreds of checks while doing publisher setup activities. The period could easily be an hour or more. Xmf\Module\Helper\Cache::cacheRead() could make that easy. One last observation not directly related to this issue, since publisher can be cloned, it looks like this check will not get any data, or wrong data from another module. |