| Re: Bug recurring |
| by timgno on 2013/6/7 9:25:35 To work around this problem, volten added to the file admin/permissions.php, in the news module, the general permissions.php, so the offset will always be set to at least one. And if I did not want to force the general permissions in my module? |
| Re: Bug recurring |
| by zyspec on 2013/6/7 2:20:28 @irmtfan, In general terms I agree with you but in this instance the fix for the array_keys issue is solved by initializing a variable, which is good to do anyway. The remaining issues can be reviewed by the core dev's to see if there's an acceptable solution to help with the foreach() warnings. If so, great! If not, then the warning should suffice. |
| Re: Bug recurring |
| by irmtfan on 2013/6/7 2:10:39 IMO it is not a bug but an inappropriate usage of core functions in a module. while you received php errors and warning you should solve it yourself. Core cannot check everything otherwise codes will be huge. IMO a program should just have facilities to show errors and warnings in every bad usage. eg: i will receive errors when i use this code: le="color: #000000"><?php if(empty($myClass->myMethod())) Fatal error: Can't use method return value in write context in ... So i have to change my codes and i cannot send bug to php.net  @zyspec: Your improve is nice. IMO We should have it in the 2.5.7 But still i think it is just an improvement. we cannot call it a bug and a fix is not needed |
| Re: Bug recurring |
| by timgno on 2013/6/5 15:43:16 It came out of this was there too, zyspec you're right that, I should report it in svn now  I will, because we can not change the codes in all modules as he did in his trabis. |
| Re: Bug recurring |
| by zyspec on 2013/6/5 13:50:19 @timgno, My question is why does the TDMCreate code call render when there are no permission items to render? Seems to me the code should check to see if there's anything to render before it tries. The problem with array_keys on line 129 can be solved by initializing '_itemTree'. For now you should be able to get rid of this error by changing ./class/groupperrmform.php line 44 in XOOPS 2.5.5 or XOOPS 2.5.6 to: le="color: #000000"><?php var $_itemTree = array(); This should also make all of the foreach() warnings on line 129 disappear but there will need to be additional changes needed in the core to get rid of the rest of the issues. I'd recommend you submit this to the SVN bug tracker and have one of the core developers look at this for a future release. |
Search
Recent Posts
Who's Online
Donat-O-Meter
| Stats | |
| Goal: | $15.00 |
| Due Date: | Jul 31 |
| Gross Amount: | $0.00 |
| Net Balance: | $0.00 |
| Left to go: | $15.00 |
|
|