Subject:*
<
Name/Email:*
<
Message Icon:*
<
Select*
<
Message:*
<



Click the Preview to see the content in action.
Options:*
<
Confirmation Code*
<
6 - 2 = ?  
Input the result from the expression
Maximum attempts you can try: 10
*
<
     

Re: d3downloads 1.47 and xoops 2.4.1
by ghia on 2010/8/18 10:35:13

First of all, it is a somehow a bug in the module, because in the plugin class xoopsformelement is tested, while the XoopsFormDhtmlTextArea class is used.
The included xoopsformloader.php includes all xoopsformxxxx classes, including the two before mentioned.

So, the author of the module assumed that these classes will be always loaded togheter and not individually. I don't know if that was a rightful assumption and that it was upholded always in previous versions of the XOOPS core. (Probably yes, because nobody complained before)
But fixing the modules Smarty plugin, will always work in every XOOPS version.

Technically, for PHP there is no reason, why all these classes should be included at once and you can use most individually or with only a few others having some benefit in time and memory.

Question is now if there was some API rule that the form elements needed to be included always togheter and not to be loaded individually. If so, this could be considered as a compatibility bug.

Note that, if the classes are not loaded by the core, you could run into the same problem, when you have another module that does also only the include of some individual formelements.
Re: d3downloads 1.47 and xoops 2.4.1
by voltan on 2010/8/18 4:48:28

Please fix it !
Re: d3downloads 1.47 and xoops 2.4.1
by ghia on 2009/12/19 1:34:26

Quote:
Should be fixed with this.
Sorry, that was a wrong assumption.
Quote:
can you fix it in XOOPS 2.4.3?

The only way to let it work is to correct the smarty plugin code by replacing the code from the first post by the one Trabis provided.
Re: d3downloads 1.47 and xoops 2.4.1
by voltan on 2009/12/18 18:42:16

I'm not sure , but I think some times it work and some times it did,t work !!! ( or some times 'xoopsformelement loaded and some times not loaded )
for example some minutes ago I checked it ( whit pico ) and it work whit out problem ! but at morning I installed pico on a website and pico did't work and I was forced to change (( xoopsformelement )) whit (( XoopsFormDhtmlTextArea )) !!!!!!!!!??????????
Re: d3downloads 1.47 and xoops 2.4.1
by ghia on 2009/12/18 10:02:56

Should be fixed with this.

Who's Online

823 user(s) are online (763 user(s) are browsing Support Forums)


Members: 0


Guests: 823


more...

Donat-O-Meter

Stats
Goal: $15.00
Due Date: Jul 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $15.00
Make donations with PayPal!

Latest GitHub Commits