| Re: article and tags modules, thankyou trabis |
| by playsome on 2010/8/14 12:59:16 Hello, another small fix for article module or rather the tag module but it involves editing a file in article. The problem was when clicking an item in the tag module the URL would display as article/view.article.php?article=5 however in the article module when clicking an item link the URL would be article/view.article.php?5 notice in tag module it has extra article=, this could possibly mean duplicate content. To fix it edit modules/article/include/plugin.tag.php line 73 and simply delete the article= so it looks liek this le="color: #000000"><?php "link" => "view.article.php" . URL_DELIMITER . "{$item_id}", you can also remove article= from modules/tag/plugin/article.php line 63. Hope this helps |
| Re: article and tags modules, thankyou trabis |
| by playsome on 2010/8/12 19:08:30 Hello, I think i have fixed another small bug with article. When selecting the 'blog' template the index page of article did not seem to show the xoops site name or module name in the header, I have replaced the following code in index.blog.php around line 190 le="color: #000000"><?php $xoopsTpl -> assign("xoops_module_header", $xoopsOption["xoops_module_header"]); $xoopsTpl -> assign("xoops_pagetitle", $xoopsOption["xoops_pagetitle"]); with le="color: #000000"><?php $xoopsTpl->assign('xoops_pagetitle', $page['title'].$xoopsModule->getVar('name')); I dont know if this is the 100% correct way to assign the pagetitle but it seems to work. |
| Re: article and tags modules, thankyou trabis |
| by playsome on 2010/8/12 17:23:03 trabis, you are a genuis.  Before I added your line of code I had found another issue, although my code made the templates install and generate, the option in article preferences to use a particular themeset(none or sitewide) and the option to choose the layout template set (blog, news, list) was not available but now, thanks to your superb help it is there. Article is now working with rmcommon installed. Thankyou trabis, you are a legend. |
| Re: article and tags modules, thankyou trabis |
| by trabis on 2010/8/11 23:07:22 Regarding templates issue in rmcommon article/xoops_version.php uses this line to check if module is being updated or installed: le="color: #000000"><?php $isModuleAction = ( !empty($_POST["fct"]) && "modulesadmin" == $_POST["fct"] ) ? true : false; This will allways return false when using rmcommon. You need to add support for rmcommon install update by adding an extra line: le="color: #000000"><?php $isModuleAction = ( !empty($_POST["fct"]) && "modulesadmin" == $_POST["fct"] ) ? true : false; $isModuleAction = ( !empty($_POST["module"]) ) ? true : $isModuleAction; |
| Re: article and tags modules, thankyou trabis |
| by playsome on 2010/8/11 22:15:52 Hi trabis, the changes I have made where not meant to be a final version, sorry for any confusion. I just wanted to share what I had done so far in the hope that someone could improve upon it. I have really only made html and css changes to templates which are probably not even that great. I am hoping and praying that you will fix the bugs, thats all I ask so at least it will work properly and be out of RC, then hopefully another developer could work on features and things or even myself if I learn alot. Thanks |
Search
Recent Posts
Who's Online
Donat-O-Meter
| Stats | |
| Goal: | $15.00 |
| Due Date: | Jul 31 |
| Gross Amount: | $0.00 |
| Net Balance: | $0.00 |
| Left to go: | $15.00 |
|
|