Subject:*
<
Name/Email:*
<
Message Icon:*
<
Select*
<
Message:*
<



Click the Preview to see the content in action.
Options:*
<
Confirmation Code*
<
1 + 3 = ?  
Input the result from the expression
Maximum attempts you can try: 10
*
<
   

Re: Why one user can edit another user's profile?
by mboyden on 2009/12/11 13:47:44

No worries. Yeah, I told trabis I'd work on the Profile module and so he set it up that Profile module bugs would be assigned to me, so that's why I got it. I just wanted clarification before I worked on what you suggested.
Re: Why one user can edit another user's profile?
by ghia on 2009/12/11 0:53:42

And then also in the other files mentioned by mboyden?
Re: Why one user can edit another user's profile?
by trabis on 2009/12/11 0:16:22

There is a way for disabling cache and it is used on profile userinfo page. We need to add this into edituser:

le="color: #000000"><?php //disable cache $GLOBALS['xoopsConfig']['module_cache'][$GLOBALS['xoopsModule']->getVar('mid')] = 0;
Re: Why one user can edit another user's profile?
by ghia on 2009/12/10 23:59:14

(In one or other way beyond my intention, your name was assigned to this bug report. I have corrected that.)

For me, it does not matter if the profile module is cachable or not. It should be simply not be possible to run into this kind of problems. If it has to be done by disabling the cache for the profile module altogether, so be it. And by disabling I mean, that the webmasrter is not able to put it on.
I assume most of the operations are very simple and not often reused, so, caching will not add much benefit.
Re: Why one user can edit another user's profile?
by mboyden on 2009/12/10 14:36:07

I've run into this cache issue in many places. For instance, the User Menu block does a similar thing with the Admin Link if the cache is turned on (showing the admin link to users that don't have admin permissions).

Why turn on caching for the profile module in the first place?

The module caching is a blunt force instrument in general, and module wide, for all the pages and items in the module.

While the bug entry on this requests that we disable caching for the edit profile page, the problem would still exist for the userinfo page, too, and if the visibility permissions are set differently, then that would also similarly present a problem. Same for the search page and such.

So, I ask, is it useful to spend time on fixing this issue when likely one should never turn on caching for the profile module at all?

Who's Online

756 user(s) are online (711 user(s) are browsing Support Forums)


Members: 0


Guests: 756


more...

Donat-O-Meter

Stats
Goal: $15.00
Due Date: Jul 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $15.00
Make donations with PayPal!

Latest GitHub Commits