Subject:*
<
Name/Email:*
<
Message Icon:*
<
Select*
<
Message:*
<



Click the Preview to see the content in action.
Options:*
<
Confirmation Code*
<
1 + 1 = ?  
Input the result from the expression
Maximum attempts you can try: 10
*
<
     

Re: Notification not working
by wishcraft on 2009/6/5 9:10:35

Ok david's problem with newbbex, with the mode being set on xoops_version.php to Notifcation Send then Delete.

This was disable the quickest way possible.

Thanks.
Re: Notification not working
by ghia on 2009/1/17 18:42:50

Quote:
Where I did not had help: in Xoopsmailer.
Because each template is opened with something like this :
le="color: #000000"><?php @fread(...)

So even with Php debug's mode activated, you can't detect that the mailer can't read the template file...
This use of @ for the suppression of error messages in PHP is some kind of lazy programming. The program stays running, but the failed action is not executed and may impair subsequent processing.
Better is to check before trying to open a file or to read from it, that the file exists etc. It costs more code to prepair for some actions, but if it fails, users can be indicated about what and where is the problem.
Ideal the @ should not be used in XOOPS.
I believe the same problem exists in the code for the installation of modules. Nothing is showed and nobody has a clue why.
PHP5 can give easier and better error handling with the throw exception handling and try - catch blocks.
Re: Notification not working
by Mamba on 2009/1/17 2:29:02

Yes, Hervé is D'Man!!! One of the best XOOPS developers, and his modules speak volumes about it!!!

Thanks Hervé for making another XOOPS user a happy one!
Re: Notification not working
by davidsless on 2009/1/17 0:32:55

Many many thanks to Hervé who solved this problem. He put in many hours to fix this over and above. It's a measure of his dedication to and knowledge of XOOPS that he eventually tracked it down. A first class bit of work.

I am, of course, the cause of the problem in the first place. I created the CRI language folder so that we at CRI could customise the English on our site—communication.org.au— for our specific needs and users. In doing so we did not realise the programming implications of what we were doing.

For me this raises two important issues for the XOOPS community.

1. Already raised by Hervé, is the fact that the fault was not showing up in the debug mode. I don't know enough about programming to suggest a fix, but it should be possible to do so and should be added into the debug mode.

2. XOOPS is built to be customised: templates, themes, and languages are all modifiable. It's one of the things that makes XOOPS such a good platform. But it is not clear, as in this case, to a non-programmer, or someone unfamiliar with the overall architecture and dependencies of code are, where the limits of that customisation are, when a change is likely to have implications beyond the specific file one is working on. It might be helpful to all users if there were notes in folders and files signalling those limits.

I don't know how practical that is, but it might help people like me, who want to use XOOPS to the full, but would rather not create hidden nightmares for brave and highly competent people like Hervé to sort out.

This is just a suggestion. In the meantime hurray for for Hervé!
Re: Notification not working
by hervet on 2009/1/14 13:26:13

Problem definitively solved.

In this folder:
/xoops/language
tehre was a sub folder called "cri".

Then, in the genral preferences, in the "Default language" select box, there was : "cri" selected.
Instead of “english”

As a consequence, XOOPS was trying to find, for each module, the notifications templates in this kind of folder:
/xoops/modules/mymodule/language/CRI/mail_template/notification_email.tpl

Instead of:
/Xoops/modules/mymodule/language/english/mail_template/notification_email.tpl

Of course, the mails templates of each module could not be found !

Hope this will help someone help because I spent a incredible amount of hours on this problem !

Where I did not had help: in Xoopsmailer.
Because each template is opened with something like this :
le="color: #000000"><?php @fread(...)

So even with Php debug's mode activated, you can't detect that the mailer can't read the template file...
WTF !

Who's Online

257 user(s) are online (196 user(s) are browsing Support Forums)


Members: 0


Guests: 257


more...

Donat-O-Meter

Stats
Goal: $15.00
Due Date: Jul 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $15.00
Make donations with PayPal!

Latest GitHub Commits