It's just my impression or we have two independent lines of work in this module?!? Alfred still working on a version and here I see another in parallel..., in the end what the "official" version?!?
Why not work together to improve this module?!? I honestly do not understand this difficulty working in teams...

A few days ago I reported security flaws in this module... but when I check the repository in souceforge, I see that security holes are still there... far as I could see, Alfred has already begun to implement the corrections in your private repository...

Well, I think is extremely unproductive have to test two different versions of the same module... when we could all be focusing and efforts into a single version.

deka87:
As you can see yourself you have this:

after the newbb_1LV=1344940223;
there should not be any header after newbb.

Therefore Im completely sure that you have either a newline/space before in one important file like mainfile.php header.php and like that.
the other possibility is a BOM in your language files.

If i were you i will copy all files from main website to a subdomain and try to replace them with xoops 2.5.3 originals and test with just english language.

andrax:
the official version is Alfred version.
He is the true developer of newbb.
Im not a developer and i dont develop this newbb module.
if you see my changes i just want to clean this newbb from:
1- hardcodes in using php commands instead of XOOPS API
2- hardcodes css like style=" and align="left/right" in php and html files
3- find minor mistypes like an extra / here and there
4- copy/paste better codes from other modules/core. eg: newbb/makepdf.php is completely re-writen.

Also you can see i emphasis all my changes with "irmtfan". i did that because i want to make it easier for anybody to implement my changes.

I could not solve the security holes. Anyway i didnt see your reports here in xoops.org

I will release a new version today which is hopefully the last version of my corrections.

Also i will be in vacation for the next 5 days from tomorrow afternoon until the next week monday afternoon.

I hope Alfred could take time and review my codes and corrections.

Also i wish he could develop this module. I have a wish list like this:
- makepdf.php group permission system
- makepdf.php could create pdf from a topic (not only post)
- print.php could print a whole topic (not only post)
- remove all hardcodes from language files like %s, url, html codes

Hope i could explain that.
Im looking forward to see community opinions.

A new version is now available and i think it would be my final correction.
Other hardcodes could be removed but now it is good to have a final 4.3 version.
then we can have a newbb 4.4

Please download the newest version(rev.10073):
http://www.jadoogaran.org/test255/modules/newbb43_rev9883_irmtfan_2012_08_15.zip

changelog for rev.10073 start from the last official rev.9883:


Also i updated the svn:
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsModules/newbb/branches/irmtfan/newbb

I decide to not work on newbb anymore unless i receive a feedback or important reported hardcode.

*/

Thanks for the work done, irtmfan! Greatly appeciated!

I'll test tomorrow. Sorry for the delay.

deka87:
today i recognize that the following php files in newbb have extra newline after ?>

newbb/votepolls.php, newbb/include/notification.inc.php, newbb/class/permission.forum.php, newbb/admin/admin_groupmod.php

I know maybe your issue will not solved by removing those extra lines.
But it show us that we may have these problems in our websites.

IMO Xoops should have an error manager for headers and recognize when there is a problem like your issue when the headers are already sent.

Newbb 4.3 last irmtfan revision (10073 rev.).

Attachments works but when I post a message with it, I have this error :


SIMPLE-XOOPS (bad link)

newbb\xoops_version.php
Line 24:
replace:

with:


I did not find anything else for the moment. Great work

irtmfan,

yeah, cleaning the empty lines in those files didn't help.

(This newbb 4.3(http://www.xoops.org) have and problems with sessions)
Grrr, do I have to click several times submit, so I can post something... How I can exceed time on copy & paste and logged in from 2 seconds ?

Cesag:
Nice findings. can be easily correct but i prefer to wait for Alfred.

DCrussader:
I have this issue only in xoops.org newbb and not in 10 other newbb forum websites. mainly you should click and the post will submitted.
Im sure that it is because of some issues in other parts like that headers_sent() issue or protector issue.
I told several times that solving these issues in xoops.org forum is vitally important because new arrivals can see something good in their first impression.

To everybody:
I can see Alfred release the final version of 4.3 only in the german website. but that final version at least have the following reported and solved bugs:


Also i can see he update the SVN which is good.

IMo it also be good to implement the removing hardcodes in templates. i mean those align=left/right

Also i, sure black_beard correctly reported the unneeded ranks in url because in 2.5.5 ranks are store in the database like this in the field:
ranks/RANK.jpg

but in versions < 2.5.5 ranks are stored like this:
RANK.jpg

so it should be like this in template newbb_thread.html

<{$xoops_upload_url}>/<{$topic_post.poster.rank_image}>


Edit:
IMO this setting in include/plugin.php is dangerous:

If you update the newbb and this config was set to true you will lost all your pending and deleted posts/topics/forums.

It means just your approved data will be remain in the database.
IMO it should be set to false as default.