121
gstarrett
Re: XoopsGallery comments error
  • 2003/4/29 19:05

  • gstarrett

  • Friend of XOOPS

  • Posts: 174

  • Since: 2002/3/12


Thanks for looking into this. I took a look at the fix and it only partially corrects the problem. The post_comment.php now looks only to the GET query for the information, but not to POST query. When you post a new comment, the $commentnav "post comment" button is a POST query to the comments form and therefore the values aren't passed properly.

$extra_params .= isset($HTTP_POST_VARS[$extra_param]) ? $extra_param.'='.$HTTP_POST_VARS[$extra_param].'&' : isset($HTTP_GET_VARS[$extra_param]) ? $extra_param.'='.$HTTP_GET_VARS[$extra_param].'&' $extra_param.'=&';

Would something like that do the trick? Probably better to seperate into a seperate utility sub.

function GetGPLVar($param) {
    if isset(
$HTTP_POST_VARS[$param]) {
        return 
$HTTP_POST_VARS[$param]
    } elseif isset(
$HTTP_GET_VARS[$param]) {
        return 
$HTTP_POST_VARS[$param]
    } else {
        return isset(${
$param}) ? ${$param} : ''
    
}
...

    
$extra_params .= $extra_param.'='.GetGPLVar($extra_param).'&'

...

I know there's a more appropriate place for something like this, but I'm not familiar enough with XOOPS core yet to even guess. Also please pardon my hack|buggy PHP coding, I don't have time to properly test the code now or look up the XOOPS coding standards.

Thanks for all the great work.



122
gstarrett
Re: XoopsGallery comments error
  • 2003/4/25 19:23

  • gstarrett

  • Friend of XOOPS

  • Posts: 174

  • Since: 2002/3/12


Bump. Anyone? Should I direct this toward anyone in particular? I looked through the wiki but it didn't help (maybe I just didn't see the correct secion?).



123
gstarrett
XoopsGallery comments error
  • 2003/4/25 4:00

  • gstarrett

  • Friend of XOOPS

  • Posts: 174

  • Since: 2002/3/12


Hi all--I'm still working on understanding all the ins & outs of the new XOOPS + Smarty + XoopsGallery and was hoping someone could point me in the right direction.

When I add a comment, and look at the /include/comment_form.php (included by /modules/XoopsGallery/comment_new.php) hidden inputs, the "extra_param" values are blank. I think I MAY have found the source of the problem. in /include/comment_form.php line 109 says:
Quote:
$hidden_value = isset(${$extra_param}) ? htmlspecialchars(${$extra_param}, ENT_QUOTES) : '';


...and it is NOT including the values. However, when I change register_globals to ON, it works. Should I correct the above line, or is it the responsibility of the /modules/XoopsGallery/comment_new.php to set them in the first place? I looked for a generic "HTTP_GET|POST_VARS to Local vars" routine, but didn't find any one place--it looks like the modules are responsible for the pulling in, but I'm not sure.

Where does the patch need to go? XOOPS core or XoopsGallery? I've seen other posts about "some modules don't work correctly yet with register_globals off", could this be why??

I am just starting to dip my toe into the new Xoops2 setup, but it looks very nice so far (albeit a bit of a learning curve--I've only started OO programming and am very new to it in PHP and it's a little "spread out"). Any help is appreciated.

Regards,

Glen Starrett



124
gstarrett
Re: after update cvs blank screens
  • 2003/1/21 17:50

  • gstarrett

  • Friend of XOOPS

  • Posts: 174

  • Since: 2002/3/12


I'm seeing the same thing on mine. Looks like they were in the middle of refactoring getcss() to xoops_getcss(), change that back in XOOPS_ROOT\header.php to revert so it sort-of works. My setup still has a bad home page, but I'm not going to worry about it until the next CVS update (shows menu, login, blocks, but not formatted).

On the positive side, I VERY much like the new administrative section. Nice job!



125
gstarrett
Re: IIS Install problem
  • 2002/6/10 2:59

  • gstarrett

  • Friend of XOOPS

  • Posts: 174

  • Since: 2002/3/12


FYI, I had the same problem on my Win2K-SP2 machine and the include path fix worked fine. The default include path on my Win2k PHP 4.1.2 install was c:\php4\pear -- which doesn't exist (php is installed on D, not C and I don't have pear installed). I would assume this is a really PHP bug / issue???

Note that my PHP.INI looked like this before:

; UNIX: "/path1:/path2"
;include_path = ".:/php/includes"
;
; Windows: "\path1;\path2"
; include_path = ".;d:\php\includes"

Simply uncommenting the last "include_path = ..." line fixed the problem. I still don't know where it was getting c:\php4\pear from....

Thanks!




TopTop
« 1 ... 10 11 12 (13)



Login

Who's Online

235 user(s) are online (174 user(s) are browsing Support Forums)


Members: 0


Guests: 235


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: May 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits