Bug fix: bad_user_name setting in "User Info Settings" - Developer News - XOOPS News

XOOPS

News

News World of XOOPS Developers Hacks Themes Archive Submit News

Developer News: Bug fix: bad_user_name setting in "User Info Settings"

Posted by: kanakaOn 2003/4/28 18:23:51 5445 reads

The bug is:
In the "User Info Settings", there is a setting named "Enter names that should not be selected as username", but this function doesn't work.

How to fix it:
Edit the file /register.php, go to line 83, and change "bad_emails" to "bad_unames".

(You may possibly worry about the Email verification, well, just set your heart at rest, the Email verification code is the lines begin from line 50.)

By Hiweed,
cn.xoops.org, http://www.hiweed.com

The comments are owned by the author. We aren't responsible for their content.

Re: Bug fix: bad_user_name setting in "User Info Settin

mbogosian Published 04/28/2003 20:19 Just popping in Joined 09/30/2002 Comments 53

Are we posting bug reports via News now?

I guess SourgeForge is out....

Re: Bug fix: bad_user_name setting in "User Info Settin

Bunny Published 04/29/2003 7:00 XOOPS Advisor Joined 10/21/2002 Comments 57

Have you looked at the status of the reported bugs there?

Re: Bug fix: bad_user_name setting in "User Info Settin

_masi Published 04/29/2003 9:29 Just popping in Joined 03/28/2003 Comments 19

I guess he got a bit impatient. He has posted the bug (and a fix) already. It is good to see new versions that fix security problems, it would be nice to get other bugs fixed as well. Especially if they can be fixed in a few minutes. All of the bugs I've filed and are open, are of that kind.

But I am not ungrateful. The team has done a very good job. I say, thanks many times, kudos to all of the project maintainers! Don't let impatient users get you down.

PS: The Bugs forum should IMHO be closed, if the Sourceforge bug tracker is now the "official" tool. Has the disadvantage that you have to register there as well.

Re: Bug fix: bad_user_name setting in "User Info Settin

Boobtoob Published 04/29/2003 13:13 Friend of XOOPS Joined 12/22/2001 Comments 202

Well, you can close a forum without deleting all the posts and sometimes a search turns up useful information from these old forums.

Re: Bug fix: bad_user_name setting in "User Info Settin

mbogosian Published 04/29/2003 20:18 Just popping in Joined 09/30/2002 Comments 53

Actually, I have. I know it seems like it's not a very active list, but you should check out the ones that have been fixed. The oldest unfixed bug in the list is only two-and-a-half months old (pretty good by anyone's standards) with many bugs' lifetimes being much shorter than that.

SourceForge (and Savannah) are excellent tools for allowing developers to consolidate and organize their bug tracking. Organized bugs means better visibility and assessment, and better visibility and assessment means more things get fixed faster.

Re: Bug fix: bad_user_name setting in "User Info Settin

mbogosian Published 04/29/2003 20:25 Just popping in Joined 09/30/2002 Comments 53

Quote:

I guess he got a bit impatient. He has posted the bug (and a fix) already. It is good to see new versions that fix security problems, it would be nice to get other bugs fixed as well.

SourceForge allows you to attach files to bugs, so third parties can fix bugs and attach their patched files (with the fixes) with the bugs so that the XOOPS developers can easily review and encorporate the change in the next release.

Quote:

Especially if they can be fixed in a few minutes. All of the bugs I've filed and are open, are of that kind.

Did you just file the bug, or did you include a fix? Bugs with fixes often get fixed faster than those without.

Re: Bug fix: bad_user_name setting in "User Info Settin

_masi Published 04/30/2003 7:32 Just popping in Joined 03/28/2003 Comments 19

 Did you just file the bug, or did you include a fix? Bugs with fixes often get fixed faster than those without.

I gave a description of the problem, what I think causes it and a possible solution.

I didn't attach diffs, though. But I'll try to attach them if that helps.

Re: Bug fix: bad_user_name setting in "User Info Settin

mbogosian Published 04/30/2003 11:02 Just popping in Joined 09/30/2002 Comments 53

Actually, the devs don't like diffs. Instead, submit your patched XOOPS files (make sure to leave any $Id$ tags intact so they know which version you patched).

I've tried submitting diff/patch files before, but they seem to prefer to do their own diffs. Dunno why, but that's the way they work, and I'm not about to bite the hand that feeds me....

Re: Bug fix: bad_user_name setting in "User Info Settin

_masi Published 04/30/2003 12:01 Just popping in Joined 03/28/2003 Comments 19

Quote:

Actually, the devs don't like diffs.

Bah!

Thanx for the info. It would have save me some troubles creating those diffs (to be found in the Patches tracker section).

Why devs don't like diffs

Bunny Published 04/30/2003 15:39 XOOPS Advisor Joined 10/21/2002 Comments 57

The reason is simple:
Most of our Devs work on Windoze and that doesn't have the "patch" utility that you need to apply a diff to a file.

Re: Why devs don't like diffs

ndial Published 04/30/2003 17:27 Just popping in Joined 03/03/2003 Comments 29

Doesn't CVS have patch tools built into it? I'm not sure how they work --I probably only know how to do 1% of the possible things there are to do with CVS-- but I thought there was a way to apply a patch with it.

Still, that doesn't get me away from the larger issue, that is the devs should get "real computers." and be leet like me.

Re: Why devs don't like diffs

mbogosian Published 04/30/2003 18:55 Just popping in Joined 09/30/2002 Comments 53

Quote:

Still, that doesn't get me away from the larger issue, that is the devs should get "real computers." and be leet like me.

There is an interesting compromise (and if I was ever forced to run windoze, this is what I would use). It's called Cygwin. It provides all your favorite GNU/UNIX utilities (e.g., gcc, make, autoconf, automake, diff, patch, ls, bash, grep, sed, X11, ssh, on-and-on...) via windows. It's not quite as good as the real thing, but it's certainly passable.

Of course the devs (and anyone else) can run whatever they want, but Cygwin offers a little more freedom and consistency to any developer's toolbox.

Re: Why devs don't like diffs

Bunny Published 04/30/2003 19:29 XOOPS Advisor Joined 10/21/2002 Comments 57

Quote:

Cygwin offers a little more freedom and consistency to any developer's toolbox.

I've been using Cygwin for years, but for the average Windoze user who's never learned the beauty of the bash, the learning curve is almost as steep as switching to linux completely. Same reason they don't use CVS from the command-line, or the most productive editor in the world, Emacs...

Re: Bug fix: bad_user_name setting in "User Info Settin

Beso Published 05/03/2003 15:51 Just popping in Joined 06/30/2002 Comments 2

sorry a din't understood ;)
what's about line 50 did we have to change the same word "bad_emails" to "bad_unames" in line 50 ?
thanks

Re: Bug fix: bad_user_name setting Version 2.0.3

Venezia Published 07/08/2003 5:10 Updated 08/12/2003 5:22 Just popping in Joined 06/24/2003 Comments 36

Only the edit on line 83 is required. Forget about line 50.

Login

Username

Password

Remember me

Search

Advanced Search

Donat-O-Meter

Stats
Goal:	$100.00
Due Date:	Nov 30
Gross Amount:	$0.00
Net Balance:	$0.00
Left to go:	$100.00

Latest GitHub Commits

{{ record.sha.slice(0, 7) }} - {{ record.commit.message | truncate }}

{{ record.commit.author.name }} {{ record.commit.author.date | formatDate }}

Developer News: Bug fix: bad_user_name setting in "User Info Settings"

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting in "User Info Settin

Why devs don't like diffs

Re: Why devs don't like diffs

Re: Why devs don't like diffs

Re: Why devs don't like diffs

Re: Bug fix: bad_user_name setting in "User Info Settin

Re: Bug fix: bad_user_name setting Version 2.0.3

Login

Search

Recent Comments

Re: New Admin Theme for XOOPS (Beta)

Sanford Pharmacy: Exceptional Pharmacy Services Tailored to You

Re: New Admin Theme for XOOPS (Beta)

Re: XOOPS 2.5.12 Beta-2 available for Testing

Re: XOOPS 2.5.12 Beta-2 available for Testing

Who's Online

Donat-O-Meter

Latest GitHub Commits

{{ record.sha.slice(0, 7) }} - {{ record.commit.message | truncate }}

Archives

News archives