XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. General XOOPS.org forums / 
  3. Technology, Tools, Best Practices 
  4.  / Request for an explanation of the checks during a Pull request
Register
1
alain01
Request for an explanation of the checks during a Pull request

  • 2021/8/24 14:57

  • alain01

  • Just can't stay away

  • Posts: 536

  • Since: 2003/6/20


Hello,
I see that when you propose a Pull Request,
the system launches a whole bunch of checks with "Scrutinizer".

I am curious, and I want to understand a little more.
I think this is called continuous integration (devops?), isn't it?

Without going into too much detail but enough to be understandable,
could you explain what you did to add tests, what kind of tests you added.
Did you use your own scripts or did you use tools inside the Scrutinizer?
Some examples would be great to better understand what is going on in a PR.
I think that's what you can find here: https://scrutinizer-ci.com/g/XOOPS/XoopsCore25/inspections/5b0ce835-d67e-439c-a541-f6e754b6ead3/configs
but I prefer to read the experts' answers.

Thank you for the time you will spend explaining this.

Alain
2
Mamba
Re: Request for an explanation of the checks during a Pull request

  • 2021/8/24 16:24

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
What is Scrutinizer

Scrutinizer is a static analysis tool that helps with code quality by doing Automated Code Reviews

It is highly recommended to run your code through such tools, as they point out issues that sometimes are missed or overlooked by developers.

Quote:
what you did to add tests,

You go to Scrutinizer and start a test on a particular Github repository. Scrutinizer will then add itself to that repository via Webhooks, so next time when a PR is added, it will run the tests automatically (see here).

Quote:
what kind of tests you added.

You can list the tests that you want to run in the configuration file .scrutinizer.yml file (see here).

Quote:
Did you use your own scripts or did you use tools inside the Scrutinizer?

We use the tests provided by Scrutinizer

There are other Static Analysis Tools as well - a good list is here
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs
3
alain01
Re: Request for an explanation of the checks during a Pull request

  • 2021/8/26 7:01

  • alain01

  • Just can't stay away

  • Posts: 536

  • Since: 2003/6/20


Ok, Thank you for your answer.
So, for us, it uses XoopsCore25/.scrutinizer.yml.

Ok. may be I should add a static analysis on 1 of my repositories to test and understand.
4
Mamba
Re: Request for an explanation of the checks during a Pull request

  • 2021/8/27 7:09

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
Ok. may be I should add a static analysis on 1 of my repositories to test and understand.

Yes, you absolutely should use something like Scrutinizer!

This is a great video showing the need to use static analyzers like PhpStan and PhpInsights:


Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs
5
alain01
Re: Request for an explanation of the checks during a Pull request

  • 2021/8/27 7:52

  • alain01

  • Just can't stay away

  • Posts: 536

  • Since: 2003/6/20


Ok, seen,
Thank you.

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

323 user(s) are online (115 user(s) are browsing Support Forums)

Members: 0

Guests: 323

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits