xoops forums

Bleekk

Theme Designer
Posted on: 2016/5/30 19:18
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 903
Since: 2002/12/14
#1

Publisher and xoops 2.5.8 tests

Hi,

I had a little bit time and have tested the new xoops version with publisher.
One thing first, publisher ist the most powerfull article/blog module for xoops!
If you consider publishing news or articles on your website then publisher should be the first choise!

The version of publisher I have tested is the developing one from github. The module works almost perfect!
Here are my testresults:

Upload Image ....OK (First create a category in the image manager)

Upload File ........OK

Read Article .......NOK

- Notice: Undefined offset: 0 in file /modules/publisher/class/file.php line 382
- Missing Icons for Edit file, Delete file and Download this file
Edit themes/xbootstrap/modules/publisher/publisher_item.tpl - line 122, 125 and 129
Add in the imagte link the folder assets/ like
<img src="<{$publisher_url}>/assets/images/links/edit.gif" title="<{$smarty.const._CO_PUBLISHER_EDITFILE}>"


piblishing comments.... NOK
Unknown: Only variables should be assigned by reference in file /class/commentrenderer.php line 426


If the option "Display block summary on items page?" is set to yes the article should display summary and body (in my opinion).
If set to NO only body should be display. Now if it is set to YES only summary would show up and if it set to NO only body will displayed.

Bloks:

Recent item List - No articles displayed - no errors in debugger

Mamba

Moderator
Posted on: 2016/7/7 17:49
Mamba
Mamba (Show more)
Moderator
Posts: 10406
Since: 2004/4/23
#2

Re: Publisher and xoops 2.5.8 tests

Thanks for testing and feedback.

I think, everything should be fixed now in Publisher 1.03 RC 1 release

If I don't hear anything about any new bugs in a week, I'll be released it as FINAL!
Support XOOPS => DONATE
Use 2.5.9 | Docs | Modules | Bugs

Cesagonchu

Moderator
Posted on: 2016/7/8 12:31
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 857
Since: 2010/2/1 2
#3

Re: Publisher and xoops 2.5.8 tests

I found two bugs. I sent you an email.

Bleekk

Theme Designer
Posted on: 2016/7/8 13:03
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 903
Since: 2002/12/14
#4

Re: Publisher and xoops 2.5.8 tests

Please submit the bugs here in forums or on github so everyone can help.

Cesagonchu

Moderator
Posted on: 2016/7/8 19:50
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 857
Since: 2010/2/1 2
#5

Re: Publisher and xoops 2.5.8 tests

Ok, so:

1 - Recent Articles (detail) block doesn't show

2 - PDF generation for articles is not working

3 - Invalid argument supplied for foreach()

Bleekk

Theme Designer
Posted on: 2016/7/8 22:09
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 903
Since: 2002/12/14
#6

Re: Publisher and xoops 2.5.8 tests

PDF Problem:

I have no idea why or what the point of it but you need THIS in the folder /class/libraries/vendor/tecnickcom/tcpdf/


as I can see in your bug report your third problem is a profile not a publisher problem.

Bleekk

Theme Designer
Posted on: 2016/7/8 22:20
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 903
Since: 2002/12/14
#7

Re: Publisher and xoops 2.5.8 tests

To your first problem
open /modules/publisher/blocks/items_new.php
in line 59 find
if ($itemsObj && $totalitems 1) {

change it to
if ($itemsObj && $totalitems >= 1) {


If there is only one article it should be now displayed in the block.

The same in items_recent in the line 61. Here we have the same bug.

You should look in other blocks too. Maybe this bug is in all blocks

Mamba

Moderator
Posted on: 2016/7/8 22:50
Mamba
Mamba (Show more)
Moderator
Posts: 10406
Since: 2004/4/23
#8

Re: Publisher and xoops 2.5.8 tests

Quote:
I have no idea why or what the point of it but you need THIS in the folder /class/libraries/vendor/tecnickcom/tcpdf/

The location:

/class/libraries/vendor/

is for our external libraries, that can be deployed using Composer. The advantage is that they will be "autoloaded". We have already WideImage there, and the latest News version is already taking advantage of it.

But if needed, we'll make it downloadable too...
Support XOOPS => DONATE
Use 2.5.9 | Docs | Modules | Bugs

Bleekk

Theme Designer
Posted on: 2016/7/8 23:12
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 903
Since: 2002/12/14
#9

Re: Publisher and xoops 2.5.8 tests

I thought that composer is a xoops 2.6 feature.
We should provide tcpdf with xoops or change the module. Because creating pdf is not working in any module that needs tcpdf.
I do not think that implementing unfinished features in 2.5 modules is a good idea.
How does the news module handle it in 2.5.8?

Cesagonchu

Moderator
Posted on: 2016/7/9 10:36
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 857
Since: 2010/2/1 2
#10

Re: Publisher and xoops 2.5.8 tests

Thank you for your help Bleekk!

In my third problem, Puplisher is reported into the error:

Warning: Invalid argument supplied for foreach() in file /modules/publisher/include/search.inc.php line 50