1
irmtfan
Core feature: xoops sample forms need enhancements
  • 2013/4/3 2:13

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


recently I could not be able to work with sf.net (send features,bugs or download directly) because sf.net ban Iranian IPs more severe than before.
So please somebody send the below feature request on behalf of me from this link:
https://sourceforge.net/p/xoops/feature-requests/new/

title:
sample forms in XoopsForm classes need some enhancements

content:
There is 2 xoops forms in xoops/class/xoopsform folder that needs some enhancements.
1- simpleform.php
It dont have the element class.
I suggest to replace it with this:
<?php
/**
 * XOOPS simple form
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @package         kernel
 * @subpackage      form
 * @since           2.0.0
 * @author          Kazumi Ono (AKA onokazu) http://www.myweb.ne.jp/http://jp.xoops.org/
 * @version         $Id: simpleform.php 8066 2011-11-06 05:09:33Z beckmi $
 */

defined('XOOPS_ROOT_PATH') or die('Restricted access');

/**
 * base class
 */
xoops_load('XoopsForm');

/**
 * Form that will output as a simple HTML form with minimum formatting
 */
class XoopsSimpleForm extends XoopsForm
{
    
/**
     * create HTML to output the form with minimal formatting
     *
     * @return string
     */
    
function render()
    {
        
$ret = ($this->getTitle() ? "<div class=" center head ">" $this->getTitle() . "</div>" "");
        
$ret.= "<form name='" $this->getName() . "' id='" $this->getName() . "' action='" $this->getAction() . "' method='" $this->getMethod() . "'" $this->getExtra() . ">n";
        foreach (
$this->getElements() as $ele) {
            if (!
$ele->isHidden()) {
                
$ret .= "<div class="" . $ele->getClass() . ""><strong>" $ele->getCaption() . "</strong>" $ele->render() . "</div>";
            } else {
                
$ret .= $ele->render() . "n";
            }
        }
        
$ret .= "</form>n";
        return 
$ret;
    }
}


I used the above in userlog:
http://svn.code.sf.net/p/xoops/svn/Xo ... class/form/simpleform.php

2- themeform.php
It should be changed with a full div table with better looking and less hard-codes.
Also an id for each element is very needed like this:
$ret .= '<tr id="' $ele->getName() . '" valign="top" align="left"><td class="head">';


then module developers can get the element by id.

2
irmtfan
Re: Core feature: xoops sample forms need enhancements
  • 2013/4/7 9:12

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


anybody could send this feature on behalf of me?

3
luciorota
Re: Core feature: xoops sample forms need enhancements
  • 2013/4/7 10:09

  • luciorota

  • Module Developer

  • Posts: 212

  • Since: 2007/4/20


I could
Where?
xoops 2.5.6 or xoops 2.6.0?
IMO, I think xoops 2.6.0 but, what core developers prefer?


4
irmtfan
Re: Core feature: xoops sample forms need enhancements
  • 2013/4/7 11:37

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


yes. 2.6 for sure.
the main plan is dont add any feature to xoops < 2.6

Login

Username:
Password:

Lost Password? Register now!

Who's Online

64 user(s) are online (48 user(s) are browsing Support Forums)


Members: 0


Guests: 64


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: May 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits