xoops forums

Mamba

Moderator
Posted on: 2012/9/24 21:33
Mamba
Mamba (Show more)
Moderator
Posts: 10744
Since: 2004/4/23
#1

TDMCreate 1.38.1 Beta 1 ready for testing & feedback

I started working on a slightly updated TDMCreate version: TDMCreate 1.38.1 Beta 1

Some changes:

- added: logo image generator
- added: option to rename module and tables
- added: generated tables start with "mod_"
- added: user info stored in Preferences
- added: module info pulled from Preferences
- added: plugins for Waiting module
- clean-up of English translations, and constants
- fixed several error notices and bugs

The goal is to have TDMCreate generating an "error-free, fully functional" basic XOOPS module. I think, we're getting closer to it, but there is still more clean-up needed, and we need more testing.

There are still some of the options not working, and I'll be making changes to the generated fields: I am not sure we need all the current ones, and some are missing.

So there will be more changes coming, but for the time being, please test it and share your experiences.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Anonymous

Posted on: 2012/9/28 21:03
Anonymous
Anonymous (Show more)
Posts: 0
Since:
#2

Re: TDMCreate 1.38.1 Beta 1 ready for testing & feedback

So this is the release to continue with?

Language changes made for the dutch language files. Is TDMCreate on transifex?

There is a problem with the creation of a module.
Go to Modules and click Add module. Click on make module and the following warning appears and no module is created.
WarningUndefined indexxoops_upload_file in bestand /modules/TDMCreate/admin/modules.php line 39

Mamba

Moderator
Posted on: 2012/9/29 0:21
Mamba
Mamba (Show more)
Moderator
Posts: 10744
Since: 2004/4/23
#3

Re: TDMCreate 1.38.1 Beta 1 ready for testing & feedback

Thank you for testing!

Quote:
So this is the release to continue with?

Timgno is working on the next version with a changed architecture (it will be more OOP), but I am not sure when that will be ready. I suggested to him to call it 2.0 because of the changed architecture.

So for the time being, I'll be focusing on the 1.x branch. The goal is to make this version 100% working with no errors, so we can start cranking out some new modules

What system did you test it? I believe, there are some issues with folder permissions, if you do it on Linux. Try it on WAMP server or something similar on Windows, and let me know if the issues are still there.

Since there are possible changes to this module, I would wait a little bit with Transifex.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

goffy

Quite a regular
Posted on: 2012/11/18 9:38
goffy
goffy (Show more)
Quite a regular
Posts: 352
Since: 2010/12/27
#4

new feature

Hi

you use the dir '\Frameworks\moduleclasses\icons\32\' in module admin.
it would be fine, if your own icons are copied to this dir while installing/updating

I added following code to my install.php:
$pic_path XOOPS_ROOT_PATH.'/modules/myModule/images/32/';
 if(
is_dir($pic_path)) {
  
$pic_dir = @opendir($pic_path) or die("invalid path $pic_path");
  
$exempted "index.html";
  while (
$filename readdir($pic_dir))
  {
    if((
$filename!=".") and ($filename!="..") and ($filename!=$exempted )) {
      
copy($pic_path.$filenameXOOPS_ROOT_PATH.'/Frameworks/moduleclasses/icons/32/'.$filename);
    }
  }
  
closedir($pic_dir);
}

goffy

Quite a regular
Posted on: 2012/11/18 9:41
goffy
goffy (Show more)
Quite a regular
Posts: 352
Since: 2010/12/27
#5

sort order tables

the tabs/menu in module admin will be generated in order of table_id. it would be nice if there would be a possibility to sort them (e.g. with an additional field in tdmcreate_tables).

goffy

Quite a regular
Posted on: 2012/11/18 9:50
goffy
goffy (Show more)
Quite a regular
Posts: 352
Since: 2010/12/27
#6

add update.php

you have often the need of an update, if you work on a new module

please add
$modversion['onUpdate'] = 'include/onupdate.php';
in xoops_version.php and create an empty onupdate.php

irmtfan

Module Developer
Posted on: 2012/11/19 12:01
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#7

Re: sort order tables

I consider all admin side features just for webmasters.
IMO there are many many features missing in user side which have more priority.
in the past core team (Mage) decided to add module admin class to unify the look of all module admins.
If you see that class it is full of html hardcodes.
IMO it would be better to have a admin theme like user theme

irmtfan

Module Developer
Posted on: 2012/11/19 12:08
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#8

Re: new feature

IMO unifying and integrating module/core images/icons should be done with more consideration.
module developer dont need to add general icons at all for module.
I mean eg pdf icon just should be in core and developer could access that.

but firstly Core team should decide how to handle images/icons in XOOPS.
IMO the best way is what newbb did in version 4.3


read here:
https://docs.google.com/document/pub?i ... SSGPCH-5YSkd-iI9CawmEp-Os

Quote:

From this time go on all module developers encouraged to save images in this folder:

Modules/YOUR_MODULE/templates/images

Where ever possible please do not use images with text or having left/right alignment.

But if you have these images you should separate images with text or having left/right alignment and move them to language directories.

All other images like icons should be language free (no text or alignment)

Example:

Modules/YOUR_MODULE/templates/images/icons

Modules/YOUR_MODULE/templates/images/language/english

Modules/YOUR_MODULE/templates/images/language/persian

Please pay attention that in the future module developers don’t need to do anything for their images. They just define their images in a images.php file and XOOPS will read them.

for example instead of this method:

<img src="<{xoImgUrl img/pdf.png}>" alt="_PDF"/>

you create a smarty variable in your script:

$icon_pdf= displayImage('system', 'pdf', _PDF); // get the icon from system module.

$xoopsTpl->assign('icon_pdf', $icon_pdf);

and just use that in your theme/template

<{$icon_pdf}>

Also full image customization would be possible per theme.

themes/YOUR_THEME/module/YOUR_MODULE/images/icons

themes/YOUR_THEME/module/YOUR_MODULE/images/language/english

themes/YOUR_THEME/module/YOUR_MODULE/images/language/persian



please if you are interested read this post and continue here:
https://xoops.org/modules/newbb/viewtopic.php?post_id=349158

irmtfan

Module Developer
Posted on: 2012/11/19 12:10
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#9

Re: add update.php

very useful comment.
currently many new modules dont have update script.

goffy

Quite a regular
Posted on: 2012/11/28 21:27
goffy
goffy (Show more)
Quite a regular
Posts: 352
Since: 2010/12/27
#10

Re: TDMCreate 1.38.1 Beta 1 ready for testing & feedback

Hi

it doesn't matter whether you say to
"Create a new block for this table (blocks: random, latest, today)" yes or no
it will be always created
blocks/blocks_{mytablename}.php
templates/blocks/xnewsletter_{mytablename}_block_day.html
...


Keep on working, the module is great
Goffy