XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. Beginner's Corner 
  4.  / Please help me with MyGuestbook
Register
1
ipwgc
Please help me with MyGuestbook

  • 2011/12/2 8:13

  • ipwgc

  • Quite a regular

  • Posts: 216

  • Since: 2005/8/13



Please help me,
I installed the module MyGuestbook (Narga) Version 1.5
https://xoops.org/modules/repository/singlefile.php?cid=35&lid=1407

1. I translate the module in Spanish
2. I cannot delete and install other, because people already posted info.
3. The particular module I prepare for people make a prayer covenant

Now, my problems is the spam injection people,
I need delete manually, and I need stop this now.
The protect module stop a lot spammer and helps a lot.
but the spammer continue on the myguestbook module

I make the bellow changes, in the robot.txt

Disallow: /modules/myguestbook/
Disallow: /modules/myguestbook/sign.php

I belive that I need a capchat on the sing.php page.

You are welcome with any Idea to fixe my problem.

see the module working here
http://www.iglesiainternacional.cl/chile/modules/myguestbook/index.php

Regard
David
2
Roby73
Re: Please help me with MyGuestbook

  • 2011/12/2 16:18

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


That xoops version you use?
Would be possible add captcha/recaptcha code.
3
ipwgc
Re: Please help me with MyGuestbook

  • 2011/12/2 16:35

  • ipwgc

  • Quite a regular

  • Posts: 216

  • Since: 2005/8/13


Hi Roby73,
I used the xoops 2.5.3

to add captcha/recaptcha code
how I add?
Thank for help
David

4
Roby73
Re: Please help me with MyGuestbook

  • 2011/12/2 17:21

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


I can try add it, tonight install in local the module to test.
5
ipwgc
Re: Please help me with MyGuestbook

  • 2011/12/2 18:01

  • ipwgc

  • Quite a regular

  • Posts: 216

  • Since: 2005/8/13


Thank you, together we will solve this problem,
otrer can used too,
David
6
Roby73
Re: Please help me with MyGuestbook

  • 2011/12/2 22:19

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


The module is very old, have much deprecated functions.

This is a simple code to add captcha code.

Replace sign.php file with:

###############################################################################

#                  Narga's Guestbook v.1.0 for Xoops 2.x                      #

#             Writen by  Nguyen Dinh Quan (webmaster@narga.tk)                #

#      :: Narga Vault :-: The Land Of Dreams ::(http://www.narga.tk)          #

#   ------------------------------------------------------------------------- #

#       A produce of [:: Narga Laboratory ::] (http://www.nargalab.info)      #

#   ------------------------------------------------------------------------- #

#   This program is free software; you can redistribute it and/or modify      #

#   it under the terms of the GNU General Public License as published by      #

#   the Free Software Foundation; either version 2 of the License, or         #

#   (at your option) any later version.                                       #

#                                                                             #

#   This program is distributed in the hope that it will be useful,           #

#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #

#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #

#   GNU General Public License for more details.                              #

#                                                                             #

#   You should have received a copy of the GNU General Public License         #

#   along with this program; if not, write to the Free Software               #

#   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA  #

#   ------------------------------------------------------------------------  #

###############################################################################

// $Id: sign.php,v 1.2.1 Date: 8/30/2004 10:37 PM, Author: Nguyen Dinh Quan Exp $

include_once "header.php";

if ( empty($_POST['submit']) ) {

    $xoopsOption['template_main'] = 'myguestbook_sign.html';

    include XOOPS_ROOT_PATH."/header.php";

    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";

//Get the user database

    $company_v = "";

    $name_v = !empty($xoopsUser) ? $xoopsUser->getVar("uname", "E") : "";

    $email_v = !empty($xoopsUser) ? $xoopsUser->getVar("email", "E") : "";

    $url_v = !empty($xoopsUser) ? $xoopsUser->getVar("url", "E") : "";

    $icq_v = !empty($xoopsUser) ? $xoopsUser->getVar("user_icq", "E") : "";

    $msn_v = !empty($xoopsUser) ? $xoopsUser->getVar("user_msnm", "E") : "";

    $aim_v = !empty($xoopsUser) ? $xoopsUser->getVar("user_aim", "E") : "";

    $yim_v = !empty($xoopsUser) ? $xoopsUser->getVar("user_yim", "E") : "";

    $location_v = !empty($xoopsUser) ? $xoopsUser->getVar("user_from", "E") : "";

    $message_v = "";

    $title_v = "";

    //Make form type

    $name_text = new XoopsFormText(_NAR_NAME, "usersName", 50, 100, $name_v);

    $email_text = new XoopsFormText(_NAR_EMAIL, "usersEmail", 50, 100, $email_v);

    $gender_select = new XoopsFormSelect(_NAR_SELGEN, "userGender",3);

    $gender_select->addOptionArray(array("3"=>_NAR_SELGEN,"0"=>_NAR_MALE,"1"=>_NAR_FEMALE,"2"=>_NAR_OTHER));

    $url_text = new XoopsFormText(_NAR_URL, "usersSite", 50, 100, $url_v);

    $icq_text = new XoopsFormText(_NAR_ICQ, "usersICQ", 50, 100, $icq_v);

    $msn_text = new XoopsFormText(_NAR_MSN, "usersMSN", 50, 100, $msn_v);

    $aim_text = new XoopsFormText(_NAR_AIM, "usersAIM", 50, 100, $aim_v);

    $yim_text = new XoopsFormText(_NAR_YIM, "usersYIM", 50, 100, $yim_v);

    $company_text = new XoopsFormText(_NAR_COMPANY, "usersCompanyName", 50, 100, $company_v);

    $location_text = new XoopsFormText(_NAR_LOCATION, "usersCompanyLocation", 50, 100, $location_v);

    $title_text = new XoopsFormText(_NAR_TITLE, "usersTitle", 50, 100, $title_v);

    $message_textarea = new XoopsFormDhtmlTextArea(_NAR_MESSAGE, "usersMessage", $message_v);

    $submit_button = new XoopsFormButton("", "submit", _NAR_SEND, "submit");

    $myguestbook_form = new XoopsThemeForm(_NAR_SIGNGUESTBOOK, "myguestbookform", "sign.php");

//Fill data to form text

    $myguestbook_form->addElement($name_text, true);

    $myguestbook_form->addElement($gender_select,3);

    $myguestbook_form->addElement($email_text, true);

    $myguestbook_form->addElement($url_text);

    $myguestbook_form->addElement($icq_text);

    $myguestbook_form->addElement($msn_text);

    $myguestbook_form->addElement($aim_text);

    $myguestbook_form->addElement($yim_text);

    $myguestbook_form->addElement($company_text);

    $myguestbook_form->addElement($location_text);

    $myguestbook_form->addElement($title_text);

    $myguestbook_form->addElement($message_textarea, true);
    $myguestbook_form->addElement(new XoopsFormCaptcha(), true);

    $myguestbook_form->addElement($submit_button);

    $myguestbook_form->assign($xoopsTpl);

    //Assign data to smarty tpl

    $xoopsTpl->assign('lang_index', _NAR_BACKGUESTBOOK);

    $xoopsTpl->assign('lang_info', _NAR_DESC);

    $xoopsTpl->assign('lang_copyright', _NAR_COPYRIGHT);

    $xoopsTpl->assign('lang_writing', _NAR_SIGNGUESTBOOK);

    $xoopsTpl->assign('lang_gender', _NAR_GENDER);

    $xoopsTpl->assign('lang_title', _NAR_TITLE);

    $xoopsTpl->assign('lang_cancel', _CANCEL);

    $xoopsTpl->assign('lang_nameenter', _NAR_NAMEENTER);

    $xoopsTpl->assign('lang_msenter', _NAR_MSENTER);

    include XOOPS_ROOT_PATH."/footer.php";

} else {
    extract($_POST);

    extract($_POST);    

    $myts =& MyTextSanitizer::getInstance();

    $name_text = $myts->stripSlashesGPC($usersName);

    $title_text = $myts->stripSlashesGPC($usersTitle);

    $message_textarea = $myts->stripSlashesGPC($usersMessage);

    $date=time();

    $email = $myts->stripSlashesGPC($usersEmail);

    $url_text = $myts->stripSlashesGPC($usersSite);

    $ip=$GLOBALS['REMOTE_ADDR'];

    $gender_select = $myts->stripSlashesGPC($userGender);

    $icq_text = $myts->stripSlashesGPC($usersICQ);

    $aim_text = $myts->stripSlashesGPC($usersAIM);

    $yim_text = $myts->stripSlashesGPC($usersYIM);

    $msn_text = $myts->stripSlashesGPC($usersMSN);

    $location_text = $myts->stripSlashesGPC($usersCompanyLocation);

    $company_text = $myts->stripSlashesGPC($usersCompanyName);
    xoops_load('XoopsCaptcha');

        $xoopsCaptcha = XoopsCaptcha::getInstance();

       if (!$xoopsCaptcha->verify()) {

    redirect_header('sign.php', 3, $xoopsCaptcha->getMessage());    
    exit;
    }

//Insert info to database

    $sqlinsert="INSERT INTO ".$xoopsDB->prefix("myguestbook")." (name,title,message,time,email,url,ip,gender,icq,yim,aim,msn,location,company) VALUES ('".$name_text."','".$title_text."','".$message_textarea."','".$date."','".$email."','".$url_text."','".$ip."','".$gender_select."','".$icq_text."','".$yim_text."','".$aim_text."','".$msn_text."','".$location_text."','".$company_text."')";

    if ( $xoopsModuleConfig['sendmail'] == 1 ) 

    {

    $subject = $xoopsConfig['sitename']." - "._NAR_NEWMESSAGE;

    $xoopsMailer =& xoops_getMailer();

    $xoopsMailer->useMail();

    $xoopsMailer->setToEmails($xoopsConfig['adminmail']);

    $xoopsMailer->setFromEmail($email);

    $xoopsMailer->setFromName($xoopsConfig['sitename']);

    $xoopsMailer->setSubject($subject, "-", $conf_subject);

    $xoopsMailer->setBody($message_textarea);

    $xoopsMailer->send();

    }

    if ( !$result = $xoopsDB->query($sqlinsert) ) 

            {

                echo _NAR_ERRORINSERT;

            }

                    redirect_header("index.php",2,_NAR_RECEIVED);

    exit();

}

include_once XOOPS_ROOT_PATH.'/footer.php';

?>
7
ipwgc
Re: Please help me with MyGuestbook

  • 2011/12/3 5:30

  • ipwgc

  • Quite a regular

  • Posts: 216

  • Since: 2005/8/13


Hi Roby73
It working, it working
yes, you dit it.
Is true the module is very old, and have much deprecated functions,
Question: How I solve the deprecated problems?

I add in the index.php the facebook icon, and the twiter icon and it working see it here TO SEE THE WORKING MODULE CLICK HERE

1. The only problem I gave, is the field of the facebook or ICQ field is to small,
I need a big field in the sql database.

2. it is necessary to fix the IP icon, so identifies the IP as text.
you can help to do that?

NEAR LINE 138
Quote:
if ($array_total_entry[$i]['icq'] !=""){
$entry[$i]['icq'] = ""._NAR_ICQ."";
}

if ($array_total_entry[$i]['yim'] !=""){
$entry[$i]['yim'] = ""._NAR_YIM."";
}
if ($array_total_entry[$i]['aim'] !=""){
$entry[$i]['aim'] = ""._NAR_AIM."";
}
if ($array_total_entry[$i]['msn'] !=""){
$entry[$i]['msn'] = ""._NAR_MSN."";
}
if ($xoopsUser && $xoopsUser->isAdmin($xoopsModule->mid())) {
$entry[$i]['admin_option'] = "

".$array_total_entry[$i]["ip"]." "._NAR_EDIT." "._NAR_DELETEPOST."

";
}


8
Roby73
Re: Please help me with MyGuestbook

  • 2011/12/4 1:14

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


Hi, to upgrade the module removing the deprecated functions,watching the code, is easy.

You have modified field icq to facebook, default characters to field icq are 15.
You must modify this value in your database.

In my local copy, number ip don't saved in database.
I modify the file sign.php line 95:

$ip=$GLOBALS['REMOTE_ADDR'];


to

$ip=$_SERVER['REMOTE_ADDR'];


and to display ip in icon server you must modify "alt" to "title" in tag img...

change your code at line 151 (index.php) with:

if ($xoopsUser && $xoopsUser->isAdmin($xoopsModule->mid())) {

        $entry[$i]['admin_option']  = ".$array_total_entry[$i]["id"]."'> .$array_total_entry[$i]["id"]."'> 

";

    }


if you want view directly the number ip without icon server, change with:

if ($xoopsUser && $xoopsUser->isAdmin($xoopsModule->mid())) {

        $entry[$i]['admin_option']  = "".$array_total_entry[$i]["ip"].".$array_total_entry[$i]["id"]."'> .$array_total_entry[$i]["id"]."'> 

";

    }

9
Roby73
Re: Please help me with MyGuestbook

  • 2011/12/4 1:23

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


I removed some deprecated functions.
Please test it in local http://metalslug.altervista.org/myguestbook.zip
10
ipwgc
Re: Please help me with MyGuestbook

  • 2011/12/5 22:51

  • ipwgc

  • Quite a regular

  • Posts: 216

  • Since: 2005/8/13


HI, rody
This is what I doing on this last version,
I desire to continue update this module and go up to the version 2.0
well, in order to go up to other version I make this changes,
1. I add the facebook field
2. I add the twitter field
3. I add a block
4. I add a user menu
5. I change the French logo, for a view English logo viewguestbook.gif
6. I add a sing logo singguestbook.gif
7. I add facebook images icon
8. I add twitter images icon
10. I change the gender_female.gif
11. I change the gender_male.gif
12. I change the email.gif
13. I translate from English to Spanish

If you want to check and test download from here
DOWNLOAD HERE

(1) 2 3 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

387 user(s) are online (273 user(s) are browsing Support Forums)

Members: 0

Guests: 387

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits