Would anyone be able to explain why several XOOPS core class files have been edited with a different way to associate to the Database class and connection?

In the newest core 2.3.3 the database connection is now defined as:

$this->db = $GLOBALS['xoopsDB'];

It used to be:

$this->db =& Database::getInstance();

I've read somewhere it's better security wise to avoid $GLOBALS. Is this at all a concern in the new XOOPS core?

The correct call to the database should be the following:



As far as I am concerned, all $GLOBALS calls should be removed the core and people should be made aware of the correct methods of accessing class instances etc.

Catz