XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. Xoops Development / 
  3. Xoops Bug Reports 
  4.  / I found some bugs in xoopssecurity class
Register
1
zoro_tong
I found some bugs in xoopssecurity class

  • 2005/7/14 13:10

  • zoro_tong

  • Just popping in

  • Posts: 17

  • Since: 2004/12/1


line 96 :
$token = ($token === false) ? @$_REQUEST['XOOPS_TOKEN_REQUEST'] : $token;
should change to
$token = ($token == false) ? @$_REQUEST['XOOPS_TOKEN_REQUEST'] : $token;

line 104 :
if ($token === md5($token_data[$i]['id'].$_SERVER['HTTP_USER_AGENT'].XOOPS_DB_PREFIX)) {
should change to
if ($token == md5($token_data[$i]['id'].$_SERVER['HTTP_USER_AGENT'].XOOPS_DB_PREFIX)) {
2
Mithrandir
Re: I found some bugs in xoopssecurity class

why?
"When you can flatten entire cities at a whim, a tendency towards quiet reflection and seeing-things-from-the-other-fellow's-point-of-view is seldom necessary."

Cusix Software
3
zoro_tong
Re: I found some bugs in xoopssecurity class

  • 2005/7/14 15:13

  • zoro_tong

  • Just popping in

  • Posts: 17

  • Since: 2004/12/1


Quote:

Mithrandir wrote:
why?

sorry I don't know that === has the same meaning with ==.
but I found a problem if you uses === in file edituser.php before. Please look at this thread bellow :
https://xoops.org/modules/newbb/viewtopic.php?topic_id=35519&forum=1&post_id=164380#forumpost164380

So when I look at xoopssecurity class , I found this and I think it is a typo miss.But I have just test === and I learn that === has the same meaning with ==.
So I am sorry for my mistake.
4
McNaz
Re: I found some bugs in xoopssecurity class

  • 2005/7/14 16:48

  • McNaz

  • Just can't stay away

  • Posts: 574

  • Since: 2003/4/21


Quote:
test === and I learn that === has the same meaning with ==.


I dont think == is the same as ===

AFAIK :

== : equals to
=== : identical to

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

1020 user(s) are online (60 user(s) are browsing Support Forums)

Members: 0

Guests: 1020

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Jul 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits