91
Mamba
Re: Newbb 4.3
  • 2012/7/14 7:19

  • Mamba

  • Moderator

  • Posts: 11253

  • Since: 2004/4/23


Quote:
Mamba that line is not the correct one to touch.

Of course, not!

It was the location to find the lines below, where he could change them.

BTW - you suggestion to change the hard-coded lines to "options" is a good one.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

92
irmtfan
Re: Newbb 4.3
  • 2012/7/14 7:54

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Mamba, Thank you for the clarification on that line you suggested.

Quote:

BTW - you suggestion to change the hard-coded lines to "options" is a good one.

They are not genuine codes.(Im not a coder but a very good copier :wow:)
I just copy/paste them from include/form.post.php that is used for the main editor in reply.php

I think developer just need to unify these 2 editors in reply.php and viewtopic.php (quick reply)



93
Anonymous
Re: Newbb 4.3
  • 2012/7/14 11:11

  • Anonymous

  • Posts: 0

  • Since:


Thanks Mamba and Irmtfan. I agree with the idea of making these hard coding to options.

I also would like to have the option to choose both editors myself (fast and normal reply). The fast one now is xoopseditor but I would like it to be the plain text one, it's the fast reply option so why bother users with all those editor options?

94
Anonymous
Re: Newbb 4.3
  • 2012/7/14 12:29

  • Anonymous

  • Posts: 0

  • Since:


Another issue I have is with topic type. I made a few, set permissions to use and applied topic types to forums. When editing a post I can choose the topic type but after submitting the post the topic type does not stick to the post. When re-editing the post the topic type dropdown shows "none".

Administering the topic types is also confusing, where can I check what topic types are applied to a given forum?

95
Anonymous
Re: Newbb 4.3
  • 2012/7/14 16:48

  • Anonymous

  • Posts: 0

  • Since:


I have two feature requests:

Moderation management works well but when suspending a user you can only suspend him/her from the (sub)forum where you choose moderation management. Why not suspend a user from all forums? At least I would like an option added to do so.

phpBB has a nice pm button at the bottom of every post. When pressed a pm to the given user is opened, with the post text quoted and a link to the forumpost already filled in. I like this, could it be added to newbb?

96
irmtfan
Re: Newbb 4.3
  • 2012/7/15 5:04

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


templates hard-codes issues:
1- in newbb_thread.html
<div class="comUserStat" align="left">

Should be changed to
<div class="comUserStat">


Quote:

I also would like to have the option to choose both editors myself (fast and normal reply). The fast one now is xoopseditor but I would like it to be the plain text one, it's the fast reply option so why bother users with all those editor options?

You are totally right and this is what a customer needs.
Alfred promise to move all configurations to the database in the newer newbb versions. but at this time you can add an option for quick reply editor very easy in 2 steps like below:

1- newbb/include/plugin.php add this after default editor:
// Set the default editor for quick reply
$customConfig["editor_quick_default"] = "textarea";


2- in newbb/viewtopic.php change the editor
$quickform = ( !empty($xoopsModuleConfig["editor_quick_default"]) ) ? $xoopsModuleConfig["editor_quick_default"] : "textarea";


Quote:

phpBB has a nice pm button at the bottom of every post. When pressed a pm to the given user is opened, with the post text quoted and a link to the forumpost already filled in. I like this, could it be added to newbb?

IMO it can be implemented very easy just by altering the current templates.
A very good feature i really like it.

About your issue with topic type i can not tell anything i didnt have time for test it until now.

Quote:

Why not suspend a user from all forums? At least I would like an option added to do so.

I think this option is just useful for the specific forum moderator that have very limited admin access. you as the website webmaster can ban that user via system module. (eg: ban IP in protector, change the group to "banned group" , ...)


Mamba:
it seems Alfred is not around. could you implement some final solutions in the svn? or you prefer to wait more for the developer response?


edit:

Quote:

@ Alfred:
You removed the imageset feature. IMO it is not good for localization but i should navigate more through newbb 4.3 to say my final view point.


I just found that phppp (DJ) did a fabulous work for localization in newbb.
this change in localization is really fantastic. I wish other module developers can follow this way.
you can set images for your needs just via "themes" folder.

for enabling on all themes:

themes/default/modules/newbb/images/icon


themes/default/modules/newbb/images/language/YOUR_LANG

also you can change images for each theme:

themes/YOUR_THEME/modules/newbb/images/icon


themes/YOUR_THEME/modules/newbb/images/language/YOUR_LANG

97
irmtfan
Re: Newbb 4.3
  • 2012/7/15 8:08

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Another hard-code:
- in newbb/header.php line 73 there is an style.css added after all other css
<link rel="stylesheet" type="text/css" href="'.XOOPS_URL.'/modules/'.$xoopsModule->getVar("dirname").'/templates/style.css" />


It should be moved to the local folder and user defined theme for full localization:

themes/YOUR_THEME/modules/newbb/images/language/YOUR_LANG/newbb.css


a solution would be below (Warning: i never test it)
global $xoopsConfig;
$language$xoopsConfig['language'];
$icon_handler newbb_getIconHandler();
$style_path$icon_handler->getPath("language/{$language}"$xoopsModule->getVar("dirname"), "language/english");


then change like this:
<link rel="stylesheet" type="text/css" href="'.$style_path.'/newbb.css" />

98
Mamba
Re: Newbb 4.3
  • 2012/7/15 8:20

  • Mamba

  • Moderator

  • Posts: 11253

  • Since: 2004/4/23


Quote:
Mamba:
it seems Alfred is not around. could you implement some final solutions in the svn? or you prefer to wait more for the developer response?

Alfred is around, as he just committed several changes yesterday:

9876
9877

Tip for everybody:

Please subscribe to our SVN Mailing list. You'll be notified about all changes to the SVN (Core, Modules, Languages), so you can see what is happening, and what our developers are doing.

Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

99
irmtfan
Re: Newbb 4.3
  • 2012/7/15 9:01

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Thank you for pointing me to the svn. I regularly checked svn but it seems i forget it now.

There are some changes.
but it seems developer didnt look on this topic for bugs.
Hope Alfred take a look here as well.

100
alfred
Re: Newbb 4.3
  • 2012/7/15 9:21

  • alfred

  • Quite a regular

  • Posts: 249

  • Since: 2005/10/29


Quote:

irmtfan wrote:
Hope Alfred take a look here as well.


Yes, i read this topic and fix bugs

Login

Who's Online

55 user(s) are online (33 user(s) are browsing Support Forums)


Members: 0


Guests: 55


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Aug 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits