31
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 13:01

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


Download the updated pop3.php file here

Now there's one more bug that needs fixing before this can be used in a production site: edit contact book.

I have a small quirk about the revised module; the name of the menu item has been changed to address book, but the search still refers to contact and if you mouseover edit it will also say edit contact. Shouldn't these also be changed for the sake of consistancy?

There is two things I would like to see in this module:
- a progress bar while it updates email. I'm not quite sure how this could be acomplished, maybe if some of the experts here could help
- a admin config option to limit mail box size.

32
flyingtux
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 14:38

  • flyingtux

  • Not too shy to talk

  • Posts: 146

  • Since: 2004/9/6 1


I'll have a look to what you suggested.
I also proposed to try fixing the redirect bug while editing a contact (it's in the changelog, I think).
Concerning the address book thing, I haven't changed it: could it be a wrong thing coming from the original one?
Concerning the progress bar: go to my site and do something to get a redyrect_page... You'll see a customized redyrect_page with a progress bar...
The site url is:
http://www.trashnight.org
I'm saorry but it's in italian...
To get a redyrect you could do, from the main menu:
Articoli/Invia Articolo
The progress bar is a javascript, not related to real time of loading page...
Tonight I'll upload e new, even more fixed version...
Including your suggestions, i hope!
Cheers,
ft

33
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 15:37

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


I fixed the edit bug.
Replace contactbook.php with my version.
Here's the fixed file

34
flyingtux
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 15:42

  • flyingtux

  • Not too shy to talk

  • Posts: 146

  • Since: 2004/9/6 1


Just made some changes and updated the new package to the usual place...
In few words:
-modified the pop3.php file (wasn't able to download the kaotik's one, I worked on the original one suggested from him when he get the module working);
-downgraded the version numbering to 0.8: I believe package is still unstable and we should wait a bit more before a "real" 1.0;
-changed the "Logout" icon;
-updated the readme/changelog file;
-added a bugs file;
-discovered a bug while uninstalling the previous version, the uninstaller is unable to drop tables, cause it search for contacbook and popsettings and not wmfx_contactbook and so on... I believe it could be easily fixed: I'l try to solve this tonight.
So please let's restart from this point: download the latesta package and let's continuing working and giving feedback to each other.
Bye!
ft

35
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 16:08

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


did you try right-clicking on my link and select save as?

36
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 16:18

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


Since your having trouble downloading my files, here's the fix for the edit bug:

contactbook.php
line 97
echo "<tr bgcolor=\"$bgcolor2\"><td align=\"center\"><a href='contactbook.php?op=view&cid=$contactid'><img src='images/view.png' alt=\""._VIEWPROFILE."\" title=\""._VIEWPROFILE."\" border=\"0\" width=\"16\" height=\"12\"></a></td><td align=\"center\"><a href='contactbook?op=edit&cid=$contactid'><img src='images/edit.png' border=\"0\" alt=\""._EDITCONTACT."\" title=\""._EDITCONTACT."\" width=\"16\" height=\"16\"></a></td><td><input type=\"checkbox\" name=\"del[]\" value=\"$contactid\"></td><td>$firstname, $lastname</td><td><a href=\"$esend\">$email</a></td><td>$homephone</td><td>$workphone</td></tr>";

change to:
echo "<tr bgcolor=\"$bgcolor2\"><td align=\"center\"><a href='contactbook.php?op=view&cid=$contactid'><img src='images/view.png' alt=\""._VIEWPROFILE."\" title=\""._VIEWPROFILE."\" border=\"0\" width=\"16\" height=\"12\"></a></td><td align=\"center\"><a href='contactbook.php?op=edit&cid=$contactid'><img src='images/edit.png' border=\"0\" alt=\""._EDITCONTACT."\" title=\""._EDITCONTACT."\" width=\"16\" height=\"16\"></a></td><td><input type=\"checkbox\" name=\"del[]\" value=\"$contactid\"></td><td>$firstname, $lastname</td><td><a href=\"$esend\">$email</a></td><td>$homephone</td><td>$workphone</td></tr>";

37
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 16:37

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


Hi Bassman.
I've been goin through your module. With php debug it crashes with this notice: 'Notice [PHP]: Undefined offset'
Did you also get this?

38
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 17:06

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


PHP was giving me a whole bunch of:
Notice [PHP]: Constant already defined
So I went in and made webmailFX var unique; _PASSWORD I changed to WEBMAILFX_PASSWORD
I basicly did a replace of all variables that were conflicting in PHP.
I did the changes on ver .8 I also fixed the address book bug
here's the corrected files

39
kaotik
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 17:21

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


Cleaned up some more variables.
Changed from WEBMAILFX_ to WFX_ it's more manegable.
Still based on .8

files here

Don't forget to right-click and select save as.

40
flyingtux
Re: Getting the webmail module to work - Here's the file!
  • 2004/9/23 18:11

  • flyingtux

  • Not too shy to talk

  • Posts: 146

  • Since: 2004/9/6 1


Tremendous job guys!!!!
I applied all patches, updated the readme, changelog, etc...
Moved to 0.81.
Gave credits to you guys in xoops_version,php
Made some testing: the first bug which still appears to be there is the unistall one...
What about to try working on different things, so that we can focus in one subject?
Download 0.81 to the usual place!
Thanx a lot to you all!
Bye,
ft

Login

Who's Online

122 user(s) are online (77 user(s) are browsing Support Forums)


Members: 0


Guests: 122


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits