xoops forums

irmtfan

Module Developer
Posted on: 2012/8/28 2:02
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#221

Re: Newbb 4.3

Roby73:
very strange to me.
install another module in your xoops to see if your xoops in sub-directory correctly return the XOOPS_URL
the last irmtfan revision is 10122.
is that newbb a new installation?
do you upload all files include all newbb/templates/images and newbb/templates?
i suggest you to upload the zip or tar.gz file and extract with cpanel to avoid miss uploads.
you should have a more.png and also a new less.png.

Roby73

Friend of XOOPS
Posted on: 2012/8/28 2:22
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#222

Re: Newbb 4.3

i have new installation and only modules newbb
i upload all files creed .

if click with right button on the text and copy the url of the image, the url does not have subdir..


irmtfan

Module Developer
Posted on: 2012/8/28 3:41
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#223

Re: Newbb 4.3

Roby73:
I knew that your only module is newbb and i want you to install another module.
I meant install another module like news to see if XOOPS_URL is not working (or working) in that module too.

Also get a CTRL+F5.

Alfred:
I saw you again implement the imageset feature in 4.4.
the imageset feature is introduced in newbb 3.x and in my first impression to 4.x i thought we miss that feature and we need it again. But now after more playing with 4.3 IMO we dont need that feature anymore because the user(webmaster) can have an imageset for each theme and it is enough.
So IMO that imageset is an outdated feature.


irmtfan

Module Developer
Posted on: 2012/8/28 8:11
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#224

Re: Newbb 4.3

Quote:

If both are sharing the same icons, for example for bookmarks, or for printing, then it's easy to recognize it, and first time users will have no problems finding their way in a new module.

It must be done in the core. then can be implement in modules. see below:

Quote:

So our goal is to have the same standard set of icons provided by Core. User (or theme designer) can provide their individual set of icons)

I see this in newbb then i send the feature request to the core:

customization&localization:module/core images in theme

I repeat:
The above feature is introduced and implemented in newbb but it should be in the core. then we can proceed in modules.
I tried my best in these days to show community and core team what can be achieved with the above method is a full customization of images and ability to have text links.
I rather improve the newbb feature too. and IMO today i improved it to its final level. (unless i receive a good feedback from community)

Quote:

In my personal view, we should use as "default" icons/images, and provide "text buttons" as option, except the typical uses like "Cancel" or "Submit" on forms, etc.

Yeah, defaults are not important IF every webmaster could change the default option easily.

===============================
Today i implement the full customization for text links instead of images.
Now i think it is reached to the highest level.

changelog from alfred rev.10109 (the latest is 10121):
date 2012-08-28
================================================
1improve text link instead of buttons featureAbility to set the display setting for each link in newbb/include/display.php
newbb
/include/plugin.phpnewbb/include/display.phpnewbb/include/functions.render.php

2
add id={$image} for <imghtml tag
newbb
/class/icon.php

date
2012-08-27 2
================================================
1improve text link instead of buttons to only show text buttons whenaalt key is set b)display is not set to true c)only buttons like replyedit
newbb
/include/functions.render.phpnewbb/class/icon.php

2
add alt key for quickreply button and remove one extra space (&nbsp;) and sort reply addpoll newtopic
newbb
/viewtopic.phpnewbb/templates/newbb_viewtopic.html

date
2012-08-27
================================================
1remove icon_path and use newbb_displayImage
newbb
/class/forum.phpnewbb/templates/newbb_index.htmlnewbb/templates/newbb_viewforum_subforum.html

2
remove icon_path and define anonym icon and use newbb_displayImage
newbb
/viewpost.phpnewbb/viewtopic.phpnewbb/include/images.phpnewbb/templates/newbb_thread.html

3
simplyify infobox and add alt and title show/hide definitions and alt key
newbb
/viewtopic.phpnewbb/templates/newbb_thread.htmlnewbb/include/js/newbb_toggle.jsnewbb/language/english/main.php newbb/docs/lang_diff.txt
newbb
/templates/images/language/english/style.css
newbb
/templates/images/icon/less.png

4
a little correctnessdot removed
newbb
/class/user.php

5
feature improvecss3 text buttons introduced and used (DCrussader/irmtfan)
newbb/class/icon.phpnewbb/templates/images/language/english/style.css class="forum_icon" id=$image_name

date
2012-08-26
================================================
1merge with alfred.
newbb/votepolls.phpnewbb/polls.phpnewbb/print.phpnewbb/seo.php

2
bug in getting $op and  typoaddmor -> addmore
newbb
/polls.php

3
better method for getting the customize/localize newbb style.css
newbb
/header.php


download:
http://www.jadoogaran.org/test255/mod ... 09_irmtfan_2012_08_28.zip

SVN:
http://xoops.svn.sourceforge.net/view ... b/branches/irmtfan/newbb/

I changed the default setting for buttons to text links using css3 class to show off this new feature.
Now the default look is like this:
Resized Image
to change the default to images go to newbb/include/display.php and comment those buttons.

Mamba:
I also want to show to the community and to the core team what this priority means:

- server side features (priority 9/10)
- cosmetic features (priority 1/10)

what i was down is a server side feature (php)
the further feature (could be labeled as a cosmetic feature) will be moving all newbb file configs (plugin.php, images.php and now the display.php) to some nice preferences pages in newbb admin. they could be jQuery and could be very nice looking and catch eye features. then webmaster can change the setting just by a click. This is a cosmetic feature.
and
....
cosmetic features are good when the server side feature is done

Roby73

Friend of XOOPS
Posted on: 2012/8/28 22:37
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#225

Re: Newbb 4.3

I downgrade to newbb by alfred ver. 9883 because i have problem with seo rewrite and subdir. In view all new/topics and pagenav in topics, subdir is duplicate.
The show more.png i think is seo rewrite..

Please test all your version in subdirectory. In the root not problem...

The problem seem to be in seo.php (in last versions)

Roby73

Friend of XOOPS
Posted on: 2012/8/29 1:46
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#226

Re: Newbb 4.3

Quote:
by Roby73 on 2012/8/29 0:37:44

I downgrade to newbb by alfred ver. 9883 because i have problem with seo rewrite and subdir. In view all new/topics and pagenav in topics, subdir is duplicate.
The show more.png i think is seo rewrite..

Please test all your version in subdirectory. In the root not problem...

The problem seem to be in seo.php (in last versions)


Sorry, is a error in my installation...

Version of alfred and irmtfan don't have problem with seo...

I have only pronlem with more image.

irmtfan

Module Developer
Posted on: 2012/8/29 3:43
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#227

Re: Newbb 4.3

I never enable SEO in my production websites or even test it.
IMO SEO is a very sensitive feature and i hope our core team implement it in the 2.6.0 with some sophisticated methods.

Quote:

I have only pronlem with more image.

do you have this issue with SEO disable?
IMO if you still have it you should clear all caches in system -> maintenance
Also Xoops can not handle templates correctly. i send a bug about templates to the tracker.
https://sourceforge.net/tracker/?func= ... roup_id=41586&atid=430840

irmtfan

Module Developer
Posted on: 2012/8/30 8:05
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#228

Re: Newbb 4.3

I improved the javascript method for hide/show sections in newbb module:
"user information", "quick reply" and "category plus minus"
I hope it will solve some issues with templates when the xoops core 2.5.5 failed to update the templates correctly. (like Roby73 issue with more.png icon)
Also now it is simplified and more understandable.
It will work in old browsers but some new functionality will not work in IE7 or IE8 but will work on IE9.
eg: textContent changing

changelog from alfred rev.10109 (the latest is 10121):
date 2012-08-30
================================================
1add more and less icons add t_qr_expand.png image and add show see definitions 
newbb
/include/display.phpnewbb/include/images.php
newbb
/templates/images/language/english/t_qr_expand.png
newbb
/language/english/main.phpnewbb/docs/lang_diff.txt

2
improve ToggleBlockCategory js to recognize a IMG tag
newbb
/include/js/newbb_toggle.js

3
change all toggles in newbb to use ToggleBlockCategory - use newbb_displayImage function for all toggles alt and title and text links supported
newbb
/viewtopic.phpnewbb/templates/newbb_viewtopic.htmlnewbb/templates/newbb_thread.html
newbb
/index.phpnewbb/templates/newbb_index.html

4
some hardcodes removed (<small><{$topic_post.post_edit}></small> and signature line
newbb
/templates/newbb_thread.htmlnewbb/templates/images/language/english/style.css

date 2012
-08-28
================================================
1improve text link instead of buttons featureAbility to set the display setting for each link in newbb/include/display.php
newbb
/include/plugin.phpnewbb/include/display.phpnewbb/include/functions.render.php

2
add id={$image} for <imghtml tag
newbb
/class/icon.php

date
2012-08-27 2
================================================
1improve text link instead of buttons to only show text buttons whenaalt key is set b)display is not set to true c)only buttons like replyedit
newbb
/include/functions.render.phpnewbb/class/icon.php

2
add alt key for quickreply button and remove one extra space (&nbsp;) and sort reply addpoll newtopic
newbb
/viewtopic.phpnewbb/templates/newbb_viewtopic.html

date
2012-08-27
================================================
1remove icon_path and use newbb_displayImage
newbb
/class/forum.phpnewbb/templates/newbb_index.htmlnewbb/templates/newbb_viewforum_subforum.html

2
remove icon_path and define anonym icon and use newbb_displayImage
newbb
/viewpost.phpnewbb/viewtopic.phpnewbb/include/images.phpnewbb/templates/newbb_thread.html

3
simplyify infobox and add alt and title show/hide definitions and alt key
newbb
/viewtopic.phpnewbb/templates/newbb_thread.htmlnewbb/include/js/newbb_toggle.jsnewbb/language/english/main.php newbb/docs/lang_diff.txt
newbb
/templates/images/language/english/style.css
newbb
/templates/images/icon/less.png

4
a little correctnessdot removed
newbb
/class/user.php

5
feature improvecss3 text buttons introduced and used (DCrussader/irmtfan)
newbb/class/icon.phpnewbb/templates/images/language/english/style.css class="forum_icon" id=$image_name

date
2012-08-26
================================================
1merge with alfred.
newbb/votepolls.phpnewbb/polls.phpnewbb/print.phpnewbb/seo.php

2
bug in getting $op and  typoaddmor -> addmore
newbb
/polls.php

3
better method for getting the customize/localize newbb style.css
newbb
/header.php


download:
http://www.jadoogaran.org/test255/mod ... 09_irmtfan_2012_08_30.zip

SVN:
http://xoops.svn.sourceforge.net/view ... b/branches/irmtfan/newbb/

To everybody:
Now we need more feedback from users to insure that this newbb is stable. please test.

alfred

Quite a regular
Posted on: 2012/8/30 15:34
alfred
alfred (Show more)
Quite a regular
Posts: 249
Since: 2005/10/29
#229

Re: Newbb 4.3

Quote:

irmtfan wrote:
To everybody:
Now we need more feedback from users to insure that this newbb is stable. please test.


One may not always fit what new. Then there is also what.
I leave here and become the newBB simple-xoops.de supports.

Alfred

Roby73

Friend of XOOPS
Posted on: 2012/8/30 23:04
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#230

Re: Newbb 4.3

sorry alfred.

in my pubblic site i use rev 9883 of the SF.

The rev 75 is better and safe to use to it 9883, or wait other release?
I am interested to use only version of the developer.