131
irmtfan
Re: Newbb 4.3
  • 2012/7/30 10:00

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


I prepare a new version that all reported bugs has been fixed and one new feature added.
IMO it can be the final newbb 4.3 version.
I finally could find the root of "ranks" problem and solved it.
Now ranks is not hardcoded anymore.

The whole changelog from latest SVN rev.9883:
Changelog from rev.9883
date
2012-07-30
================================================
1bug fixedit not displayed when the reason is not filled (irmtfan)
2bug fixonly the last edit is recorded. (irmtfan/alfred)
in newbb/class/post.php
3
bug fix'noapprove' permission incorrectly recorded in database. (irmtfan)
in newbb/class/permission.php
4
bug fixload user ranks has been hardcodedit works in old/upgraded websites but not works in new installed websitesnew getting rank introduced. (black_beard/irmtfan)
in newbb/class/user.phpnewbb/templates/newbb_thread.html
5
minor bug fixmysql 5.1 was incorrectly needed (irmtfan)
in newbb/xoops_version.php
6
hardcodesome style.css color hardcodes has been removed. (irmtfan)
in newbb/templates/style.css
7
feature addedtext links instead of buttons. (deka87/irmtfan)
in newbb/class/icon.php newbb/include/functions.render.php newbb/include/plugin.php

download:http://www.jadoogaran.org/test255/modules/newbb43_rev9883_irmtfan.zip

Cesag:
I dont have any issue with attachments. so i dont know whether your problems with attachments is solved or not?.

It just contain english and persian languages.

132
Mamba
Re: Newbb 4.3
  • 2012/7/30 11:00

  • Mamba

  • Moderator

  • Posts: 11367

  • Since: 2004/4/23


Quote:
feature added: text links instead of buttons.

Is it optional, or hard-coded?
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

133
Yurdal
Re: Newbb 4.3
  • 2012/7/30 16:06

  • Yurdal

  • Friend of XOOPS

  • Posts: 386

  • Since: 2005/3/27


i get confused by who is working on the 4.3 Newbb !
Is it Alfred or is it Irmtfan ?

Please try to have one link to the latest version , as i see the link Irmtfan give is different than the Alfred ´s ?

134
alfred
Re: Newbb 4.3
  • 2012/7/30 17:18

  • alfred

  • Quite a regular

  • Posts: 249

  • Since: 2005/10/29


It does not matter if multiple branches are created.
I will now update only to simple-xoops.de

Thank you for your attention

Alfred

135
Mamba
Re: Newbb 4.3
  • 2012/7/30 18:33

  • Mamba

  • Moderator

  • Posts: 11367

  • Since: 2004/4/23


Quote:
It does not matter if multiple branches are created.
I will now update only to simple-xoops.de

Thanks Alfred.

I believe, we still have an issue with preview in DHTML, where the window grows outside of screen.

And with setting the permissions for individual groups.

I'll be testing tonight the attachment issue reported by Cesag.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

136
Anonymous
Re: Newbb 4.3
  • 2012/7/30 19:05

  • Anonymous

  • Posts: 0

  • Since:


Quote:
I'll be testing tonight the attachment issue reported by Cesag.


I am curious if you can confirm the attachment issue I have Michael. On nlxoops (see first post) anonymous users can't download attachments, and there seems now way to change this. In permissions I can only allow groups to upload an attachment, there is no permission for downloading (newbb is upgraded a few weeks ago, so maybe this issue is solved yet?).

And speaking about windows growing out of the screen. At nlxoops this sometimes happens with quoted code.

137
irmtfan
Re: Newbb 4.3
  • 2012/7/31 2:22

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Maybe you misunderstood me.
I didnt want to create a new branch and i am not a developer to continue developing newbb module.
The developer of this newbb module is Alfred and the official place for download is the link in SVN.
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsModules/newbb/branches/alfred/newbb/
but if you download the above then you have to go back to this topic and find the reported bugsw and their patches one by one and implement them. And at least 2 bugs are really serious because they affect your database.

therefore i just make it easy for you.
I download the latest SVN rev.9883 and implement all bug fixes and one new feature that Its basics has been available in newbb module (display buttons=true/false), based on the xoops.org and my website reports.
You cab find all patches done by me by searching "irmtfan" in the codes.

Alfred:
I hope you update the SVN and implement the reported bugs at the sonest available time.
It is my appreciate if you could see my codes.

Mamba:
1- the default is buttons as always and one can change it to text links in newbb/include/plugin.php

2-
Quote:

we still have an issue with preview in DHTML, where the window grows outside of screen.

And with setting the permissions for individual groups.

there are one serious and dangerous bug with permissions which my members in jadoogaran.org reported to me and is solved.

could you show me a picture from your preview issue with DHMTL?


filpse:
Quote:

On nlxoops (see first post) anonymous users can't download attachments, and there seems now way to change this. In permissions

the setting for download is in newbb preferences that said:
- only members allowed to download: yes(default)/no
set it to no
IMO the default can be changed to no.

138
Mamba
Re: Newbb 4.3
  • 2012/7/31 3:13

  • Mamba

  • Moderator

  • Posts: 11367

  • Since: 2004/4/23


Quote:
I didnt want to create a new branch and i am not a developer to continue developing newbb module.
The developer of this newbb module is Alfred and the official place for download is the link in SVN.

That's not a problem, at least we can see in SVN what files have been changed.

Quote:
could you show me a picture from your preview issue with DHMTL?

The normal view is like this, with the text box ending where the arrow is:
Resized Image
When I click on the Preview, the text box and the view shift partially out of the view :

Resized Image
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

139
irmtfan
Re: Newbb 4.3
  • 2012/7/31 4:54

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Mamba:
I can not reproduce this preview issue. but this kind of errors are very very hard to reproduce because there are themes, templates, js files, etc that can affect the interface of a website.
Also xoops.org is very old and may use many customized methods.
You said xoops.org have another issue with showing "text links" instead of dispalying buttons which is very strange and im nearly sure you have a customized newbb template in one of the below paths.
1- in xoops.org/themes/default/modules/newbb
2- in xoops.org/themes/wox/modules/newbb

please look at the above paths.

About the necessity of a new branch for each person to review changes of the codes im totally and completely agree with you but please pay attention that it may be easier and convenient for some experienced users like you but i fear it will confuse some simple end users like Yurdal that dont know what branch is official, they are already confused by a download link from my website. after creating a new branch they should investigate in more branches and struggle more to find the better one. so the issue will raise again. also more importantly i fear they think im a developer and can add features and develop modules for xoops!

Anyway, i recognize all touched files in changelog and recognize all patches with the word "irmtfan" and when you download you can find them easily.



140
irmtfan
Re: Newbb 4.3
  • 2012/8/1 10:57

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


a prepared a new version.
In this version i tried to remove all hardcoded css definitions in templates.
maybe still there are some hardcodes but it is now clean.
Also i implement the full customization for newbb/templates/style.css which was hard-coded in the past versions.

changelog from the last official rev.9883:
Changelog from rev.9883
date
2012-08-01
================================================
1localizationinput date localized (for other date systems like hegiraby replacing strtotime by XoopsLocal::strtotime
in newbb
/polls.php

2
customization&localizationnewbb style.css is fully localized and customized and is not hard-coded anymore.
in newbb/header.php
file changes

-- 
deleted newbb/templates/style.css
-- added   newbb/templates/images/language/english/style.css
-- added   newbb/templates/images/language/persian/style.css
priorities
:
if 
exist in themes/YOUR_THEME/modules/newbb/images/language/YOUR_LANG/style.css take it
else if exist in themes/default/modules/newbb/images/language/YOUR_LANG/style.css take it
else if exist in modules/newbb/templates/images/language/YOUR_LANG/style.css take it
else if exist in modules/newbb/templates/images/language/english/style.css take it
else if exist in modules/newbb/templates/style.css take it (for backward compatibility)

3many hardcodes in newbb/templates and style.css has been removed
 
date
2012-07-30
================================================
1bug fixedit not displayed when the reason is not filled (irmtfan)
2bug fixonly the last edit is recorded. (irmtfan/alfred)
in newbb/class/post.php
3
bug fix'noapprove' permission incorrectly recorded in database. (irmtfan)
in newbb/class/permission.php
4
bug fixload user ranks has been hardcodedit works in old/upgraded websites but not works in new installed websitesnew getting rank introduced. (black_beard/irmtfan)
in newbb/class/user.phpnewbb/templates/newbb_thread.html
5
minor bug fixmysql 5.1 was incorrectly needed (irmtfan)
in newbb/xoops_version.php
6
hardcodesome style.css color hardcodes has been removed. (irmtfan)
in newbb/templates/style.css
7
feature addedtext links instead of buttons. (deka87/irmtfan)
in newbb/class/icon.php newbb/include/functions.render.php newbb/include/plugin.php


download:http://www.jadoogaran.org/test255/modules/newbb43_rev9883_irmtfan_2012_08_01.zip

Mamba:
I saw you add a new branch in svn but it seems i dont have the grant access for write?


Login

Who's Online

153 user(s) are online (131 user(s) are browsing Support Forums)


Members: 0


Guests: 153


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: May 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits