101
irmtfan
Re: Newbb 4.3
  • 2012/7/15 10:26

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Thank you very much Alfred.
I should try your new revision in my test website, then i can implement it in the production website.

Maybe there are still some minor issues but i think this module deserve a final version bag.


Also It would be good if you change all image related path hardcoded in some files like this: "modules/newbb/templates/images/"

i just can see these 2 files:

../newbb/viewpost.php(178): $xoopsTpl->assign("icon_path"XOOPS_URL."/modules/".$xoopsModule->getVar("dirname""n")."/templates/images/icon/");
../
newbb/viewtopic.php(142): $xoopsTpl->assign("icon_path"XOOPS_URL."/modules/".$xoopsModule->getVar("dirname""n")."/templates/images/icon/");

then we can change the templates related.
../newbb/templates/newbb_index.html(110):                                         <{$forum.forum_lastpost_subject}>&nbsp;&nbsp;<img src="<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/<{$forum.forum_lastpost_icon}>" alt="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" title="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" />
../
newbb/templates/newbb_index.html(158):                                                 <{$subforum.forum_lastpost_subject}>&nbsp;&nbsp;<img src="<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/<{$subforum.forum_lastpost_icon}>" alt="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" title="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" />
../
newbb/templates/newbb_index.html(205):                                         <{$forum.forum_lastpost_subject}>&nbsp;&nbsp;<img src="<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/<{$forum.forum_lastpost_icon}>" alt="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" title="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" />
../
newbb/templates/newbb_index.html(256):                                         <{$forum.forum_lastpost_subject}>&nbsp;&nbsp;<img src="<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/<{$forum.forum_lastpost_icon}>" alt="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" title="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" />
../
newbb/templates/newbb_thread.html(25):                     <br /><img class="comUserImg" src="<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/anonym.png" alt="" />
../
newbb/templates/newbb_thread.html(30):                         <img style="padding:2px;" onclick="ToggleBlockCategory('<{$topic_post.post_id}>', this, '<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/more.png', '<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/more.png')" src="<{$icon_path}>/more.png" alt="Benutzerinformationen" title="Benutzerinformationen" />
../
newbb/templates/newbb_viewforum_subforum.html(29):             <{$sforum.forum_lastpost_subject}>&nbsp;&nbsp;<img src="<{$xoops_url}>/modules/<{$xoops_dirname}>/templates/images/icon/<{$sforum.forum_lastpost_icon}>" alt="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" title="<{$smarty.const._MD_NEWBB_GOTOLASTPOST}>" />


eg like this:
../newbb/templates/newbb_thread.html(25):                     <br /><img class="comUserImg" src="<{$icon_path}>/anonym.png" alt="" />



I know that the above needs a hard work

102
Anonymous
Re: Newbb 4.3
  • 2012/7/15 18:55

  • Anonymous

  • Posts: 0

  • Since:


There is something weird about the fast reply button. It is always there when fast reply is enabled, when clicking it the fast reply screen disappears. What's the use of this button??? It could be called something like "remove the fast reply editor". But who really wants to be able to do that?

103
Mamba
Re: Newbb 4.3
  • 2012/7/15 20:44

  • Mamba

  • Moderator

  • Posts: 11256

  • Since: 2004/4/23


Quote:
There is something weird about the fast reply button. It is always there when fast reply is enabled, when clicking it the fast reply screen disappears.

It should be the other way around: when you click on it, then the fast reply screen should appear.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

104
Roby73
Re: Newbb 4.3
  • 2012/7/16 0:21

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


In the last revision i have this warning in configuration check.. mysql minimum version required: 5.1 (your version is 5.0.92-enterprise-gpl-log)

my php server is 5.3.13.

There are problem?

105
irmtfan
Re: Newbb 4.3
  • 2012/7/16 3:35

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Quote:

Roby73 wrote:
In the last revision i have this warning in configuration check.. mysql minimum version required: 5.1 (your version is 5.0.92-enterprise-gpl-log)

Yes i noticed it yesterday. It seems Alfred recent changes on database of newbb 4.3 needs this higher version of mysql.
(I also recommend to change the version of newbb to 4.4 because this is a big change IMO)

Xoops 2.5.5 just needs mysql 5.0
Anyway i dont know if my other modules are compatible with mysql 5.1 or not.
we must study about that first then we can request from our HSP to upgrade the mysql version of our servers

106
Roby73
Re: Newbb 4.3
  • 2012/7/16 21:34

  • Roby73

  • Friend of XOOPS

  • Posts: 262

  • Since: 2011/6/15


thanks irmtfan.

Newbb work very well, i have not found error.

What problems might occur using 5.0.92 version?

107
irmtfan
Re: Newbb 4.3
  • 2012/7/17 6:44

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Quote:


What problems might occur using 5.0.92 version?

I dont know. Alfred will come and answer us. But Im sure that the module will not work on 5.0.92 properly and completely. there is a reason for it.

Alfred:
I think this functional bug still is not solved in newbb/class/post.php around line 245.
Quote:

- It does not show the edit record when you dont write the edit reason message.
You know the edit reason is Optional so it should display the record even when there is not a reason.


https://xoops.org/modules/newbb/viewto ... id=347754#forumpost347754

108
alfred
Re: Newbb 4.3
  • 2012/7/17 16:46

  • alfred

  • Quite a regular

  • Posts: 249

  • Since: 2005/10/29


Quote:

Roby73 wrote:
In the last revision i have this warning in configuration check.. mysql minimum version required: 5.1 (your version is 5.0.92-enterprise-gpl-log)
my php server is 5.3.13.
There are problem?


Sorry, mysql 5.0 is enough

109
unspoken
Re: Newbb 4.3
  • 2012/7/18 2:26

  • unspoken

  • Just popping in

  • Posts: 23

  • Since: 2008/8/25


i use newbb 4.03 but i want to remove pdf and print butons in the posts because google webmaster tools givin a lot of scanning errors.
etc:
forum/makepdf.php?type=post&pageid=0&scale=0.66&post_id=62962
modules/newbb/print.php?form=2&forum=23&topic_id=3652&post_id=54665

how can i fix that?

110
irmtfan
Re: Newbb 4.3
  • 2012/7/18 4:32

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


unspoken:
Please upgrade to xoops 2.5.5 and newbb 4.3 latest svn.
http://xoops.svn.sourceforge.net/view ... bb/branches/alfred/newbb/

unfortunately, xoops still dont implement "tcpdf" which is previously included in "/Frameworks/tcpdf" by phppp (DJ).
It is needed for newbb pdf maker function to work.
as for print, there is no option in the admin to remove it.
in newbb 4.3 you can remove it from class/post.php around line 483.

Alfred:
It is good to add an option in newbb preferences to disable/enable "print" and "pdf" functions.



Login

Who's Online

58 user(s) are online (31 user(s) are browsing Support Forums)


Members: 0


Guests: 58


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Aug 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits