1
Burning
Sliders module - Bug report
  • 2010/6/14 19:44

  • Burning

  • Theme Designer

  • Posts: 1163

  • Since: 2006/8/22


hi'

• "Incorrect" tag : those files start with <? tag instead of <?php

slider/admin/index.php
slider/admin/sliders_admin.php
slider/admin/slides_admin.php
slider/blocks/slider_block.php
slider/class/sliders.php
slider/includes/gd_functions.php
slider/index.php
slider/language/.../main.php
slider/language/.../modinfo.php


• No form displayed to upload images

Debug mode has nothing to declare in Back office. There is 1 error found on public side (Slider page and page where the block is displayed) :
Quote:
Message(s): Undefined variable: return_array dans le fichier /modules/slider/class/sliders.php - line 122



----

Environment :
- local
- PHP 5.2.11
- MySQL 5.1.36
- XOOPS 2.4.4
Still learning CSS and... english

2
Burning
Re: Sliders module - Bug report
  • 2010/6/14 20:14

  • Burning

  • Theme Designer

  • Posts: 1163

  • Since: 2006/8/22


... me again

It seems there is some trouble with /sliders/language/.../main.php

Original code :
Quote:

<?
//admin header

... I can see
• Defines (example : _AM_SLIDER_INDEX_TAB1)
• and blank spaces for icons (Admin, Edit, Delete, Set active)

If I add :
Quote:

<?php
//admin header

... I can see :
• translations :)
• but no more blank spaces for icons, nothing at all is displayed in last column


(that's the same with PHP5.2 and PHP5.3)
Still learning CSS and... english

3
kerkyra
Re: Sliders module - Bug report
  • 2010/6/14 22:25

  • kerkyra

  • Just can't stay away

  • Posts: 553

  • Since: 2005/2/14


i updated the module. Probably your server doesnt support the short php tags??

I cant figure out why you dont get image upload box! no errors at all? any debug info?

4
insraq
Re: Sliders module - Bug report
  • 2010/6/15 7:04

  • insraq

  • Quite a regular

  • Posts: 266

  • Since: 2006/1/24


I can see nothing one the Action column and I've found the problem.
In templates/admin/slider_admin_index.html about Line 25, you write:

<img src="/modules/slider/images/slides.png" />


Actually it should be
<img src="<{$xoops_url}>/modules/slider/images/slides.png" />


Same for other images.
hi,insraq!:http://insraq.me
To contact me, please fill in this form:http://insraq.me/compose/
(Please do not use PM, as I might not check my inbox for months)

5
Runeher
Re: Sliders module - Bug report
  • 2010/6/15 7:07

  • Runeher

  • Module Developer

  • Posts: 825

  • Since: 2008/1/24


actually it should be:

<img src="<{$xoops_url}>/modules/slider/images/slides.png" alt="" />
... :)

6
kris_fr
Re: Sliders module - Bug report
  • 2010/6/15 8:15

  • kris_fr

  • Theme Designer

  • Posts: 1009

  • Since: 2005/12/31


in template :
<img src="<{xoAppUrl modules/slider/images/slides.png}>" alt="" />

or
<img src="<{xoImgUrl images/slides.png}>" alt="" />

7
Burning
Re: Sliders module - Bug report
  • 2010/6/15 10:16

  • Burning

  • Theme Designer

  • Posts: 1163

  • Since: 2006/8/22


hi'

Thanks :)


If someone encounters the same concern with short <? php tag (I use WampServer =):


1 • Replace <? by <?php in :

slider/admin/index.php
slider/admin/sliders_admin.php
slider/admin/slides_admin.php
slider/blocks/slider_block.php
slider/class/sliders.php
slider/includes/gd_functions.php
slider/index.php
slider/language/.../main.php
slider/language/.../modinfo.php


2 • modify icons path in :

- active.gif
slider/templates/admin/slider_admin_index.html - line 35

- inactive.gif
slider/templates/admin/slider_admin_index.html - line 38

- delete.gif
slider/templates/admin/slider_admin_index.html - line 31
slider/templates/admin/slides_admin_index.html - line 32

- edit.gif
slider/templates/admin/slider_admin_index.html - line 28
slider/templates/admin/slides_admin_index.html - line 29

- slides.png
slider/templates/admin/slider_admin_index.html - line 25


---

Now I'm able to manage diaporamas, add slides, ... all works fine in back office (however I believe a warning about GD library would be useful).

But I can not uninstall / install one more time :
Quote:
Table 'xxx_slider_content' already exists




Environment :
- XOOPS 2.4.5 Release Candidate
- PHP Version 5.2.13
- mySQL Version 5.0.51a-24-log
Still learning CSS and... english

8
kerkyra
Re: Sliders module - Bug report
  • 2010/6/15 11:44

  • kerkyra

  • Just can't stay away

  • Posts: 553

  • Since: 2005/2/14


the link is updated with the fixes and the instal/uninstall issue fixed as well. The gd library is only used if it is there, otherwise its not.
www.guidemap.gr - Beta is out...

9
Burning
Re: Sliders module - Bug report
  • 2010/6/15 11:51

  • Burning

  • Theme Designer

  • Posts: 1163

  • Since: 2006/8/22


Many thanks !

I will test new version on a clean xoops 2.4.5RC2 soon and post french translation here.
Still learning CSS and... english

10
Mamba
Re: Sliders module - Bug report
  • 2010/6/16 9:48

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


It looks nice!

Couple of things that didn't work for me (WAMP, XOOPS 2.4.5 RC3), and I had to fix them:

1) the image was not visible in the edit form:

admin/slides_admin.hp

Line 199
$image = new XoopsFormLabel('''<img src="../uploads/'.$mysliders[0]['image'].'" alt="" width="100" />');


2) The arrows were not visible, and I had to add <{$xoops_url}>:

/templates/slider_index.html

Line 31

leftBtn '<{$xoops_url}>/modules/slider/images/cs_leftImg.png',
rightBtn '<{$xoops_url}>/modules/slider/images/cs_rightImg.png',


/templates/blocks/slider_block_index.html

line 28
leftBtn '<{$xoops_url}>/modules/slider/images/cs_leftImg.png',
rightBtn '<{$xoops_url}>/modules/slider/images/cs_rightImg.png',,


Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Login

Who's Online

154 user(s) are online (105 user(s) are browsing Support Forums)


Members: 0


Guests: 154


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Mar 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits