Posted on: 2006/4/28 7:41
Feedback notes on QA sheet V2.0
Logo: I'm not sure that insisting on everyone using the same logo design is right. Devs should be allowed a bit of creative license on this to 'brand' their creations. Perhaps better would be to have guidelines on size and also publish guidelines and template for creating a 'classic' logo.
Header Comment Block: 1/ How do you generate the first line contained between $id and $ 2/ Are you suggesting that every file carries the XOOPS copyright info? 3/ Shouldn't every file also carry the developers own module copyright? And if so then other license variations should be allowed. For instance I like to use the GNU Library GPL for some of my mods as they do in fact behave as library software.
SEO: As previously commented, use XBS MetaTags module by including metatags_info.php file in module root directory.
B9 - No hard code variable: Language dependent variables/constants should be language files (main, modinfo, admin etc). However there are some constant declarations that occur that are not language dependent e.g.
In my mods I put these always in a defines.php located in /include/ subdirectory of module root. Perhaps a standard can be established for this.
Additional point for security: According to Shifflet (Essential PHP Security) it would be better if a/ all included files had a .inc extension rather than .php and b/ included files are outside of web document root. Point a is relatively easy to enforce (although XOOPS core will require wholesale change to comply.) Point b is not so easy as the XOOPS directory structure will need re-working and it screws up the easy distribution of modules. Not sure we can implement b but a should be easy enough to insist upon.