1
SMEDrieben
Publisher 1.02 Final: bug in pagenav
  • 2016/3/13 12:27

  • SMEDrieben

  • Not too shy to talk

  • Posts: 173

  • Since: 2009/6/17


In Publisher 1.02, the pagenav that arranges page navigation if [pagebreak] codes are included doesn't work correctly. E.g. if you click in the navigator for page 2 the URL looks like:

http://www.yourdomain.nl/modules/publisher/item.php?page=1&itemid=


The problem is that the number of the itemid is lacking. E.g. if we are reading item 18, then the URL should be:

http://www.yourdomain.nl/modules/publisher/item.php?page=1&itemid=18


It can be repaired by changing line 164 of modules/publisher/item.php from

$pagenav = new XoopsPageNav($itemObj->pagescount(), 1$itemPageId'page''itemid=' $itemObj->itemId());


into

$pagenav = new XoopsPageNav($itemObj->pagescount(), 1$itemPageId'page''itemid=' $itemObj->itemid());


i.e.: the capital I in itemId is changed into a lower case i.
I don't know if this is the best solution, but it works.

SMEDrieben

XOOPS 2.5.7.2
PHP Versie 5.6.17-0+deb8u1
mySQL 5.5.47-0+deb8u1-log
Publisher 1.02 Final

2
Mamba
Re: Publisher 1.02 Final: bug in pagenav
  • 2016/3/14 11:28

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Thank you for testing and for submitting a fix!

I am testing Publisher on XOOPS 2.5.8 and PHP 7, and will test your fix there...
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs

Login

Who's Online

305 user(s) are online (191 user(s) are browsing Support Forums)


Members: 0


Guests: 305


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits