3
BJS3D,
I think I'd use an approach like the one below. It's a little simpler and should eliminate the occassional 'blank' return - unless there's nothing in the directory. It also allows jpg and png files, if desired.
NOTE: This code is untested - so try it before you put it on a 'live' site
n";
// CLOSES THE DIRECTORY BEFORE END SCRIPT
closedir($handle);
}
?>
I think I'd use an approach like the one below. It's a little simpler and should eliminate the occassional 'blank' return - unless there's nothing in the directory. It also allows jpg and png files, if desired.
NOTE: This code is untested - so try it before you put it on a 'live' site
$imageDir = 'uploads/TDMDownloads/images/shots/';
$allowedExtensions = array('jpg', 'jpeg', 'png');
// OPENS THE DIRECTORY
if ($handle = opendir($imageDir)) {
$narray = array();
// READS THE DIRECTORY
while (false !== ($file = readdir($handle))) {
// RETURNS A LIST OF FILES IN THE DIRECTORY
if (is_file($file)) {
$path_parts = pathinfo($imageDir . $file);
if (in_array(strtolower($path_parts['extension']), $allowedExtensions)) {
// CREATES AN ARRAY OF THE LIST
$narray[] = array('filename' => $path_parts['filename'],
'extension' => $path_parts['extension']);
}
}
}
// CHOOSES A RANDOM FILE FROM THE ARRAY
$j = rand(0, count($narray)-1);
$image = "{$narray[$j]['filename']}.{$narray[$j]['extension']}";
// CONVERTING RAW IMAGE NAME INTO LISTING-SPECIFIC URL
// CHANGES THE 'CID' IN FILENAME TO 'CID='
$filename = str_replace('cid', 'cid=', $narray[$j]['filename']);
// CHANGES THE 'LID' IN FILENAME TO '&LID='
$filename = str_replace('lid', '&lid=', $filename);
// ADDS STRING 'FILENAME' TO END OF URL FOR DOWNLOAD LINK
// DISPLAY THE LINK
echo "{$filename}'>{$image}' /> // CLOSES THE DIRECTORY BEFORE END SCRIPT
closedir($handle);
}
?>
4
CGFX Live Test
Thank you again for posting, zyspec. Your code looks a lot more efficient and effective than mine. I'll probably have a play with it to see if I can get it working. :P
zyspec,
Thank you for posting but I was unable to get the code to return anything but a blank string. Zyspec Live Test You did, however, prompt me to sharpen my code a bit since the way a blank string was handled was a bit redundant.
BTW: why it even returns a blank string is a peculiar issue. How is a blink string ending up in the array? Better yet, how could I check for and remove that from the array before choosing a random string?
Here's my update to the original code with error handling done immediately after the creation of string '$filename' instead of after creating '$image$extension':
n";
closedir($handle);
}
?>
Thank you for posting but I was unable to get the code to return anything but a blank string. Zyspec Live Test You did, however, prompt me to sharpen my code a bit since the way a blank string was handled was a bit redundant.
BTW: why it even returns a blank string is a peculiar issue. How is a blink string ending up in the array? Better yet, how could I check for and remove that from the array before choosing a random string?
Here's my update to the original code with error handling done immediately after the creation of string '$filename' instead of after creating '$image$extension':
if ($handle = opendir('uploads/TDMDownloads/images/shots/')) {
while (false !== ($file = readdir($handle))) {
if ($file != "." && $file != "..") {
$file = substr($file, 0 , -4);
$narray[$i]=$file;
$i++;
}
$extension = ".jpg";
$j = rand(0, $i-1);
$filename = "$narray[$j]";
if ($filename=="") {
$filename = "cid68lid2";
}
$image = "$filename$extension";
$filename = str_replace('cid', 'cid=', $filename);
$filename = str_replace('lid', '&lid=', $filename);
}
echo "center">_parent" title="Click image to view download" href="http://coastalgfx.com/modules/TDMDownloads/singlefile.php?" . $filename . ""> closedir($handle);
}
?>
CGFX Live Test
Thank you again for posting, zyspec. Your code looks a lot more efficient and effective than mine. I'll probably have a play with it to see if I can get it working. :P
5
Sorry for the delayed response. I'll have to look at my code to see what's going on when I get time - I don't have TDMDownloads loaded on my test server right now. With a couple of well placed debug messages on the test server I could debug it pretty quickly.
The main thing you need to change in your code above is to put the ending brace for the 'while' statement immediately after the end of the first 'if' statement. The way the code works now is that it executes a bunch of unnecessary code everytime through the while loop.
Are there 'other' files in the directory (like index.html)? That would explain why you get 'blank' images.
The main thing you need to change in your code above is to put the ending brace for the 'while' statement immediately after the end of the first 'if' statement. The way the code works now is that it executes a bunch of unnecessary code everytime through the while loop.
Are there 'other' files in the directory (like index.html)? That would explain why you get 'blank' images.
6
Again, here's how the block is setup:
Thanks for the reply and I look forward to your input.
Is this the code change you're suggesting:
n";
closedir($handle);
}
?>
Hi zyspec,
No worries. What I have now is working. Having said that, 'working' doesn't mean 'correctly coded'. By all logic, your code should have functioned and it's beyond my extremely limited php vocabulary as to why it's not. It's not an extremely pressing issue, though, so definitely don't lose any sleep. TDM, though, will definitely benefit from your code as this feature is far more effective than simply displaying a random shots image with no link to the actual entry.
I ended up reworking the problem of the blank string by forcing a default in the event a string returns null. So far, this is working 100% of the time without error. There were no other file formats in the directory, though, which is why the return of a null string is a mystery. I classified the problem as 'coding error' and handled it as best as a CG artist could.
I also fixed a redundancy issue. The error-catching is now done prior to the image and filename conversions.
n";
closedir($handle);
}
?>
No worries. What I have now is working. Having said that, 'working' doesn't mean 'correctly coded'. By all logic, your code should have functioned and it's beyond my extremely limited php vocabulary as to why it's not. It's not an extremely pressing issue, though, so definitely don't lose any sleep. TDM, though, will definitely benefit from your code as this feature is far more effective than simply displaying a random shots image with no link to the actual entry.
I ended up reworking the problem of the blank string by forcing a default in the event a string returns null. So far, this is working 100% of the time without error. There were no other file formats in the directory, though, which is why the return of a null string is a mystery. I classified the problem as 'coding error' and handled it as best as a CG artist could.
I also fixed a redundancy issue. The error-catching is now done prior to the image and filename conversions.
if ($handle = opendir('uploads/TDMDownloads/images/shots/')) {
while (false !== ($file = readdir($handle))) {
if ($file != "." && $file != "..") {
$file = substr($file, 0 , -4);
$narray[$i]=$file;
$i++;
}
$extension = ".jpg";
$j = rand(0, $i-1);
$filename = "$narray[$j]";
if ($filename=="") {
$filename = "cid68lid2";
}
$image = "$filename$extension";
$filename = str_replace('cid', 'cid=', $filename);
$filename = str_replace('lid', '&lid=', $filename);
}
echo "center">_parent" title="Click image to view download" href="http://coastalgfx.com/modules/TDMDownloads/singlefile.php?" . $filename . ""> closedir($handle);
}
?>
Again, here's how the block is setup:
<div align="left" style="verticle-align:top;"><Iframe src="http://coastalgfx.com/randcgi.php" width="172" height="172" frameborder="0" scrolling="no" marginheight="0" marginwidth="0">Iframe>div>
<div align="center"><Iframe src="http://coastalgfx.com/dl_count.php" width="164" height="27" frameborder="0" scrolling="no">Iframe>div> Thanks for the reply and I look forward to your input.
Is this the code change you're suggesting:
if ($handle = opendir('uploads/TDMDownloads/images/shots/')) {
while (false !== ($file = readdir($handle))) {
if ($file != "." && $file != "..") {
$file = substr($file, 0 , -4);
$narray[$i]=$file;
$i++;
}
}
$extension = ".jpg";
$j = rand(0, $i-1);
$filename = "$narray[$j]";
if ($filename=="") {
$filename = "cid68lid2";
}
$image = "$filename$extension";
$filename = str_replace('cid', 'cid=', $filename);
$filename = str_replace('lid', '&lid=', $filename);
echo "center">_parent" title="Click image to view download" href="http://coastalgfx.com/modules/TDMDownloads/singlefile.php?" . $filename . ""> closedir($handle);
}
?>
7
zyspec,
Your code alteration works perfectly. Thank you.
Random TDM Image Link Test
Also moved the extension string down with the rest of the defined strings:
n";
closedir($handle);
}
?>
Your code alteration works perfectly. Thank you.
Random TDM Image Link Test
Also moved the extension string down with the rest of the defined strings:
if ($handle = opendir('uploads/TDMDownloads/images/shots/')) {
while (false !== ($file = readdir($handle))) {
if ($file != "." && $file != "..") {
$file = substr($file, 0 , -4);
$narray[$i]=$file;
$i++;
}
}
$j = rand(0, $i-1);
$filename = "$narray[$j]";
if ($filename=="") {
$filename = "cid68lid2";
}
$extension = ".jpg";
$image = "$filename$extension";
$filename = str_replace('cid', 'cid=', $filename);
$filename = str_replace('lid', '&lid=', $filename);
echo "center">_parent" title="Click image to view download" href="http://coastalgfx.com/modules/TDMDownloads/singlefile.php?" . $filename . ""> closedir($handle);
}
?>
Login
Search
Recent Posts
Who's Online
Donat-O-Meter
| Stats | |
| Goal: | $100.00 |
| Due Date: | Nov 30 |
| Gross Amount: | $0.00 |
| Net Balance: | $0.00 |
| Left to go: | $100.00 |
 |
|