You are still using the inverse logic!
It is not the module its fault that it has problems with the new core!
It is the core that makes problems for the module and thus it is the core that contains the bug and it is the core that should be altered to resolve this!!!
And with your example of image.php, you are proving my point:
Quote:
It would take several modules that must repeat above code, while doing once in the core would be fit for all.
This bootstrapping and preparing for use is typical something the core must do and not introduce it to other modules and files.
(If you reason further on your path, we can set up in modules a database connection of our own and finally, we don't need a core at all, because we did all setups ourselves.)
These initializations and bootstrapping or whatever you want to call it, were not needed before the changes and there is no reason why they should be needed after. It is not up to the modules for making the core functions and initialisations, that lack, complete.
It simply means the implementation of the changes is half work. It only provides for the nocommon false case. Because, if the core did not do this bootstrapping, then we were now facing the fact that all modules were invalidated and needed additional bootstrap code in order to stay running.
That would not make very much sense, would it?
So, please complete the core for the nocommon true case. A first step is what I already have done in the previous posts by adding code. I think for the things that I rolled back, also some code could be added from your code exemples in order to make it run, without further changes forthe existing modules and thus making the core truely compatible with the previous versions.
