11
voltan
Re: d3downloads 1.47 and xoops 2.4.1
  • 2010/8/18 4:48

  • voltan

  • Theme Designer

  • Posts: 724

  • Since: 2006/12/5


Please fix it !

12
ghia
Re: d3downloads 1.47 and xoops 2.4.1
  • 2010/8/18 10:35

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


First of all, it is a somehow a bug in the module, because in the plugin class xoopsformelement is tested, while the XoopsFormDhtmlTextArea class is used.
The included xoopsformloader.php includes all xoopsformxxxx classes, including the two before mentioned.

So, the author of the module assumed that these classes will be always loaded togheter and not individually. I don't know if that was a rightful assumption and that it was upholded always in previous versions of the XOOPS core. (Probably yes, because nobody complained before)
But fixing the modules Smarty plugin, will always work in every XOOPS version.

Technically, for PHP there is no reason, why all these classes should be included at once and you can use most individually or with only a few others having some benefit in time and memory.

Question is now if there was some API rule that the form elements needed to be included always togheter and not to be loaded individually. If so, this could be considered as a compatibility bug.

Note that, if the classes are not loaded by the core, you could run into the same problem, when you have another module that does also only the include of some individual formelements.

Login

Who's Online

239 user(s) are online (136 user(s) are browsing Support Forums)


Members: 0


Guests: 239


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits