XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. 2.4.x Support 
  4.  / Message icons in newbb under 2.4.2
Register
1
barryc
Message icons in newbb under 2.4.2

  • 2009/12/2 18:36

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


I'm not sure if this is the best place to post this, rather than the modules forums. I have just updated my site to 2.4.2. I notice that now the forum icons that appear above the text box when posting a message are arranged vertically rather than horizontally. This is unattractive and a waste of screen space. This seems to be a consequence of the upgrade. Is there a way to either rearrange or eliminate those icons? There must be a way to rearrange them because I notice they are horizontal above this window.

[Edit] OK, it just occurred to me that this might be a theme problem, and it is. If I use a different theme the icons are horizontal. I'll have to look closely at the theme I use as the default (zen-ocean). Of course, if any of you CSS experts out there can quickly see the problem, I'd appreciate your advice.

barryc
2
skyangelo
Re: Message icons in newbb under 2.4.2

  • 2009/12/3 14:36

  • skyangelo

  • Just popping in

  • Posts: 79

  • Since: 2005/4/9 1


same thing happens to me
3
ghia
Re: Message icons in newbb under 2.4.2

  • 2009/12/3 16:03

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


It is because since 2.4.x these little images were enclosed in a label tag (change in /class/xoopsform/formradio.php).

Your theme includes a CSS rule
display: block;
for label in forms.css

You can remove that rule, which may have other problems on the theme or add
label[name="xolb_icon"] {
display:inline;
}
after that selector.
4
barryc
Re: Message icons in newbb under 2.4.2

  • 2009/12/3 16:07

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


Quote:

skyangelo wrote:
same thing happens to me


What theme are you using? As I said above, I am using a slightly modified version of Kris's zen-ocean. You can see the effect by looking at http://www.aka.org. Just start a post and you'll see it but you'd have to register to do so.

Here is an image showing the effect

Resized Image


I am still trying to figure out why this is happening. Obviously a line feed is being inserted after every radio button and message icon and it must be a problem with the theme CSS. However, so far I haven't been able to find identifiers in the theme corresponding to these elements.

Again, if anyone can point to where the problem might lie, I'd truly appreciate it.

Also, the required caption marker is being inserted for every element in the form. Ghia posted some code recently related to this problem on the XOOPS site. However, I was not sure where to place that code in my theme. Ghia, if you see this?

barryc
5
ghia
Re: Message icons in newbb under 2.4.2

  • 2009/12/3 16:32

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Barry, I think you missed my post, while posting yours.
6
barryc
Re: Message icons in newbb under 2.4.2

  • 2009/12/3 16:54

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


ghia,

indeed I did. I could see in the page source the label tags but didn't know about the change in 2.4 that caused this effect. I chose your second option, adding the code below the existing label selector and it works fine now. Once again, I am in your debt.

Incidentally, you probably saw my question about the * caption marker appearing for every element in the form. As I said, I saw your post some days ago about this on the XOOPS site. Can you make any comment about it relevant to these forms in bbedit, etc? Where in the CSS would the code you suggested be placed?

barryc
7
barryc
Re: Message icons in newbb under 2.4.2

  • 2009/12/3 17:47

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


Actually, I had to add some selectors in the CSS for the checkboxes that are at the bottom of the form (use html, etc). So, I added multiple selectors, as below. I am putting these in full as there is at least one other person with the same issue.

label[name="xolb_icon"] {
display:inline;
}
label[name="xolb_dohtml"] {
display:inline;
}
label[name="xolb_dosmiley"] {
display:inline;
}
label[name="xolb_doxcode"] {
display:inline;
}
label[name="xolb_dobr"] {
display:inline;
}
label[name="xolb_attachsig"] {
display:inline;
}
label[name="xolb_notify"] {
display:inline;
}


It might be possible to simplify this by enclosing multiple names after name= but I am not sure of that and couldn't find a reference to it online. Perhaps you would comment, ghia?

I notice that there is a hard space inserted after each line for the checkboxes. It might look better if there were, instead, a space between the checkbox and the line of text that follows.

barryc
8
ghia
Re: Message icons in newbb under 2.4.2

  • 2009/12/4 0:57

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Yeah, it would be easier if these things had a class as xoradio, xocheckbox, etc

You can have them all in one line separated by commas as
label[name="xolb_icon"] , llabel[name="xolb_dohtml"], label[name="xolb_dosmiley"], ... {
and maybe
label[name|="xolb"]  {
might also work.

For the caption marker, you can add that everywhere. As long as the CSS file is loaded with the form. For Zen-Ocean maybe forms.css or the general style.css

For the spacing, you could also add some margin with the CSS.
9
barryc
Re: Message icons in newbb under 2.4.2

  • 2009/12/4 17:06

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


Quote:

ghia wrote:
and maybe

label[name|="xolb"]  {


might also work.


I tried that option first as it seemed the cleanest, but it did not work. So, I ended up with

label[name="xolb_icon"], [name="xolb_dohtml"], [name="xolb_dosmiley"], [name="xolb_doxcode"], [name="xolb_dobr"], [name="xolb_attachsig"], [name="xolb_attachsig"], [name="xolb_notify"] {
margin-left:                        0.5em;
display:                            inline;
}


At first I had a space between label and [name="xolb_icon]. That does not work. There can be no space there, although there can be between the commas and the next iteration of name. I also added a left margin of 0.5em, as you suggested.

Thanks for the help, ghia. This is neater.

barryc
10
wishcraft
Re: Message icons in newbb under 2.4.2

This is due to WCAG2, this means that people which have sight disability can use XOOPS... Yeah it is a stylesheet change that needs to happen.

label {
   display: inline;
}
(1) 2 3 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

341 user(s) are online (217 user(s) are browsing Support Forums)

Members: 0

Guests: 341

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits