1
tititou36
Re: xoopspoll 1.2 (for xoops 2.3.x) with CBB 3.08
  • 2009/9/11 18:32

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


Where can i find the version 1.2 that people talk about in this post ?

SVN repository only seems to have version 1.0.
Xoops_classics Mamba sent me a few weeks ago alos has this 1.0 version.



2
tititou36
Re: xoopspoll 1.2 (for xoops 2.3.x) with CBB 3.08
  • 2009/9/11 16:23

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


I'll try to take time to have a look at this module.

TiTou



3
tititou36
Why transalation are not available in trunk ?
  • 2009/9/7 19:49

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


Why aren't the various transalation of XOOPS directly incorporated in the base source code ?

1) From one revision of XOOPS to another, there is no major modification in translation, so maintening these translation up to date should not be to hard.

2) Tools for checking translation completeness are availbale, they could be run before releasing a new version. Developper would have time in the alpha/beta release time, to update their favorites language.

3) unsupported language could be dropped if no one takes time to update them but at least largely supported ones should be, IMO, always available.

CJ



4
tititou36
Question about modules\profile\include\forms.php
  • 2009/9/2 16:01

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


In the control panel, when you go in module 'User Profile' --> 'Fields' and click the 'Edit' button of any field, the page displayed starts with :
string string{$variable)

This is added by line 33 of htdocs\modules\profile\include\forms.php

1) What is the purpose of this line ?
Quote:
echo "string{$variable}" . ' string{$variable} '. $varibale;


2) If it is usefull, IMO, the variable called $varibale should be $variable.

TiTou



5
tititou36
Re: Xoops 2.3.3 xoops_data and xoops_lib
  • 2009/8/24 19:48

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


This means, your issue is solved ?



6
tititou36
Re: Xoops 2.3.3 xoops_data and xoops_lib
  • 2009/8/24 11:40

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


Moving outside the XOOPS directory is not enough.
Xoops performs also a test to see if the 2 directories are readable under the DocumentRoot from apache.

So they should be placed outside XOOPS root AND outside Apache htdocs and sub folders.

In fact, the main idea is : these directories should not be visible from the user, where ever they are.


To have your site work again, you only have, IMO, to have mainfile.php point to the right directories.

Could you post here your mainfile.php in order to see if you missed something when you "messed up" your installation ?



7
tititou36
Re: Generated HTML code layout
  • 2009/8/17 21:40

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


I've looked a bit at these aligned 'problems'.
It seems mostly related to the use of template. All the leading spaces on a line with code dedicated to smarty are also present in the generated HTML.

In nearly all places I have looked at, <{if ...)>, <{foreach ...)> use the same indentation of the HTML code they are mixed with. Things can be even worse with <{includeq ...)>...

For example in theme/default/theme.html :
<table cellspacing="0">
    <
tr>
        <!-- 
Start left blocks loop -->
        <{if 
$xoops_showlblock}>
            <
td id="leftcolumn">
            <{foreach 
item=block from=$xoBlocks.canvas_left}>
                <{
includeq file="$theme_name/theme_blockleft.html"}>
            <{/foreach}>
            </
td>
        <{/if}>
        <!-- 
End left blocks loop -->


In order to keep a clean aligned, all smarty code should be left align and it should be written :
<table cellspacing="0">
    <
tr>
        <!-- 
Start left blocks loop -->
<{if 
$xoops_showlblock}>
        <
td id="leftcolumn">
<{foreach 
item=block from=$xoBlocks.canvas_left}>
<{
includeq file="$theme_name/theme_blockleft.html"}>
<{/foreach}>
        </
td>
<{/if}>
        <!-- 
End left blocks loop -->


Coding standard (https://docs.google.com/View?docID=dgb3svsv_86dx8xcsfr) doesn't speak about the good use of smarty directives.

Doing this, can lead to less readable templates, especially in complex ones. But sometimes, the code can even be, IMO, more readable because smarty code is easier to identify this way...

So my question is :
- Is this acceptable for you ?



8
tititou36
Re: Oxigen problem in icons menu
  • 2009/8/17 20:18

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


I'm also using firefox (3.5.2) and didn't noticed anything.

Please, give me the way to reproduce, for me to check deeper.

BTW, there has recently been an update of all css in the oxygen theme, maybe, if not done yet, you should empty your browser cache ?



9
tititou36
Re: Could 'preference' navigation be improved when configuring modules ?
  • 2009/8/17 19:53

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


Hi,

1] with your patch, I do have strange behaviour when I go, with oxygen theme, in the menu 'preferences' value 'system'.

I get a "Taking you back to where you were..." message. I think it is related to the redirection you talked about, but anyway, this is strange.

2] More over, I think that displaying the module name of the preferences we are editing is a good idea but it is not displayed the way as the other 'main preferences' category. You use <h3> and the oxygen.php file seems to use something like <div id="containBodyCP"><div id="bodyCP">



10
tititou36
Re: Generated HTML code layout
  • 2009/8/16 13:36

  • tititou36

  • Just popping in

  • Posts: 16

  • Since: 2009/8/15


Ok, i'll work on it in order to improve XOOPS the way I can.

Where should I post patches ? SF.net patches tracker ? One of the forum in xoops.org ? Mail ? Direct update of SVN repository ?

What is the prefered format ? Diff file ? Complete modified file ?




TopTop
(1) 2 »



Login

Who's Online

131 user(s) are online (70 user(s) are browsing Support Forums)


Members: 0


Guests: 131


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Mar 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits