WF-Downloads module 3.23 beta ready for testing - Modules - XOOPS News

Re: WF-Downloads module 3.23 beta ready for testing

Mamba Published 09/15/2013 16:52 Moderator Joined 04/23/2004 Comments 11366

Nice work, Lucio!!! Thank you!!!

Re: WF-Downloads module 3.23 beta ready for testing

Published 09/15/2013 18:38 Joined Comments

I did not have time to test your improvements yet...

In the previous version it is not possible to remove rating, reviews and comment info from the downloads page. There is also an outdated downloads speed block with modem and isdn speeds. Is it possible to add admin functions for disabling these functions in the user display? This would make the module more suitable for professional use (none community websites). Same for submitter and publisher info. I can imagine a company offering downloads just likes to have a clean downloads page without all those info.

Re: WF-Downloads module 3.23 beta ready for testing

luciorota Published 09/15/2013 19:14 Module Developer Joined 04/20/2007 Comments 216

thanks flipse

i think these are template issues, with a well customized template you can remove unwanted informations.
but... tell me: it could be useful have module options to enabe/disable extra informations? if yes i can work on it...

thanks again, Lucio

Re: WF-Downloads module 3.23 beta ready for testing

luciorota Published 09/15/2013 21:52 Module Developer Joined 04/20/2007 Comments 216

- added: enable/disable reviews system (luciorota)
- added: enable/disable ratings system (luciorota)

Just committed on repository

Re: WF-Downloads module 3.23 beta ready for testing

Published 09/16/2013 8:30 Joined Comments

Thank you!

Re: WF-Downloads module 3.23 beta ready for testing

luciorota Published 09/16/2013 8:49 Module Developer Joined 04/20/2007 Comments 216

- added: enable/disable brokens reports system (luciorota)

I will commit this evening...

Re: WF-Downloads module 3.23 beta ready for testing

luciorota Published 09/20/2013 9:17 Module Developer Joined 04/20/2007 Comments 216

- added: module is clonable, module cloner function (trabis/luciorota)
this evening on repository

Stefan Ilivanov (aka DCrussader) suggested me to change the name of the module in fact, line by line, in the module has changed a lot.
My "name generator device" is broken ... so... I ask your help, what could be the new module name?

Re: WF-Downloads module 3.23 beta ready for testing

Cesagonchu Published 09/20/2013 10:05 Moderator Joined 02/01/2010 Comments 892

First thing, we have to list existing name modules. After that, we can imagine a name

Re: WF-Downloads module 3.23 beta ready for testing

Mamba Published 09/20/2013 10:45 Updated 09/20/2013 10:47 Moderator Joined 04/23/2004 Comments 11366

Why change the name? Just because it has been improved, it would be the wrong reason to do it.

We would be causing a lot of issues for a user who has now "wfdownloads" installed, with a lot of links pointed to his downloads?

It's easier to keep as is, and if the user wants to change the name to something else, the "clone" function is built-in, so he could do it.

But let's avoid causing problems for users who currently are using "wfdownloads", and only would like to update the module.

XOOPS was always proud of making a migration or updates an easy thing - let's keep it that way

Re: WF-Downloads module 3.23 beta ready for testing

Published 09/20/2013 10:48 Joined Comments

You could call the module WF-Downloads+ or maybe WF-Downloads NG (next or new generation)? I would not drop the WF part, so it remains clear where the module came from.

Re: WF-Downloads module 3.23 beta ready for testing

DCrussader Published 09/29/2013 17:14 Friend of XOOPS Joined 07/04/2005 Comments 573

Good suggestion Filipse, but WF-Downloads x.xx forked by unknown 1 or 2, how the users will ask for support.

Re: WF-Downloads module 3.23 beta ready for testing

Mamba Published 09/29/2013 21:59 Updated 09/29/2013 22:06 Moderator Joined 04/23/2004 Comments 11366

Stefan, the easiest way to confuse users is to start changing names. What will this accomplish?

Just look from the user perspective - they have installed a "download" module in the directory /wfdownloads. They have maybe hundreds or thousands of other people with links to various downloads like:

http://mysite.com/modules/wfdownloads/singlefile.php?cid=101&lid=2055

So the only thing that they want is to copy files form a new version over the existing files, click on "update", and they are done. 3 minutes max, and they have a newer version, and they can move on.

If we change the name, what will the user need to do?

How and where will he install the new version?

How will he import/convert the database ?

How will he convert the links so all the links from around the world that point to his downloads are not broken?

Is doing this all to this user a proof of us being "user-driven"?

The new features and functionality is reflected in the version number.

We are not a commercial entity that needs to confuse the users by new name, so they have to buy the new version in order for us to make money.

Apache is still Apache, Linux is still Linux, and Firefox is still Firefox, even if the developers have changed many time over.

But there is a difference between forking and creating a new and different version, and between taking over maintenance and new development of an existing module.

When Catzwolf moved away from WF-Downloads, SmartFactory took over the development. When they moved on, I've updated it to the XOOPS 2.5.5 GUI, and now Lucio is doing some awesome refactoring and adding some cool new features.

So it is still the same module, just the "maintainers" or "custodians" have changed.

But from the user perspective it doesn't matter who maintains it, as long as he can just copy the files over and update it.

Re: WF-Downloads module 3.23 beta ready for testing

DCrussader Published 09/30/2013 15:13 Updated 09/30/2013 15:21 Friend of XOOPS Joined 07/04/2005 Comments 573

Quote:

But from the user perspective it doesn't matter who maintains it, as long as he can just copy the files over and update it.

There are u totally wrong!
Can show u five 2.5.6 compatible releases by different authors giving and removing different features from the module. Module A by Random 1 have Feature 1, while Module B by Random 2 don't have Feature 1, but have other features.

This is same shitty story like Wishcraft profile module and XOOPS distributed module, while first in some cases brakes XOOPS stability, 2nd one offers nothing new then the one existing in 2.3.0.

So for the user - how he/she will ask about bugs with Wishcraft Profile which is named Profile and XOOPS distributed one which is named again Profile ?

FTP way first is not "user friendly", 2nd - there is no way to make a difference between both.

There are thousand a ways and examples in Xoops 2.0 modules how some stuff from Module A can be imported into Module B.

Such excuses, for moving XOOPS and it's 3rd party additions to nowhere for last few years is pointless, everyone else can make FORK, and to include import script/steps from the forked original version, but no. Here everyone can mess on one module in different revisions, to releases different Main.Major.Minor releases by someone from nowhere and people (bcz it's easiest CMS ever) should monitor SVN/GIT, what the current author added to which release and what the user have installed.....

Anyway, looks like and thousand new leaders to take up the leadership - XOOPS will remain on stage 2.3.0..... keep up the good work, mess up with revisions, keep everything under one name... really got tired of receiving non-sense answers of so simple things.

Re: WF-Downloads module 3.23 beta ready for testing

chco2 Published 09/30/2013 23:51 Module Developer Joined 03/05/2004 Comments 374

Totally wrong, shitty, thousands of new leaders. Sounds like someone needs to take a Whiskey and chill for bit.
There needs to be structure in module development. If someone adds/changes/upgrades/make compatible/and more stuff in a certain module, the module name remains the same. Code is based on a source that is not yours and thus you do not mess with the name.
If you have created a module loosely based on an already made source/module, just mention the original author/person who came up with the idea and name the module whatever you like. An admin of a website then has to make the choice himself, NOT THE MODULE MAKER, it is not up to him/her if an admin needs to make changes.

Re: WF-Downloads module 3.23 beta ready for testing

luciorota Published 04/14/2014 18:13 Module Developer Joined 04/20/2007 Comments 216

I've just committed the last modifications to WF-Downloads module.
It's RELEASE CANDIDATE 1
It is "STILL RC... do not use this module on active sites
The latest version on is in the XOOPS SVN
Are there bugs? I don't know... thanks for helping me in debugging phase.

Lucio

changelog:

- added: preview for images, audio, video, pdf files (luciorota)
- added: calculate real upload file size limit (luciorota)
- fixed: upload files with spacial chairs in name (luciorota)
- added: calculate file size also for local files (luciorota)
- added: use XoopsLocal::formatTimestamp (luciorota)
- update jQuery Thickbox plugin to 3.1 (luciorota)
- fixed: jQuery bug in templates (luciorota)
- standardization of English language files (cesag)
- fixed: typos in english folder (cesag)
- module standardization: header.php, admin/admin_header.php, xoops_version.php
- module standardization: standardize directories/files names/structures
- module standardization: standardize code headers
- module standardization: use WfdownloadWfdownload object instead of $xoopsModule, $xoopsModuleConfig and xoops_getmodulehandler (luciorota)
- refactorized admin menu (luciorota)
- fixed: lack of variables in wfdownloads_viewcat.html template (luciorota)
- fixed: update procedure now updates also permissions (luciorota)
- fixed: language definition in modinfo.php (luciorota)
- fixed: language definition in main.php (luciorota)
- fixed: deprecated "XoopsTree" (luciorota)
- fixed: html errors in templates (luciorota)
- fixed: deprecated XoopsTree (mamba)
- fixed: English translations (mamba)
- added: dohtm, dosmiley ,doxcode, doimage, dobr fields to download object (luciorota)
- added: updating to XOOPS 2.5.7 Multi-page help (mamba)
- added: updating to XOOPS 2.5.7 Multi-page help (mamba)
- added: enable/disable reviews system (luciorota)
- added: enable/disable ratings system (luciorota)
- added: enable/disable brokens reports system (luciorota)
- added: filter downloads by title, category, submitter, ... in admin side (luciorota)
- added: breadcrumb class (luciorota)
- added: new auto summary option: auto summary if summary field is empty (luciorota)
- added: new auto summary option: plain text or html auto summary (luciorota)
- added: xoops/xlanguage/html tags compatible auto summary generator (luciorota)
- added: sort subcategories by cid or title or weight (luciorota)
- added: improved by letters choice bar (luciorota)
- added: wfdownloads_submit.html template for submit.php (luciorota)
- added: folder checker (mamba + luciorota)
- added: file checker (luciorota)
- added: module is clonable, built-in module clone function (trabis/luciorota)
- added: cloned module can import data from wfdownloads (luciorota)
- added: user links to downloaders/voters (mamba)
- removed: unupgraded languages from repository (luciorota)
- removed: unused templates (luciorota)
- removed: unused images files (luciorota)

Re: WF-Downloads module 3.23 beta ready for testing

Mamba Published 04/15/2014 8:39 Updated 04/15/2014 9:04 Moderator Joined 04/23/2004 Comments 11366

Quote:

- added: preview for images, audio, video, pdf files (luciorota)

This is very cool! I like it a lot!

I've added some changes to the source code, on which I was working previously:

Quote:

- replaced Thickbox with MagnificPopup
- fixed: source code for HTML5/CSS3
- moved module.css, and /js and /images to /assets folder
- fixed review for Admin: Admin doesn't need approval
- added: missing mp3 tag for preview
- replaced: custom uploader with XoopsMediaUploader
- added: no size limit for uploads by Admin

but since I was not sure if you will like them, I've created a separate branch for it. Let's discuss it on the Forums....

Re: WF-Downloads module 3.23 beta ready for testing

luciorota Published 04/15/2014 9:58 Module Developer Joined 04/20/2007 Comments 216

Thanks Mamba

Quote:

- replaced Thickbox with MagnificPopup
- fixed: source code for HTML5/CSS3
- moved module.css, and /js and /images to /assets folder
- fixed review for Admin: Admin doesn't need approval
- added: missing mp3 tag for preview
- added: no size limit for uploads by Admin

OK

Quote:

- replaced: custom uploader with XoopsMediaUploader

NOT OK

Standard XoopsMediaUploader does not manage files with strange chairs in filename:

eg: filename "03 (bepi & the prismas) l’è sa l’estàt (sammer verscion).mp3" will be loaded on uploads/wfdownloads direcroty as "03 (bepi & the prismas) lâ€™Ã¨ sa lâ€™estÃ t (sammer verscion).mp3" ...

this is because XoopsMediaUploader->_copyFile method does not check/filter filename.

In custom XoopsMediaUploader->_copyFile filename will be changed to a "omnicompatible" filename, we could fix XoopsMediaUploader->_copyFile before.

Stats
Goal:	$100.00
Due Date:	Apr 30
Gross Amount:	$0.00
Net Balance:	$0.00
Left to go:	$100.00

Modules: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Re: WF-Downloads module 3.23 beta ready for testing

Login

Search

Recent Comments

Re: XOOPS 2.5.11 Final Released

Re: XOOPS 2.5.11 Final Released

Re: XOOPS 2.5.11 Final Released

Re: XOOPS 2.5.11 Final Released

Re: XOOPS 2.5.11 Final Released

Who's Online

Donat-O-Meter

Latest GitHub Commits

{{ record.sha.slice(0, 7) }} - {{ record.commit.message | truncate }}

Archives

News archives