xoops forums

Zap_English

Quite a regular
Posted on: 2016/5/28 1:07
Zap_English
Zap_English (Show more)
Quite a regular
Posts: 337
Since: 2016/5/24
#11

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

It's a nice module for event schedules and extcal doesn't close

Cesagonchu

Moderator
Posted on: 3/15 15:19
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 852
Since: 2010/2/1 1
#12

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

Bugs reported here:
https://github.com/XoopsModules25x/apcal/issues

Tested with Xoops 2.5.9 beta2.

If anyone can help to solve these bugs, it would be awsome!

Bleekk

Theme Designer
Posted on: 3/15 16:47
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 898
Since: 2002/12/14
#13

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

I habe none of these issues. are you sure the module is uploaded correctly?

Cesagonchu

Moderator
Posted on: 3/15 19:10
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 852
Since: 2010/2/1 1
#14

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

What is your config?

Mine is:
XOOPS Version XOOPS 2.5.9-Beta2 (from today)
PHP Version 7.0.15-0ubuntu0.16.10.4
mySQL Version 5.7.17-0ubuntu0.16.10.1

APCal 2.22 beta1

Cesagonchu

Moderator
Posted on: 3/15 19:31
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 852
Since: 2010/2/1 1
#15

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

Ok I know what was the problem.

When you download the module from Github, its name is apcal-master.

So, I renamed it apcal but if I rename it APCal, most of my bugs are solved.

Now I only get one bug on install:

Notice: Only variables should be assigned by reference in file /modules/apcal/include/oninstall.php line 122

EDIT: no, it has only solved some of them. Take a look at github issues.

zyspec

Module Developer
Posted on: 3/16 0:18
zyspec
zyspec (Show more)
Module Developer
Posts: 1011
Since: 2004/9/21
#16

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

@Cesagonchu,

I have updated a couple of things to address 2 of the open issues you have.... I also commented on the problem you're seeing with the "file not found" error on github issues

You can try my branch (unofficial) to see if this solves the 2 issues you're having. If so then I'll put in a pull request so they become a part of the official branch.

You can download a copy of my branch at https://github.com/zyspec/apcal

Don't forget - you have to rename the directory to "APCal" (case sensitive) BEFORE you install the module.

Dedale

Friend of XOOPS
Posted on: 3/16 0:46
Dedale
Dedale (Show more)
Friend of XOOPS
Posts: 68
Since: 2007/1/12
#17

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

Module name really have to be APCal ... Have not upgraded our Xoops core for a while ... So we don't see the bugs.

Please test zyspec modifications, if they are correct, will add them as the official branch for our module.

We have close our support forum, there was so much spam. Please use this place to tell us what features you would like to see in the futur.

Cesagonchu

Moderator
Posted on: 3/16 0:59
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 852
Since: 2010/2/1 1
#18

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

Thanks for your help zyspec and Dedale, that's wonderful!

Yes I renamed the module but that fixed only 2 or 3 bugs.

I will try your version zyspec and I'll let you know.

For the moment, I need to sleep lol

Cesagonchu

Moderator
Posted on: 3/16 10:53
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 852
Since: 2010/2/1 1
#19

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

Tyvm zyspec, your version solved these 2 bugs:

https://github.com/XoopsModules25x/apcal/issues/7
https://github.com/XoopsModules25x/apcal/issues/2


I still get this error on user side:
https://github.com/XoopsModules25x/apcal/issues/6

Warning: require_once(/modules/APCal /class/APCal.php): failed to open streamNo such file or directory in file /modules/APCal/index.php line 80

zyspec

Module Developer
Posted on: 3/16 11:11
zyspec
zyspec (Show more)
Module Developer
Posts: 1011
Since: 2004/9/21
#20

Re: APCal 2.22 Beta-1 available for testing (XOOPS 2.5.8, PHP 7)

Yeah... sorry about that. geekwright found/fixed the issue (another of the dreaded spaces at the end of the url/path definitions).

I found occurrences of the same problem in numerous other files, so I fixed those too. I think I found them all but let me know if you find anything else. I've updated my branch with the changes. I updated the status to be 'Beta 1b' with a date of 16Mar2017 so you can tell if you have the right "revision".

Sorry, I should have caught that...